========== checkpatch - FAILED WARNING: Statements should start on a tabstop #149: FILE: net/core/dev.h:50: + if (_T) netdev_unlock_ops_compat(_T)); ERROR: trailing statements should be on next line #149: FILE: net/core/dev.h:50: + if (_T) netdev_unlock_ops_compat(_T)); CHECK: Macro argument 'var_name' may be better as '(var_name)' to avoid precedence issues #151: FILE: net/core/dev.h:52: +#define for_each_netdev_lock_ops_compat_scoped(net, var_name, ifindex) \ + for (struct net_device *var_name __free(netdev_unlock_ops_compat) = NULL; \ + (var_name = netdev_xa_find_lock_ops_compat(net, var_name, \ + &ifindex)); \ + ifindex++) CHECK: Macro argument 'ifindex' may be better as '(ifindex)' to avoid precedence issues #151: FILE: net/core/dev.h:52: +#define for_each_netdev_lock_ops_compat_scoped(net, var_name, ifindex) \ + for (struct net_device *var_name __free(netdev_unlock_ops_compat) = NULL; \ + (var_name = netdev_xa_find_lock_ops_compat(net, var_name, \ + &ifindex)); \ + ifindex++) WARNING: line length of 83 exceeds 80 columns #152: FILE: net/core/dev.h:53: + for (struct net_device *var_name __free(netdev_unlock_ops_compat) = NULL; \ total: 1 errors, 2 warnings, 2 checks, 110 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0e1e64faff73 ("netdev: add "ops compat locking" helpers") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.