WARNING: externs should be avoided in .c files
#155: FILE: tools/testing/selftests/bpf/bench.c:286:
+extern struct argp bench_string_kfuncs_argp;

WARNING: externs should be avoided in .c files
#172: FILE: tools/testing/selftests/bpf/bench.c:556:
+extern const struct bench bench_string_kfuncs_strlen;

WARNING: externs should be avoided in .c files
#173: FILE: tools/testing/selftests/bpf/bench.c:557:
+extern const struct bench bench_string_kfuncs_strnlen;

WARNING: externs should be avoided in .c files
#174: FILE: tools/testing/selftests/bpf/bench.c:558:
+extern const struct bench bench_string_kfuncs_strchr;

WARNING: externs should be avoided in .c files
#175: FILE: tools/testing/selftests/bpf/bench.c:559:
+extern const struct bench bench_string_kfuncs_strnchr;

WARNING: externs should be avoided in .c files
#176: FILE: tools/testing/selftests/bpf/bench.c:560:
+extern const struct bench bench_string_kfuncs_strchrnul;

WARNING: externs should be avoided in .c files
#177: FILE: tools/testing/selftests/bpf/bench.c:561:
+extern const struct bench bench_string_kfuncs_strnchrnul;

WARNING: externs should be avoided in .c files
#178: FILE: tools/testing/selftests/bpf/bench.c:562:
+extern const struct bench bench_string_kfuncs_strstr;

WARNING: externs should be avoided in .c files
#179: FILE: tools/testing/selftests/bpf/bench.c:563:
+extern const struct bench bench_string_kfuncs_strnstr;

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#201: 
new file mode 100644

WARNING: line length of 84 exceeds 80 columns
#231: FILE: tools/testing/selftests/bpf/benchs/bench_string_kfuncs.c:26:
+static error_t string_kfuncs_parse_arg(int key, char *arg, struct argp_state *state)

WARNING: line length of 87 exceeds 80 columns
#258: FILE: tools/testing/selftests/bpf/benchs/bench_string_kfuncs.c:53:
+		fprintf(stderr, "string_kfuncs benchmark doesn't support consumer!\n");

WARNING: line length of 81 exceeds 80 columns
#295: FILE: tools/testing/selftests/bpf/benchs/bench_string_kfuncs.c:90:
+	memcpy(ctx.skel->bss->substr, str + args.str_len - quarter, quarter + 1);

WARNING: line length of 83 exceeds 80 columns
#481: FILE: tools/testing/selftests/bpf/benchs/run_bench_string_kfuncs.sh:11:
+		summarize ${b}-${s} "$($RUN_BENCH --str-len=$s string-kfuncs-${b})"

WARNING: line length of 83 exceeds 80 columns
#488: FILE: tools/testing/selftests/bpf/benchs/run_bench_string_kfuncs.sh:18:
+		summarize ${b}-${s} "$($RUN_BENCH --str-len=$s string-kfuncs-${b})"

WARNING: line length of 83 exceeds 80 columns
#495: FILE: tools/testing/selftests/bpf/benchs/run_bench_string_kfuncs.sh:25:
+		summarize ${b}-${s} "$($RUN_BENCH --str-len=$s string-kfuncs-${b})"

WARNING: line length of 83 exceeds 80 columns
#502: FILE: tools/testing/selftests/bpf/benchs/run_bench_string_kfuncs.sh:32:
+		summarize ${b}-${s} "$($RUN_BENCH --str-len=$s string-kfuncs-${b})"

WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst
#529: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_bench.c:19:
+const volatile unsigned int str_len = 1;

CHECK: Comparison to NULL could be written "bpf_strchr"
#555: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_bench.c:45:
+	if (bpf_strchr(str, '0') != NULL)

CHECK: Comparison to NULL could be written "bpf_strnchr"
#563: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_bench.c:53:
+	if (bpf_strnchr(str, str_len + 1, '0') != NULL)

CHECK: Comparison to NULL could be written "bpf_strstr"
#587: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_bench.c:77:
+	if (bpf_strstr(str, substr) != NULL)

CHECK: Comparison to NULL could be written "bpf_strnstr"
#595: FILE: tools/testing/selftests/bpf/progs/string_kfuncs_bench.c:85:
+	if (bpf_strnstr(str, str_len + 1, substr, str_len / 4 + 1) != NULL)

total: 0 errors, 18 warnings, 4 checks, 440 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit a7690d7a8658 ("selftests/bpf: Add benchmark for bounded/unbounded string kfuncs") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 18 warnings, 4 checks, 440 lines checked