WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #73: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:34: + volatile struct { WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #76: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:37: + const volatile __u8 var_u8; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #77: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:38: + const volatile __s16 filler3; WARNING: 'struc' may be misspelled - perhaps 'struct'? #82: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:43: +const volatile __u32 struc = 0; /* same prefix as below */ ^^^^^ CHECK: Please use a blank line after function/struct/union/enum declarations #82: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:43: +}; +const volatile __u32 struc = 0; /* same prefix as below */ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #82: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:43: +const volatile __u32 struc = 0; /* same prefix as below */ WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #83: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:44: +const volatile struct Struct struct1 = {.struct2 = {.u = {.var_u8 = 1}}}; WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #99: FILE: tools/testing/selftests/bpf/progs/set_global_vars.c:60: +const volatile union Union union1 = {.var_u16 = -1}; WARNING: line length of 82 exceeds 80 columns #173: FILE: tools/testing/selftests/bpf/veristat.c:1533: + name = btf__name_by_offset(btf, member->name_off); WARNING: line length of 91 exceeds 80 columns #183: FILE: tools/testing/selftests/bpf/veristat.c:1543: + tmp = realloc(anon_stack, (top + 1) * sizeof(*anon_stack)); WARNING: line length of 87 exceeds 80 columns #191: FILE: tools/testing/selftests/bpf/veristat.c:1551: + anon_stack[top++].offset = cur_offset + member->offset; WARNING: line length of 90 exceeds 80 columns #201: FILE: tools/testing/selftests/bpf/veristat.c:1561: + const struct btf_type *t, struct btf_var_secinfo *sinfo) WARNING: line length of 91 exceeds 80 columns #223: FILE: tools/testing/selftests/bpf/veristat.c:1583: + sinfo->offset += (BTF_MEMBER_BIT_OFFSET(member->offset) + anon_offset) / 8; WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #245: FILE: tools/testing/selftests/bpf/veristat.c:1605: + strcpy(expr, var); WARNING: line length of 85 exceeds 80 columns #275: FILE: tools/testing/selftests/bpf/veristat.c:1658: + btf__name_by_offset(btf, base_type->name_off), value, WARNING: line length of 87 exceeds 80 columns #287: FILE: tools/testing/selftests/bpf/veristat.c:1721: + if (strncmp(var_name, presets[k].name, var_len) != 0 || WARNING: line length of 86 exceeds 80 columns #299: FILE: tools/testing/selftests/bpf/veristat.c:1733: + &tmp_sinfo, presets[k].name); WARNING: line length of 93 exceeds 80 columns #304: FILE: tools/testing/selftests/bpf/veristat.c:1737: + err = set_global_var(obj, btf, map, &tmp_sinfo, presets + k); total: 0 errors, 17 warnings, 1 checks, 263 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 82636a5b457f ("selftests/bpf: support struct/union presets in veristat") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 17 warnings, 1 checks, 263 lines checked