WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #72: new file mode 100644 CHECK: Prefer using the BIT macro #122: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:46: +#define NUM_QUEUE (1 << 20) ERROR: Macros with complex values should be enclosed in parentheses #199: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:123: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) WARNING: Prefer __aligned(8) over __attribute__((aligned(8))) #199: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:123: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) WARNING: line length of 81 exceeds 80 columns #205: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:129: +private(B) struct bpf_list_head fq_new_flows __contains(fq_flow_node, list_node); WARNING: line length of 81 exceeds 80 columns #208: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:132: +private(C) struct bpf_list_head fq_old_flows __contains(fq_flow_node, list_node); WARNING: line length of 88 exceeds 80 columns #233: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:157: +static bool fn_time_next_packet_less(struct bpf_rb_node *a, const struct bpf_rb_node *b) WARNING: line length of 88 exceeds 80 columns #291: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:215: +/* flow->age is used to denote the state of the flow (not-detached, detached, throttled) WARNING: line length of 84 exceeds 80 columns #310: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:234: + return (1 << sk->__sk_common.skc_state) & (TCPF_LISTEN | TCPF_NEW_SYN_RECV); CHECK: multiple assignments should be avoided #399: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:323: + time_to_send = q.ktime_cache = bpf_ktime_get_ns(); WARNING: line length of 90 exceeds 80 columns #431: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:355: + if ((s64)(jiffies - (flow_copy->age + q.flow_refill_delay)) > 0) { WARNING: line length of 87 exceeds 80 columns #436: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:360: + fq_flows_add_tail(&fq_new_flows, &fq_new_flows_lock, flow_copy, CHECK: multiple assignments should be avoided #447: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:371: + skbn->tstamp = skb->tstamp = time_to_send; WARNING: line length of 85 exceeds 80 columns #471: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:395: +static int fq_unset_throttled_flows(u32 index, struct unset_throttled_flows_ctx *ctx) WARNING: line length of 84 exceeds 80 columns #500: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:424: + fq_flows_add_tail(&fq_old_flows, &fq_old_flows_lock, flow, &q.old_flow_cnt); WARNING: line length of 92 exceeds 80 columns #571: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:495: + fq_flows_add_tail(&fq_old_flows, &fq_old_flows_lock, flow, &q.old_flow_cnt); WARNING: line length of 100 exceeds 80 columns #581: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:505: + fq_flows_add_tail(&fq_old_flows, &fq_old_flows_lock, flow, &q.old_flow_cnt); CHECK: multiple assignments should be avoided #680: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:604: + q.ktime_cache = cb_ctx.now = bpf_ktime_get_ns(); CHECK: spaces preferred around that '*' (ctx:VxV) #728: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:652: +#define FQ_GC_AGE (3*CONFIG_HZ) ^ total: 1 errors, 13 warnings, 5 checks, 794 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 683ac147e510 ("selftests/bpf: Add a bpf fq qdisc to selftest") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.