CHECK: Macro argument 'iter' may be better as '(iter)' to avoid precedence issues #57: FILE: drivers/net/ethernet/intel/idpf/idpf.h:486: +#define idpf_for_each_vport(adapter, iter) \ + for (struct idpf_vport **__##iter = &(adapter)->vports[0], \ + *iter = (adapter)->max_vports ? *__##iter : NULL; \ + iter; \ + iter = (++__##iter) < &(adapter)->vports[(adapter)->max_vports] ? \ + *__##iter : NULL) CHECK: spinlock_t definition without comment #221: FILE: drivers/net/ethernet/intel/idpf/idpf_ptp.h:142: + spinlock_t lock_in_use; CHECK: spinlock_t definition without comment #222: FILE: drivers/net/ethernet/intel/idpf/idpf_ptp.h:143: + spinlock_t lock_free; CHECK: spinlock_t definition without comment #223: FILE: drivers/net/ethernet/intel/idpf/idpf_ptp.h:144: + spinlock_t lock_status; total: 0 errors, 0 warnings, 4 checks, 437 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c744868a0060 ("idpf: add Tx timestamp capabilities negotiation") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 0 warnings, 4 checks, 437 lines checked