WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #24: new file mode 100644 WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #43: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:15: +static volatile int skip; CHECK: No space is necessary after a cast #47: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:19: + int err, prog_fd = *(u32 *) arg; WARNING: Missing a blank line after declarations #48: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:20: + int err, prog_fd = *(u32 *) arg; + LIBBPF_OPTS(bpf_test_run_opts, topts, CHECK: Alignment should match open parenthesis #49: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:21: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .data_in = &pkt_v4, CHECK: Alignment should match open parenthesis #65: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:37: + LIBBPF_OPTS(bpf_test_run_opts, topts, + .data_in = &pkt_v4, WARNING: line length of 87 exceeds 80 columns #99: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:71: + err = pthread_create(&thread_id[i], NULL, &spin_lock_thread, &prog_fd); WARNING: Missing a blank line after declarations #107: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:79: + int fd = bpf_program__fd(skel->progs.res_spin_lock_test_BA); + while (!topts.retval && !err && !READ_ONCE(skel->bss->err)) { WARNING: braces {} are not necessary for single statement blocks #107: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:79: + while (!topts.retval && !err && !READ_ONCE(skel->bss->err)) { + err = bpf_prog_test_run_opts(fd, &topts); + } WARNING: line length of 81 exceeds 80 columns #114: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:86: + if (!ASSERT_OK(pthread_join(thread_id[i], &ret), "pthread_join")) WARNING: void function return statements are not generally useful #126: FILE: tools/testing/selftests/bpf/prog_tests/res_spin_lock.c:98: + return; +} WARNING: line length of 88 exceeds 80 columns #298: FILE: tools/testing/selftests/bpf/progs/res_spin_lock.c:97: + /* We cannot pass in i as it will get spilled/filled by the compiler and WARNING: line length of 88 exceeds 80 columns #310: FILE: tools/testing/selftests/bpf/progs/res_spin_lock.c:109: + /* We cannot pass in i as it will get spilled/filled by the compiler and WARNING: line length of 100 exceeds 80 columns #385: FILE: tools/testing/selftests/bpf/progs/res_spin_lock_fail.c:35: + bpf_res_spin_lock((struct bpf_res_spin_lock *)bpf_core_cast(&elem->lock, struct __sk_buff)); WARNING: line length of 81 exceeds 80 columns #543: FILE: tools/testing/selftests/bpf/progs/res_spin_lock_fail.c:193: +__failure __msg("off 1 doesn't point to 'struct bpf_res_spin_lock' that is at 0") WARNING: line length of 102 exceeds 80 columns #556: FILE: tools/testing/selftests/bpf/progs/res_spin_lock_fail.c:206: +__failure __msg("R1 doesn't have constant offset. bpf_res_spin_lock has to be at the constant offset") total: 0 errors, 13 warnings, 3 checks, 548 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit d9a9fb40d4fd ("selftests/bpf: Add tests for rqspinlock") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 13 warnings, 3 checks, 548 lines checked