WARNING: please, no space before tabs #133: FILE: include/linux/bpf_verifier.h:269: +^I^IREF_TYPE_RES_LOCK ^I= (1 << 4),$ WARNING: line length of 117 exceeds 80 columns #208: FILE: kernel/bpf/btf.c:5662: + record = btf_parse_fields(btf, t, BPF_SPIN_LOCK | BPF_RES_SPIN_LOCK | BPF_LIST_HEAD | BPF_LIST_NODE | WARNING: line length of 113 exceeds 80 columns #245: FILE: kernel/bpf/syscall.c:1218: + BPF_SPIN_LOCK | BPF_RES_SPIN_LOCK | BPF_TIMER | BPF_KPTR | BPF_LIST_HEAD | WARNING: line length of 92 exceeds 80 columns #266: FILE: kernel/bpf/verifier.c:459: + return btf_record_has_field(reg_btf_record(reg), BPF_SPIN_LOCK | BPF_RES_SPIN_LOCK); WARNING: line length of 94 exceeds 80 columns #293: FILE: kernel/bpf/verifier.c:1190: +static int unmark_stack_slot_irq_flag(struct bpf_verifier_env *env, struct bpf_reg_state *reg, WARNING: line length of 101 exceeds 80 columns #303: FILE: kernel/bpf/verifier.c:1206: + const char *flag_kfunc = st->irq.kfunc_class == IRQ_NATIVE_KFUNC ? "native" : "lock"; WARNING: line length of 93 exceeds 80 columns #304: FILE: kernel/bpf/verifier.c:1207: + const char *used_kfunc = kfunc_class == IRQ_NATIVE_KFUNC ? "native" : "lock"; WARNING: line length of 98 exceeds 80 columns #306: FILE: kernel/bpf/verifier.c:1209: + verbose(env, "irq flag acquired by %s kfuncs cannot be restored with %s kfuncs\n", WARNING: line length of 89 exceeds 80 columns #344: FILE: kernel/bpf/verifier.c:8249: + bool is_lock = flags & PROCESS_SPIN_LOCK, is_res_lock = flags & PROCESS_RES_LOCK; WARNING: line length of 90 exceeds 80 columns #383: FILE: kernel/bpf/verifier.c:8281: + if (!btf_record_has_field(rec, is_res_lock ? BPF_RES_SPIN_LOCK : BPF_SPIN_LOCK)) { WARNING: line length of 85 exceeds 80 columns #384: FILE: kernel/bpf/verifier.c:8282: + verbose(env, "%s '%s' has no valid %s_lock\n", map ? "map" : "local", WARNING: line length of 82 exceeds 80 columns #391: FILE: kernel/bpf/verifier.c:8286: + spin_lock_off = is_res_lock ? rec->res_spin_lock_off : rec->spin_lock_off; WARNING: line length of 90 exceeds 80 columns #393: FILE: kernel/bpf/verifier.c:8288: + verbose(env, "off %lld doesn't point to 'struct %s_lock' that is at %d\n", WARNING: line length of 86 exceeds 80 columns #411: FILE: kernel/bpf/verifier.c:8302: + if (find_lock_state(env->cur_state, REF_TYPE_LOCK, 0, NULL)) { WARNING: line length of 119 exceeds 80 columns #417: FILE: kernel/bpf/verifier.c:8308: + if (find_lock_state(env->cur_state, REF_TYPE_RES_LOCK | REF_TYPE_RES_LOCK_IRQ, reg->id, ptr)) { WARNING: line length of 102 exceeds 80 columns #418: FILE: kernel/bpf/verifier.c:8309: + verbose(env, "Acquiring the same lock again, AA deadlock detected\n"); WARNING: line length of 81 exceeds 80 columns #430: FILE: kernel/bpf/verifier.c:8320: + err = acquire_lock_state(env, env->insn_idx, type, reg->id, ptr); WARNING: line length of 84 exceeds 80 columns #446: FILE: kernel/bpf/verifier.c:8335: + verbose(env, "%s_unlock without taking a lock\n", lock_str); WARNING: line length of 100 exceeds 80 columns #482: FILE: kernel/bpf/verifier.c:11558: + btf_record_has_field(meta.map_ptr->record, BPF_SPIN_LOCK | BPF_RES_SPIN_LOCK)) { WARNING: line length of 94 exceeds 80 columns #492: FILE: kernel/bpf/verifier.c:11730: +static void __mark_btf_func_reg_size(struct bpf_verifier_env *env, struct bpf_reg_state *regs, WARNING: line length of 90 exceeds 80 columns #533: FILE: kernel/bpf/verifier.c:11953: +static bool is_kfunc_arg_res_spin_lock(const struct btf *btf, const struct btf_param *arg) WARNING: line length of 86 exceeds 80 columns #594: FILE: kernel/bpf/verifier.c:12374: + if (meta->func_id == special_kfunc_list[KF_bpf_res_spin_lock_irqsave]) WARNING: line length of 83 exceeds 80 columns #596: FILE: kernel/bpf/verifier.c:12376: + } else if (meta->func_id == special_kfunc_list[KF_bpf_local_irq_restore] || WARNING: line length of 92 exceeds 80 columns #597: FILE: kernel/bpf/verifier.c:12377: + meta->func_id == special_kfunc_list[KF_bpf_res_spin_unlock_irqrestore]) { WARNING: line length of 91 exceeds 80 columns #599: FILE: kernel/bpf/verifier.c:12379: + if (meta->func_id == special_kfunc_list[KF_bpf_res_spin_unlock_irqrestore]) WARNING: line length of 91 exceeds 80 columns #609: FILE: kernel/bpf/verifier.c:12396: + err = mark_stack_slot_irq_flag(env, meta, reg, env->insn_idx, kfunc_class); WARNING: line length of 102 exceeds 80 columns #627: FILE: kernel/bpf/verifier.c:12537: + s = find_lock_state(env->cur_state, REF_TYPE_LOCK | REF_TYPE_RES_LOCK | REF_TYPE_RES_LOCK_IRQ, WARNING: line length of 85 exceeds 80 columns #647: FILE: kernel/bpf/verifier.c:12584: + return is_bpf_graph_api_kfunc(btf_id) || is_bpf_iter_num_api_kfunc(btf_id) || WARNING: line length of 104 exceeds 80 columns #668: FILE: kernel/bpf/verifier.c:13320: + if (reg->type != PTR_TO_MAP_VALUE && reg->type != (PTR_TO_BTF_ID | MEM_ALLOC)) { WARNING: line length of 107 exceeds 80 columns #669: FILE: kernel/bpf/verifier.c:13321: + verbose(env, "arg#%d doesn't point to map value or allocated object\n", i); WARNING: line length of 88 exceeds 80 columns #675: FILE: kernel/bpf/verifier.c:13327: + if (meta->func_id == special_kfunc_list[KF_bpf_res_spin_lock] || WARNING: line length of 94 exceeds 80 columns #676: FILE: kernel/bpf/verifier.c:13328: + meta->func_id == special_kfunc_list[KF_bpf_res_spin_lock_irqsave]) WARNING: line length of 96 exceeds 80 columns #678: FILE: kernel/bpf/verifier.c:13330: + if (meta->func_id == special_kfunc_list[KF_bpf_res_spin_lock_irqsave] || WARNING: line length of 99 exceeds 80 columns #679: FILE: kernel/bpf/verifier.c:13331: + meta->func_id == special_kfunc_list[KF_bpf_res_spin_unlock_irqrestore]) WARNING: line length of 82 exceeds 80 columns #699: FILE: kernel/bpf/verifier.c:13429: + branch = push_stack(env, env->insn_idx + 1, env->insn_idx, false); WARNING: line length of 91 exceeds 80 columns #701: FILE: kernel/bpf/verifier.c:13431: + verbose(env, "failed to push state for failed lock acquisition\n"); WARNING: line length of 81 exceeds 80 columns #712: FILE: kernel/bpf/verifier.c:13442: + err = __mark_reg_s32_range(env, regs, BPF_REG_0, -MAX_ERRNO, -1); WARNING: line length of 103 exceeds 80 columns #714: FILE: kernel/bpf/verifier.c:13444: + verbose(env, "failed to mark s32 range for retval in forked state for lock\n"); WARNING: line length of 107 exceeds 80 columns #727: FILE: kernel/bpf/verifier.c:13620: + if (meta.btf == btf_vmlinux && (meta.func_id == special_kfunc_list[KF_bpf_res_spin_lock] || WARNING: line length of 86 exceeds 80 columns #728: FILE: kernel/bpf/verifier.c:13621: + meta.func_id == special_kfunc_list[KF_bpf_res_spin_lock_irqsave])) CHECK: Alignment should match open parenthesis #728: FILE: kernel/bpf/verifier.c:13621: + if (meta.btf == btf_vmlinux && (meta.func_id == special_kfunc_list[KF_bpf_res_spin_lock] || + meta.func_id == special_kfunc_list[KF_bpf_res_spin_lock_irqsave])) WARNING: line length of 90 exceeds 80 columns #738: FILE: kernel/bpf/verifier.c:18558: + if (!check_ids(old_reg->ref_obj_id, cur_reg->ref_obj_id, idmap) || WARNING: line length of 81 exceeds 80 columns #739: FILE: kernel/bpf/verifier.c:18559: + old_reg->irq.kfunc_class != cur_reg->irq.kfunc_class) WARNING: line length of 83 exceeds 80 columns #757: FILE: kernel/bpf/verifier.c:19890: + if (btf_record_has_field(map->record, BPF_SPIN_LOCK | BPF_RES_SPIN_LOCK)) { total: 0 errors, 43 warnings, 1 checks, 640 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 94dd560f2a58 ("bpf: Implement verifier support for rqspinlock") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 43 warnings, 1 checks, 640 lines checked