WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #39: FILE: tools/testing/selftests/bpf/prog_tests/so_timestamping.c:1: +#include "test_progs.h" WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #124: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:1: +#include "vmlinux.h" WARNING: line length of 81 exceeds 80 columns #191: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:68: +extern int bpf_sock_ops_enable_tx_tstamp(struct bpf_sock_ops_kern *skops) __ksym; WARNING: line length of 84 exceeds 80 columns #231: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:108: + n = bpf_loop(ARRAY_SIZE(sol_socket_tests), bpf_test_socket_sockopt, &lc, 0); WARNING: line length of 90 exceeds 80 columns #247: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:124: + ret = bpf_setsockopt(ctx, level, t->opt, (void *)&t->new, sizeof(t->new)); CHECK: Alignment should match open parenthesis #295: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:172: +static bool bpf_test_access_bpf_calls(struct bpf_sock_ops *skops, + const struct sock *sk) CHECK: multiple assignments should be avoided #355: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:232: + delay = val->sched_delay = timestamp - val->sendmsg_ns; CHECK: multiple assignments should be avoided #359: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:236: + delay = val->sw_snd_delay = timestamp - prior_ts; WARNING: line length of 82 exceeds 80 columns #362: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:239: + prior_ts = val->sw_snd_delay + val->sched_delay + val->sendmsg_ns; CHECK: multiple assignments should be avoided #363: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:240: + delay = val->ack_delay = timestamp - prior_ts; WARNING: line length of 88 exceeds 80 columns #378: FILE: tools/testing/selftests/bpf/progs/so_timestamping.c:255: +int BPF_PROG(trace_tcp_sendmsg_locked, struct sock *sk, struct msghdr *msg, size_t size) total: 0 errors, 8 warnings, 4 checks, 391 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4d8f5bf3d675 ("selftests/bpf: add simple bpf tests in the tx path for timestamping feature") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 8 warnings, 4 checks, 391 lines checked