WARNING: line length of 93 exceeds 80 columns #79: FILE: kernel/bpf/syscall.c:7315: +static int append_subprog_relos(struct bpf_prog_obj *main_prog, struct bpf_prog_obj *subprog) WARNING: line length of 91 exceeds 80 columns #87: FILE: kernel/bpf/syscall.c:7323: + relos = krealloc_array(main_prog->reloc_desc, new_cnt, sizeof(*relos), GFP_KERNEL); WARNING: line length of 99 exceeds 80 columns #118: FILE: kernel/bpf/syscall.c:7354: +static struct bpf_reloc_desc *find_prog_insn_relo(const struct bpf_prog_obj *prog, size_t insn_idx) WARNING: line length of 83 exceeds 80 columns #126: FILE: kernel/bpf/syscall.c:7362: +static int append_subprog_code(struct bpf_obj *obj, struct bpf_prog_obj *main_prog, WARNING: line length of 85 exceeds 80 columns #136: FILE: kernel/bpf/syscall.c:7372: + insns = krealloc_array(main_prog->insn, new_cnt, sizeof(*insns), GFP_KERNEL); WARNING: line length of 85 exceeds 80 columns #138: FILE: kernel/bpf/syscall.c:7374: + pr_warn("prog '%s': failed to realloc prog code\n", main_prog->name); CHECK: Blank lines aren't necessary after an open brace '{' #158: FILE: kernel/bpf/syscall.c:7394: +{ + WARNING: line length of 89 exceeds 80 columns #176: FILE: kernel/bpf/syscall.c:7412: + if (relo && relo->type != RELO_CALL && relo->type != RELO_SUBPROG_ADDR) { WARNING: line length of 88 exceeds 80 columns #189: FILE: kernel/bpf/syscall.c:7425: + * for subprog addr relocation, the relo->sym_off + insn->imm is WARNING: line length of 98 exceeds 80 columns #193: FILE: kernel/bpf/syscall.c:7429: + sub_idx = relo->sym_off / sizeof(struct bpf_insn) + insn->imm + 1; WARNING: line length of 96 exceeds 80 columns #195: FILE: kernel/bpf/syscall.c:7431: + sub_idx = (relo->sym_off + insn->imm) / sizeof(struct bpf_insn); WARNING: line length of 89 exceeds 80 columns #199: FILE: kernel/bpf/syscall.c:7435: + * functions are in the same section, so it shouldn't reach here. WARNING: else is not generally useful after a break or return #204: FILE: kernel/bpf/syscall.c:7440: + return -EOPNOTSUPP; + } else { WARNING: line length of 84 exceeds 80 columns #226: FILE: kernel/bpf/syscall.c:7462: + * - process is recursively, while current program is put on hold; WARNING: line length of 88 exceeds 80 columns #251: FILE: kernel/bpf/syscall.c:7487: + insn->imm = subprog->sub_insn_off - (prog->sub_insn_off + insn_idx) - 1; WARNING: line length of 96 exceeds 80 columns #254: FILE: kernel/bpf/syscall.c:7490: + prog->name, insn_idx, insn->imm, subprog->name, subprog->sub_insn_off); WARNING: line length of 87 exceeds 80 columns #260: FILE: kernel/bpf/syscall.c:7496: +static bool prog_is_subprog(const struct bpf_obj *obj, const struct bpf_prog_obj *prog) CHECK: Blank lines aren't necessary before a close brace '}' #286: FILE: kernel/bpf/syscall.c:7522: + +} WARNING: line length of 84 exceeds 80 columns #299: FILE: kernel/bpf/syscall.c:7535: + /* we turn kfunc call into invalid helper call with identifiable constant */ WARNING: line length of 81 exceeds 80 columns #337: FILE: kernel/bpf/syscall.c:7573: + insn[0].imm = obj->maps[obj->kconfig_map_idx].fd; WARNING: line length of 89 exceeds 80 columns #340: FILE: kernel/bpf/syscall.c:7576: + if (ext->ksym.type_id && ext->is_set) { /* typed ksyms */ WARNING: line length of 82 exceeds 80 columns #343: FILE: kernel/bpf/syscall.c:7579: + insn[1].imm = ext->ksym.kernel_btf_obj_fd; WARNING: line length of 87 exceeds 80 columns #344: FILE: kernel/bpf/syscall.c:7580: + } else { /* typeless ksyms or unresolved typed ksyms */ WARNING: line length of 86 exceeds 80 columns #398: FILE: kernel/bpf/syscall.c:7634: + if (strcmp(prog->name, btf_str_by_offset(obj->btf, t->name_off)) != 0) WARNING: line length of 100 exceeds 80 columns #423: FILE: kernel/bpf/syscall.c:7659: + /* Let's see if we already saw a static exception callback with this name */ WARNING: line length of 94 exceeds 80 columns #436: FILE: kernel/bpf/syscall.c:7672: + pr_warn("prog '%s': cannot find exception callback '%s'\n", prog->name, name); CHECK: Blank lines aren't necessary before a close brace '}' #442: FILE: kernel/bpf/syscall.c:7678: + +} WARNING: line length of 88 exceeds 80 columns #458: FILE: kernel/bpf/syscall.c:7694: + /* mark the insn, so it's recognized by insn_is_pseudo_func() */ WARNING: line length of 90 exceeds 80 columns #483: FILE: kernel/bpf/syscall.c:7719: + /* Now, also append exception callback if it has not been done already. */ WARNING: line length of 91 exceeds 80 columns #485: FILE: kernel/bpf/syscall.c:7721: + struct bpf_prog_obj *subprog = &obj->progs[prog->exception_cb_idx]; WARNING: line length of 87 exceeds 80 columns #487: FILE: kernel/bpf/syscall.c:7723: + /* Calling exception callback directly is disallowed, which the WARNING: line length of 88 exceeds 80 columns #488: FILE: kernel/bpf/syscall.c:7724: + * verifier will reject later. In case it was processed already, WARNING: line length of 88 exceeds 80 columns #489: FILE: kernel/bpf/syscall.c:7725: + * we can skip this step, otherwise for all other valid cases we total: 0 errors, 30 warnings, 3 checks, 507 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f72ba5e913c9 ("bpf: Apply in-kernel bpf instruction relocations") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 30 warnings, 3 checks, 507 lines checked