WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #45: new file mode 100644 WARNING: line length of 81 exceeds 80 columns #108: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:59: +static int send_cmd(int fd, __u16 nlmsg_type, __u32 nlmsg_pid, __u16 nlmsg_flags, CHECK: Alignment should match open parenthesis #109: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:60: +static int send_cmd(int fd, __u16 nlmsg_type, __u32 nlmsg_pid, __u16 nlmsg_flags, + __u8 genl_cmd, __u16 nla_type, CHECK: No space is necessary after a cast #126: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:77: + na = (struct nlattr *) GENLMSG_DATA(&msg); CHECK: No space is necessary after a cast #132: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:83: + buf = (char *) &msg; CHECK: No space is necessary after a cast #137: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:88: + while ((r = sendto(fd, buf, buflen, 0, (struct sockaddr *) &nladdr, CHECK: braces {} should be used on all arms of this statement #139: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:90: + if (r > 0) { [...] + } else if (errno != EAGAIN) [...] CHECK: No space is necessary after a cast #166: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:117: + ret = bind(fd, (struct sockaddr *) &nl_src, sizeof(nl_src)); CHECK: Unnecessary parentheses around 'ret < 0' #178: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:129: + if (!ASSERT_FALSE(msg.n.nlmsg_type == NLMSG_ERROR || (ret < 0) || + !NLMSG_OK((&msg.n), ret), "nl_family response")) CHECK: Unnecessary parentheses around '&msg.n' #178: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:129: + if (!ASSERT_FALSE(msg.n.nlmsg_type == NLMSG_ERROR || (ret < 0) || + !NLMSG_OK((&msg.n), ret), "nl_family response")) CHECK: No space is necessary after a cast #182: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:133: + nl = (struct nlattr *) GENLMSG_DATA(&msg); CHECK: No space is necessary after a cast #183: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:134: + nl = (struct nlattr *) ((char *) nl + NLA_ALIGN(nl->nla_len)); CHECK: No space is necessary after a cast #187: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:138: + smc_nl_family_id = *(uint16_t *) NLA_DATA(nl); CHECK: No space is necessary after a cast #216: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:167: + ret = bind(fd, (struct sockaddr *) &nl_src, sizeof(nl_src)); WARNING: line length of 82 exceeds 80 columns #227: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:178: + if (!ASSERT_FALSE((ret < 0) || !NLMSG_OK((&msg.n), ret), "ueid response")) CHECK: Unnecessary parentheses around 'ret < 0' #227: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:178: + if (!ASSERT_FALSE((ret < 0) || !NLMSG_OK((&msg.n), ret), "ueid response")) CHECK: Unnecessary parentheses around '&msg.n' #227: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:178: + if (!ASSERT_FALSE((ret < 0) || !NLMSG_OK((&msg.n), ret), "ueid response")) WARNING: line length of 96 exceeds 80 columns #234: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:185: + if (!ASSERT_FALSE((err->error && err->error != -ENOENT), "ueid remove")) WARNING: line length of 84 exceeds 80 columns #261: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:212: + if (!ASSERT_OK(system("ip addr add 127.0.1.0/8 dev lo"), "add server node")) WARNING: line length of 89 exceeds 80 columns #264: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:215: + if (!ASSERT_OK(system("ip addr add 127.0.2.0/8 dev lo"), "server via risk path")) WARNING: line length of 85 exceeds 80 columns #319: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:270: + return !ASSERT_EQ(bind(fd, &localaddr, sizeof(localaddr)), 0, "client bind"); WARNING: line length of 84 exceeds 80 columns #368: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:319: + * 2. link-2 is not suitable for using SMC, because the mode of this link is kind of WARNING: line length of 89 exceeds 80 columns #370: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:321: + * 3. link-3 is also not suitable for using SMC, because the RDMA link is unavailable and WARNING: line length of 85 exceeds 80 columns #392: FILE: tools/testing/selftests/bpf/prog_tests/test_bpf_smc.c:343: + /* Mock the process of transparent replacement, since we will modify protocol WARNING: line length of 100 exceeds 80 columns #543: FILE: tools/testing/selftests/bpf/progs/bpf_smc.c:98: +int BPF_PROG(bpf_smc_set_tcp_option_cond, const struct tcp_sock *tp, struct inet_request_sock *ireq) WARNING: line length of 81 exceeds 80 columns #552: FILE: tools/testing/selftests/bpf/progs/bpf_smc.c:107: + return smc_check_ip(tp->inet_conn.icsk_inet.sk.__sk_common.skc_rcv_saddr, CHECK: No space is necessary after a cast #559: FILE: tools/testing/selftests/bpf/progs/bpf_smc.c:114: + .set_option = (void *) bpf_smc_set_tcp_option, CHECK: No space is necessary after a cast #560: FILE: tools/testing/selftests/bpf/progs/bpf_smc.c:115: + .set_option_cond = (void *) bpf_smc_set_tcp_option_cond, total: 0 errors, 12 warnings, 16 checks, 513 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 51ef2fe11f6d ("bpf/selftests: add selftest for bpf_smc_ops") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 16 checks, 513 lines checked