WARNING: static char array declaration should probably be static const char #26: FILE: tools/testing/selftests/bpf/prog_tests/bpf_iter.c:37: +static char test_data[] = "test_data"; WARNING: line length of 94 exceeds 80 columns #102: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:92: + ret = bpf_copy_from_user_task_str((char *)task_str1, sizeof(task_str1), ptr, task, 0); WARNING: line length of 81 exceeds 80 columns #108: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:98: + /* Read an invalid pointer and ensure we get error with pad zeros flag */ WARNING: line length of 108 exceeds 80 columns #110: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:100: + ret = bpf_copy_from_user_task_str((char *)task_str1, sizeof(task_str1), ptr, task, BPF_F_PAD_ZEROS); WARNING: line length of 84 exceeds 80 columns #119: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:109: + ret = bpf_copy_from_user_task_str((char *)task_str2, 10, user_ptr, task, 0); WARNING: line length of 83 exceeds 80 columns #126: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:116: + ret = bpf_copy_from_user_task_str((char *)task_str3, 9, user_ptr, task, 0); WARNING: line length of 84 exceeds 80 columns #133: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:123: + ret = bpf_copy_from_user_task_str((char *)task_str4, 20, user_ptr, task, 0); WARNING: line length of 117 exceeds 80 columns #134: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:124: + if (bpf_strncmp(task_str4, 10, "test_data\0") != 0 || ret != 10 || task_str4[sizeof(task_str4) - 1] != 'a') { WARNING: line length of 98 exceeds 80 columns #140: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:130: + ret = bpf_copy_from_user_task_str((char *)task_str4, 20, user_ptr, task, BPF_F_PAD_ZEROS); WARNING: line length of 118 exceeds 80 columns #141: FILE: tools/testing/selftests/bpf/progs/bpf_iter_tasks.c:131: + if (bpf_strncmp(task_str4, 10, "test_data\0") != 0 || ret != 10 || task_str4[sizeof(task_str4) - 1] != '\0') { WARNING: line length of 103 exceeds 80 columns #169: FILE: tools/testing/selftests/bpf/progs/read_vsyscall.c:19: +int bpf_copy_from_user_task_str(void *dst, u32, const void *, struct task_struct *, u64) __weak __ksym; WARNING: line length of 117 exceeds 80 columns #177: FILE: tools/testing/selftests/bpf/progs/read_vsyscall.c:51: + read_ret[9] = bpf_copy_from_user_task_str((char *)buf, sizeof(buf), user_ptr, bpf_get_current_task_btf(), 0); total: 0 errors, 12 warnings, 0 checks, 138 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit ee9f730508f5 ("selftests/bpf: Add tests for bpf_copy_from_user_task_str") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 12 warnings, 0 checks, 138 lines checked