WARNING: Non-standard signature: Submitted-by: #21: Submitted-by: Gur Stavi WARNING: line length of 89 exceeds 80 columns #546: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:11: +static int comm_msg_to_mgmt_sync(struct hinic3_hwdev *hwdev, u16 cmd, const void *buf_in, WARNING: line length of 85 exceeds 80 columns #618: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_intf.h:21: + /* Only used for interruption resource management, mark the request module */ WARNING: line length of 84 exceeds 80 columns #925: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.c:42: + struct hinic3_adev *hadev = container_of(dev, struct hinic3_adev, adev.dev); WARNING: line length of 81 exceeds 80 columns #931: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.c:48: + enum hinic3_service_type svc_type) WARNING: line length of 84 exceeds 80 columns #1000: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.c:117: + pci_adapter->hadev[svc_type] = hinic3_add_one_adev(hwdev, svc_type); WARNING: line length of 83 exceeds 80 columns #1041: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.c:158: + void (*event_handler)(struct auxiliary_device *adev, WARNING: line length of 86 exceeds 80 columns #1042: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.c:159: + struct hinic3_event_info *event)) WARNING: line length of 84 exceeds 80 columns #1162: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.c:279: +static int hinic3_func_init(struct pci_dev *pdev, struct hinic3_pcidev *pci_adapter) WARNING: line length of 83 exceeds 80 columns #1315: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.h:16: + void (*event_handler)(struct auxiliary_device *adev, WARNING: line length of 87 exceeds 80 columns #1316: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_lld.h:17: + struct hinic3_event_info *event)); WARNING: line length of 85 exceeds 80 columns #1367: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:42: + info->coalesce_timer_cfg = HINIC3_DEAULT_TXRX_MSIX_COALESC_TIMER_CFG; WARNING: line length of 82 exceeds 80 columns #1368: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:43: + info->resend_timer_cfg = HINIC3_DEAULT_TXRX_MSIX_RESEND_TIMER_CFG; WARNING: line length of 87 exceeds 80 columns #1453: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:128: + nic_dev->dma_rx_buff_size = HINIC3_RX_BUFF_NUM_PER_PAGE * nic_dev->rx_buff_len; WARNING: line length of 81 exceeds 80 columns #1496: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:171: + hinic3_del_mac(hwdev, netdev->dev_addr, 0, hinic3_global_func_id(hwdev)); WARNING: line length of 85 exceeds 80 columns #1552: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:227: +static void hinic3_link_status_change(struct net_device *netdev, bool link_status_up) WARNING: line length of 85 exceeds 80 columns #1576: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:251: +static void nic_event(struct auxiliary_device *adev, struct hinic3_event_info *event) WARNING: line length of 89 exceeds 80 columns #1595: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_main.c:270: +static int nic_probe(struct auxiliary_device *adev, const struct auxiliary_device_id *id) WARNING: line length of 81 exceeds 80 columns #1966: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:33: + netdev_err(netdev, "Failed to change port mtu to %d\n", new_mtu); WARNING: line length of 87 exceeds 80 columns #1968: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:35: + netdev_dbg(netdev, "Change mtu from %u to %d\n", netdev->mtu, new_mtu); WARNING: line length of 92 exceeds 80 columns #2037: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:21: +static int nic_feature_nego(struct hinic3_hwdev *hwdev, u8 opcode, u64 *s_feature, u16 size) WARNING: line length of 84 exceeds 80 columns #2132: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:116: +static int hinic3_check_mac_info(struct hinic3_hwdev *hwdev, u8 status, u16 vlan_id) WARNING: line length of 92 exceeds 80 columns #2145: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:129: +int hinic3_set_mac(struct hinic3_hwdev *hwdev, const u8 *mac_addr, u16 vlan_id, u16 func_id) WARNING: line length of 92 exceeds 80 columns #2187: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:171: +int hinic3_del_mac(struct hinic3_hwdev *hwdev, const u8 *mac_addr, u16 vlan_id, u16 func_id) WARNING: line length of 81 exceeds 80 columns #2217: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:201: +int hinic3_update_mac(struct hinic3_hwdev *hwdev, const u8 *old_mac, u8 *new_mac, WARNING: line length of 93 exceeds 80 columns #2314: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h:38: +int hinic3_set_mac(struct hinic3_hwdev *hwdev, const u8 *mac_addr, u16 vlan_id, u16 func_id); WARNING: line length of 93 exceeds 80 columns #2315: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h:39: +int hinic3_del_mac(struct hinic3_hwdev *hwdev, const u8 *mac_addr, u16 vlan_id, u16 func_id); WARNING: line length of 94 exceeds 80 columns #2316: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h:40: +int hinic3_update_mac(struct hinic3_hwdev *hwdev, const u8 *old_mac, u8 *new_mac, u16 vlan_id, WARNING: line length of 84 exceeds 80 columns #2618: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c:35: +void queue_pages_free(struct hinic3_hwdev *hwdev, struct hinic3_queue_pages *qpages) WARNING: line length of 95 exceeds 80 columns #2623: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c:40: +int queue_pages_alloc(struct hinic3_hwdev *hwdev, struct hinic3_queue_pages *qpages, u32 align) WARNING: line length of 89 exceeds 80 columns #2628: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.c:45: + qpages->pages = kcalloc(qpages->num_pages, sizeof(qpages->pages[0]), GFP_KERNEL); WARNING: line length of 96 exceeds 80 columns #2679: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.h:25: +int queue_pages_alloc(struct hinic3_hwdev *hwdev, struct hinic3_queue_pages *qpages, u32 align); WARNING: line length of 85 exceeds 80 columns #2680: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_queue_common.h:26: +void queue_pages_free(struct hinic3_hwdev *hwdev, struct hinic3_queue_pages *qpages); WARNING: line length of 90 exceeds 80 columns #2796: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:37: +static int rx_alloc_mapped_page(struct net_device *netdev, struct hinic3_rx_info *rx_info) WARNING: line length of 85 exceeds 80 columns #2855: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:96: + rxq->next_to_update = (u16)((rxq->next_to_update + 1) & rxq->q_mask); WARNING: line length of 96 exceeds 80 columns #2942: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:183: + dma_unmap_page(rxq->dev, rx_info->buf_dma_addr, rxq->dma_rx_buff_size, DMA_FROM_DEVICE); WARNING: line length of 94 exceeds 80 columns #3074: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:315: + skb_shinfo(skb)->gso_size = (u16)DIV_ROUND_UP((skb->len - skb_headlen(skb)), num_lro); WARNING: line length of 95 exceeds 80 columns #3075: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:316: + skb_shinfo(skb)->gso_type = (proto == htons(ETH_P_IP)) ? SKB_GSO_TCPV4 : SKB_GSO_TCPV6; WARNING: line length of 97 exceeds 80 columns #3342: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_tx.c:79: + dma_info[0].dma = dma_map_single(&pdev->dev, skb->data, skb_headlen(skb), DMA_TO_DEVICE); WARNING: line length of 98 exceeds 80 columns #3494: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_tx.c:231: + ((struct udphdr *)skb_transport_header(skb))->dest != VXLAN_OFFLOAD_PORT_LE) { WARNING: line length of 81 exceeds 80 columns #3709: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_tx.c:446: + wqe_combo->task = hinic3_wq_get_one_wqebb(&txq->sq->wq, &tmp_pi); WARNING: line length of 81 exceeds 80 columns #3800: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_tx.c:537: + if (unlikely(num_sge == 1 && skb->len > COMPACET_WQ_SKB_MAX_LEN)) WARNING: line length of 83 exceeds 80 columns #4108: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_wq.c:12: + struct hinic3_sq_bufdesc **second_part_wqebbs_addr, WARNING: line length of 81 exceeds 80 columns #4123: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_wq.c:27: + *second_part_wqebbs_addr = get_q_element(&wq->qpages, idx, NULL); WARNING: line length of 83 exceeds 80 columns #4203: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_wq.h:72: + struct hinic3_sq_bufdesc **second_part_wqebbs_addr, total: 0 errors, 45 warnings, 0 checks, 3864 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b7e06e26df74 ("hinic3: module initialization and tx/rx logic") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 45 warnings, 0 checks, 3864 lines checked