========== checkpatch - FAILED WARNING: line length of 95 exceeds 80 columns #143: FILE: arch/arm64/lib/insn.c:558: + pr_err("%s: unknown load-acquire/store-release encoding %d\n", __func__, type); WARNING: line length of 83 exceeds 80 columns #211: FILE: arch/arm64/net/bpf_jit_comp.c:644: +static int emit_atomic_load_store(const struct bpf_insn *insn, struct jit_ctx *ctx) WARNING: line length of 83 exceeds 80 columns #271: FILE: arch/arm64/net/bpf_jit_comp.c:704: + pr_err_once("unknown atomic load/store op code %02x\n", insn->imm); WARNING: line length of 82 exceeds 80 columns #328: FILE: include/uapi/linux/bpf.h:64: +#define BPF_LOAD_ACQ (BPF_ATOMIC_LOAD | BPF_ACQUIRE) /* load-acquire */ WARNING: line length of 83 exceeds 80 columns #329: FILE: include/uapi/linux/bpf.h:65: +#define BPF_STORE_REL (BPF_ATOMIC_STORE | BPF_RELEASE) /* store-release */ WARNING: labels should not be indented #362: FILE: kernel/bpf/core.c:2175: + STX_ATOMIC_H: WARNING: labels should not be indented #363: FILE: kernel/bpf/core.c:2176: + STX_ATOMIC_B: WARNING: macros should not use a trailing semicolon #373: FILE: kernel/bpf/core.c:2206: +#define LOAD_ACQUIRE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + DST = (SIZE)smp_load_acquire( \ + (SIZE *)(unsigned long)(SRC + insn->off)); \ + break; WARNING: memory barrier without comment #375: FILE: kernel/bpf/core.c:2208: + DST = (SIZE)smp_load_acquire( \ WARNING: line length of 89 exceeds 80 columns #376: FILE: kernel/bpf/core.c:2209: + (SIZE *)(unsigned long)(SRC + insn->off)); \ ERROR: spaces required around that ':' (ctx:VxE) #383: FILE: kernel/bpf/core.c:2216: + default: ^ CHECK: Macro argument 'SIZE' may be better as '(SIZE)' to avoid precedence issues #389: FILE: kernel/bpf/core.c:2222: +#define STORE_RELEASE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + smp_store_release( \ + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ + break; WARNING: macros should not use a trailing semicolon #389: FILE: kernel/bpf/core.c:2222: +#define STORE_RELEASE(SIZEOP, SIZE) \ + case BPF_##SIZEOP: \ + smp_store_release( \ + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ + break; WARNING: memory barrier without comment #391: FILE: kernel/bpf/core.c:2224: + smp_store_release( \ WARNING: line length of 97 exceeds 80 columns #392: FILE: kernel/bpf/core.c:2225: + (SIZE *)(unsigned long)(DST + insn->off), (SIZE)SRC); \ ERROR: spaces required around that ':' (ctx:VxE) #399: FILE: kernel/bpf/core.c:2232: + default: ^ WARNING: line length of 99 exceeds 80 columns #416: FILE: kernel/bpf/disasm.c:272: + verbose(cbs->private_data, "(%02x) %s%d = load_acquire((%s *)(r%d %+d))\n", WARNING: line length of 90 exceeds 80 columns #418: FILE: kernel/bpf/disasm.c:274: + BPF_SIZE(insn->code) == BPF_DW ? "r" : "w", insn->dst_reg, WARNING: line length of 99 exceeds 80 columns #423: FILE: kernel/bpf/disasm.c:279: + verbose(cbs->private_data, "(%02x) store_release((%s *)(r%d %+d), %s%d)\n", WARNING: line length of 91 exceeds 80 columns #427: FILE: kernel/bpf/disasm.c:283: + BPF_SIZE(insn->code) == BPF_DW ? "r" : "w", insn->src_reg); WARNING: line length of 82 exceeds 80 columns #538: FILE: tools/include/uapi/linux/bpf.h:64: +#define BPF_LOAD_ACQ (BPF_ATOMIC_LOAD | BPF_ACQUIRE) /* load-acquire */ WARNING: line length of 83 exceeds 80 columns #539: FILE: tools/include/uapi/linux/bpf.h:65: +#define BPF_STORE_REL (BPF_ATOMIC_STORE | BPF_RELEASE) /* store-release */ total: 2 errors, 19 warnings, 1 checks, 403 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5f31e5c9e34e ("bpf: Introduce load-acquire and store-release instructions") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.