========== checkpatch - FAILED WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #63: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #68: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:1: +#include CHECK: Prefer using the BIT macro #79: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:12: +#define NUM_QUEUE (1 << 20) ERROR: Macros with complex values should be enclosed in parentheses #156: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:89: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) WARNING: Prefer __aligned(8) over __attribute__((aligned(8))) #156: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:89: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) WARNING: line length of 81 exceeds 80 columns #162: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:95: +private(B) struct bpf_list_head fq_new_flows __contains(fq_flow_node, list_node); WARNING: line length of 81 exceeds 80 columns #165: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:98: +private(C) struct bpf_list_head fq_old_flows __contains(fq_flow_node, list_node); WARNING: line length of 88 exceeds 80 columns #190: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:123: +static bool fn_time_next_packet_less(struct bpf_rb_node *a, const struct bpf_rb_node *b) WARNING: line length of 88 exceeds 80 columns #248: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:181: +/* flow->age is used to denote the state of the flow (not-detached, detached, throttled) WARNING: line length of 84 exceeds 80 columns #267: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:200: + return (1 << sk->__sk_common.skc_state) & (TCPF_LISTEN | TCPF_NEW_SYN_RECV); CHECK: multiple assignments should be avoided #356: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:289: + time_to_send = q.ktime_cache = bpf_ktime_get_ns(); WARNING: line length of 90 exceeds 80 columns #388: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:321: + if ((s64)(jiffies - (flow_copy->age + q.flow_refill_delay)) > 0) { WARNING: line length of 87 exceeds 80 columns #393: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:326: + fq_flows_add_tail(&fq_new_flows, &fq_new_flows_lock, flow_copy, CHECK: multiple assignments should be avoided #404: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:337: + skbn->tstamp = skb->tstamp = time_to_send; WARNING: line length of 85 exceeds 80 columns #428: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:361: +static int fq_unset_throttled_flows(u32 index, struct unset_throttled_flows_ctx *ctx) WARNING: line length of 84 exceeds 80 columns #457: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:390: + fq_flows_add_tail(&fq_old_flows, &fq_old_flows_lock, flow, &q.old_flow_cnt); WARNING: line length of 92 exceeds 80 columns #528: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:461: + fq_flows_add_tail(&fq_old_flows, &fq_old_flows_lock, flow, &q.old_flow_cnt); WARNING: line length of 100 exceeds 80 columns #538: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:471: + fq_flows_add_tail(&fq_old_flows, &fq_old_flows_lock, flow, &q.old_flow_cnt); CHECK: multiple assignments should be avoided #637: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:570: + q.ktime_cache = cb_ctx.now = bpf_ktime_get_ns(); CHECK: spaces preferred around that '*' (ctx:VxV) #685: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:618: +#define FQ_GC_AGE (3*CONFIG_HZ) ^ WARNING: void function return statements are not generally useful #755: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c:688: + return; +} total: 1 errors, 15 warnings, 5 checks, 764 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8cae1d7367b5 ("selftests: Add a bpf fq qdisc to selftest") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.