========== checkpatch - FAILED WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #39: FILE: tools/testing/selftests/bpf/prog_tests/bpf_qdisc.c:1: +#include WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #46: FILE: tools/testing/selftests/bpf/prog_tests/bpf_qdisc.c:8: +#ifndef ENOTSUPP WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP #47: FILE: tools/testing/selftests/bpf/prog_tests/bpf_qdisc.c:9: +#define ENOTSUPP 524 WARNING: void function return statements are not generally useful #172: FILE: tools/testing/selftests/bpf/prog_tests/bpf_qdisc.c:134: + return; +} WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #206: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_common.h:1: +#ifndef _BPF_QDISC_COMMON_H WARNING: line length of 83 exceeds 80 columns #218: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_common.h:13: +void bpf_qdisc_skb_drop(struct sk_buff *p, struct bpf_sk_buff_ptr *to_free) __ksym; WARNING: line length of 85 exceeds 80 columns #219: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_common.h:14: +void bpf_qdisc_watchdog_schedule(struct Qdisc *sch, u64 expire, u64 delta_ns) __ksym; WARNING: line length of 82 exceeds 80 columns #220: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_common.h:15: +void bpf_qdisc_bstats_update(struct Qdisc *sch, const struct sk_buff *skb) __ksym; WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #239: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fifo.c:1: +#include ERROR: Macros with complex values should be enclosed in parentheses #250: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fifo.c:12: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) WARNING: Prefer __aligned(8) over __attribute__((aligned(8))) #250: FILE: tools/testing/selftests/bpf/progs/bpf_qdisc_fifo.c:12: +#define private(name) SEC(".data." #name) __hidden __attribute__((aligned(8))) total: 1 errors, 11 warnings, 0 checks, 312 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7caba8d393e2 ("selftests: Add a basic fifo qdisc test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.