WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #92: new file mode 100644 CHECK: Comparison to NULL could be written "strp" #150: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:54: + if (!ASSERT_TRUE(strp != NULL, "sockmap_strp_init")) CHECK: Comparison to NULL could be written "snd" #165: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:69: + if (!ASSERT_TRUE(snd != NULL, "malloc(multi block)") CHECK: Logical continuations should be on the previous line #166: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:70: + if (!ASSERT_TRUE(snd != NULL, "malloc(multi block)") + || !ASSERT_TRUE(rcv != NULL, "malloc(multi block)")) CHECK: Comparison to NULL could be written "rcv" #166: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:70: + || !ASSERT_TRUE(rcv != NULL, "malloc(multi block)")) CHECK: Logical continuations should be on the previous line #315: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:219: + if (!ASSERT_EQ(recvd, pkt_size, "recv_timeout(p)") + || !ASSERT_OK(memcmp(packet, rcv, pkt_size), CHECK: Logical continuations should be on the previous line #327: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:231: + if (!ASSERT_OK(err, "ioctl(FIONREAD) error") + || ASSERT_EQ(avail, pkt_size, "ioctl(FIONREAD)")) CHECK: Logical continuations should be on the previous line #333: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:237: + if (!ASSERT_EQ(recvd, pkt_size, "second recv_timeout(p)") + || ASSERT_OK(memcmp(packet, rcv, pkt_size), CHECK: Logical continuations should be on the previous line #392: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:296: + if (!ASSERT_EQ(recvd, STRP_PACKET_FULL_LEN, "recv_timeout(p1)") + || !ASSERT_OK(memcmp(packet, rcv, STRP_PACKET_FULL_LEN), CHECK: spaces preferred around that '/' (ctx:VxV) #402: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:306: + off = STRP_PACKET_FULL_LEN/2; ^ CHECK: Logical continuations should be on the previous line #409: FILE: tools/testing/selftests/bpf/prog_tests/sockmap_strp.c:313: + if (!ASSERT_EQ(recvd, STRP_PACKET_FULL_LEN, "partial recv_timeout(p1)") + || !ASSERT_OK(memcmp(packet, rcv, STRP_PACKET_FULL_LEN), CHECK: Please don't use multiple blank lines #459: FILE: tools/testing/selftests/bpf/progs/test_sockmap_strp.c:13: + + CHECK: Please don't use multiple blank lines #466: FILE: tools/testing/selftests/bpf/progs/test_sockmap_strp.c:20: + + CHECK: Please use a blank line after function/struct/union/enum declarations #497: FILE: tools/testing/selftests/bpf/progs/test_sockmap_strp.c:51: +} +char _license[] SEC("license") = "GPL"; total: 0 errors, 1 warnings, 13 checks, 460 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit aabdcc012eff ("selftests/bpf: add strparser test for bpf") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 13 checks, 460 lines checked