WARNING: line length of 83 exceeds 80 columns #91: FILE: include/net/smc.h:130: + * We can control whether to respond SMC options by returning varios value. WARNING: line length of 90 exceeds 80 columns #94: FILE: include/net/smc.h:133: + int (*set_option_cond)(const struct tcp_sock *tp, struct inet_request_sock *ireq); CHECK: Macro argument 'func' may be better as '(func)' to avoid precedence issues #98: FILE: include/net/smc.h:137: +#define smc_call_retops(init_val, sk, func, ...) ({ \ + typeof(init_val) __ret = (init_val); \ + struct smc_ops *ops; \ + rcu_read_lock(); \ + ops = READ_ONCE(sock_net(sk)->smc.ops); \ + if (ops && ops->func) \ + __ret = ops->func(__VA_ARGS__); \ + rcu_read_unlock(); \ + __ret; \ +}) WARNING: line length of 85 exceeds 80 columns #138: FILE: net/ipv4/tcp_output.c:770: + tp->syn_smc = smc_call_retops(1, &tp->inet_conn.icsk_inet.sk, WARNING: line length of 88 exceeds 80 columns #141: FILE: net/ipv4/tcp_output.c:773: + if (tp->syn_smc && *remaining >= TCPOLEN_EXP_SMC_BASE_ALIGNED) { WARNING: line length of 86 exceeds 80 columns #158: FILE: net/ipv4/tcp_output.c:790: + ireq->smc_ok = smc_call_retops(1, &tp->inet_conn.icsk_inet.sk, WARNING: line length of 82 exceeds 80 columns #159: FILE: net/ipv4/tcp_output.c:791: + set_option_cond, tp, ireq); WARNING: line length of 89 exceeds 80 columns #161: FILE: net/ipv4/tcp_output.c:793: + if (ireq->smc_ok && *remaining >= TCPOLEN_EXP_SMC_BASE_ALIGNED) { WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #196: new file mode 100644 WARNING: line length of 85 exceeds 80 columns #283: FILE: net/smc/smc_ops.h:26: +static inline struct smc_ops *smc_ops_find_by_name(const char *name) { return NULL; } WARNING: struct ctl_table should normally be const #342: FILE: net/smc/smc_sysctl.c:73: + struct ctl_table tbl = { total: 0 errors, 10 warnings, 1 checks, 345 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 27ae852a1e66 ("net/smc: Introduce generic hook smc_ops") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 10 warnings, 1 checks, 345 lines checked