WARNING: line length of 98 exceeds 80 columns #39: FILE: tools/testing/selftests/bpf/bpf_experimental.h:593: +extern int bpf_iter_task_file_new(struct bpf_iter_task_file *it, struct task_struct *task) __ksym; CHECK: extern prototypes should be avoided in .h files #39: FILE: tools/testing/selftests/bpf/bpf_experimental.h:593: +extern int bpf_iter_task_file_new(struct bpf_iter_task_file *it, struct task_struct *task) __ksym; CHECK: extern prototypes should be avoided in .h files #42: FILE: tools/testing/selftests/bpf/bpf_experimental.h:596: +extern void bpf_iter_task_file_destroy(struct bpf_iter_task_file *it) __ksym; WARNING: line length of 96 exceeds 80 columns #127: FILE: tools/testing/selftests/bpf/prog_tests/iters.c:349: + child_pid = clone(task_file_test_process, stack + stack_size, CLONE_VM | SIGCHLD, NULL); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #161: new file mode 100644 WARNING: externs should be avoided in .c files #179: FILE: tools/testing/selftests/bpf/progs/iters_task_file.c:14: +extern const void pipefifo_fops __ksym; WARNING: externs should be avoided in .c files #180: FILE: tools/testing/selftests/bpf/progs/iters_task_file.c:15: +extern const void socket_file_ops __ksym; CHECK: Comparison to NULL could be written "!item" #198: FILE: tools/testing/selftests/bpf/progs/iters_task_file.c:33: + if (item == NULL) { CHECK: Comparison to NULL could be written "!item" #214: FILE: tools/testing/selftests/bpf/progs/iters_task_file.c:49: + if (item == NULL) { CHECK: Comparison to NULL could be written "!item" #230: FILE: tools/testing/selftests/bpf/progs/iters_task_file.c:65: + if (item == NULL) { CHECK: Comparison to NULL could be written "item" #246: FILE: tools/testing/selftests/bpf/progs/iters_task_file.c:81: + if (item != NULL) total: 0 errors, 5 warnings, 6 checks, 295 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit e34562efc3bc ("selftests/bpf: Add tests for open-coded style process file iterator") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 5 warnings, 6 checks, 295 lines checked