WARNING: line length of 84 exceeds 80 columns #32: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:91: +extern int bpf_set_dentry_xattr_locked(struct dentry *dentry, const char *name__str, CHECK: extern prototypes should be avoided in .h files #32: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:91: +extern int bpf_set_dentry_xattr_locked(struct dentry *dentry, const char *name__str, WARNING: line length of 98 exceeds 80 columns #33: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:92: + const struct bpf_dynptr *value_p, int flags) __ksym __weak; CHECK: extern prototypes should be avoided in .h files #34: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:93: +extern int bpf_remove_dentry_xattr_locked(struct dentry *dentry, CHECK: extern prototypes should be avoided in .h files #37: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:96: +extern int bpf_set_dentry_xattr(struct dentry *dentry, const char *name__str, WARNING: line length of 91 exceeds 80 columns #38: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:97: + const struct bpf_dynptr *value_p, int flags) __ksym __weak; WARNING: line length of 95 exceeds 80 columns #39: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:98: +extern int bpf_remove_dentry_xattr(struct dentry *dentry, const char *name__str) __ksym __weak; CHECK: extern prototypes should be avoided in .h files #39: FILE: tools/testing/selftests/bpf/bpf_kfuncs.h:98: +extern int bpf_remove_dentry_xattr(struct dentry *dentry, const char *name__str) __ksym __weak; WARNING: line length of 88 exceeds 80 columns #66: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:84: + err = getxattr(testfile, skel->rodata->xattr_foo, value_out, sizeof(value_out)); WARNING: line length of 92 exceeds 80 columns #68: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:86: + ASSERT_EQ(strncmp(value_out, value_foo, sizeof(value_foo)), 0, "strncmp value_foo"); WARNING: line length of 99 exceeds 80 columns #73: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:91: + ASSERT_OK(setxattr(testfile, skel->rodata->xattr_foo, value_foo, strlen(value_foo) + 1, 0), WARNING: line length of 88 exceeds 80 columns #82: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:100: + err = getxattr(testfile, skel->rodata->xattr_bar, value_out, sizeof(value_out)); WARNING: line length of 94 exceeds 80 columns #84: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:102: + ASSERT_EQ(strncmp(value_out, skel->data->value_bar, sizeof(skel->data->value_bar)), 0, WARNING: line length of 88 exceeds 80 columns #93: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:111: + err = getxattr(testfile, skel->rodata->xattr_bar, value_out, sizeof(value_out)); WARNING: line length of 95 exceeds 80 columns #114: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:132: + err = setxattr(testfile, skel->rodata->xattr_foo, value_foo, strlen(value_foo) + 1, 0); WARNING: line length of 93 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:163: + ASSERT_TRUE(skel->bss->set_security_bpf_bar_success, "set_security_bpf_bar_success"); WARNING: line length of 99 exceeds 80 columns #146: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:164: + ASSERT_TRUE(skel->bss->remove_security_bpf_bar_success, "remove_security_bpf_bar_success"); WARNING: line length of 87 exceeds 80 columns #147: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:165: + ASSERT_TRUE(skel->bss->set_security_selinux_fail, "set_security_selinux_fail"); WARNING: line length of 93 exceeds 80 columns #148: FILE: tools/testing/selftests/bpf/prog_tests/fs_kfuncs.c:166: + ASSERT_TRUE(skel->bss->remove_security_selinux_fail, "remove_security_selinux_fail"); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #193: new file mode 100644 WARNING: const array should probably be static const #211: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:14: +const char xattr_foo[] = "security.bpf.foo"; WARNING: const array should probably be static const #212: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:15: +const char xattr_bar[] = "security.bpf.bar"; WARNING: const array should probably be static const #213: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:16: +const char xattr_linux[] = "security.selinux"; WARNING: line length of 81 exceeds 80 columns #254: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:57: + bpf_dynptr_from_mem(value_bar, sizeof(value_bar), 0, &value_ptr); WARNING: line length of 81 exceeds 80 columns #306: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:109: + bpf_dynptr_from_mem(value_bar, sizeof(value_bar), 0, &value_ptr); WARNING: line length of 84 exceeds 80 columns #308: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:111: + ret = bpf_set_dentry_xattr_locked(dentry, xattr_bar, &value_ptr, 0); WARNING: line length of 86 exceeds 80 columns #311: FILE: tools/testing/selftests/bpf/progs/test_set_remove_xattr.c:114: + ret = bpf_set_dentry_xattr_locked(dentry, xattr_linux, &value_ptr, 0); total: 0 errors, 23 warnings, 4 checks, 286 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 8fd6cd67a141 ("selftests/bpf: Test kfuncs that set and remove xattr from BPF programs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 23 warnings, 4 checks, 286 lines checked