========== checkpatch - FAILED CHECK: Macro argument 'in_dev' may be better as '(in_dev)' to avoid precedence issues #33: FILE: include/linux/igmp.h:145: +#define for_each_pmc_rtnl(in_dev, pmc) \ + for (pmc = rtnl_dereference(in_dev->mc_list); \ + pmc != NULL; \ + pmc = rtnl_dereference(pmc->next_rcu)) CHECK: Comparison to NULL could be written "pmc" #35: FILE: include/linux/igmp.h:147: + pmc != NULL; \ ERROR: space required before the open parenthesis '(' #64: FILE: net/ipv4/devinet.c:1859: + switch(fillargs->type) { CHECK: Blank lines aren't necessary after an open brace '{' #131: FILE: net/ipv4/devinet.c:1979: +{ + CHECK: Blank lines aren't necessary after an open brace '{' #139: FILE: net/ipv4/devinet.c:1987: +{ + total: 1 errors, 0 warnings, 4 checks, 161 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 240a0e3b3fb5 ("netlink: support dumping IPv4 multicast addresses") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.