WARNING: please write a help paragraph that fully describes the config symbol #28: FILE: drivers/net/mdio/Kconfig:188: +config MDIO_REALTEK_RTL + tristate "Realtek RTL9300 MDIO interface support" + depends on MACH_REALTEK_RTL || COMPILE_TEST + help + This driver supports the MDIO interface found in the Realtek + RTL9300 family of Ethernet switches with integrated SoC. + WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 WARNING: line length of 81 exceeds 80 columns #105: FILE: drivers/net/mdio/mdio-realtek-rtl.c:50: + return regmap_read_poll_timeout(regmap, reg_base + SMI_ACCESS_PHY_CTRL_1, WARNING: line length of 83 exceeds 80 columns #121: FILE: drivers/net/mdio/mdio-realtek-rtl.c:66: + err = regmap_write(regmap, reg_base + SMI_ACCESS_PHY_CTRL_2, phy_id << 16); WARNING: line length of 83 exceeds 80 columns #126: FILE: drivers/net/mdio/mdio-realtek-rtl.c:71: + regnum << 20 | 0x1f << 15 | 0xfff << 3 | PHY_CTRL_CMD); WARNING: line length of 89 exceeds 80 columns #141: FILE: drivers/net/mdio/mdio-realtek-rtl.c:86: +static int realtek_mdio_write_c22(struct mii_bus *bus, int phy_id, int regnum, u16 value) WARNING: line length of 82 exceeds 80 columns #153: FILE: drivers/net/mdio/mdio-realtek-rtl.c:98: + err = regmap_write(regmap, reg_base + SMI_ACCESS_PHY_CTRL_0, BIT(phy_id)); WARNING: line length of 82 exceeds 80 columns #157: FILE: drivers/net/mdio/mdio-realtek-rtl.c:102: + err = regmap_write(regmap, reg_base + SMI_ACCESS_PHY_CTRL_2, value << 16); WARNING: line length of 99 exceeds 80 columns #162: FILE: drivers/net/mdio/mdio-realtek-rtl.c:107: + regnum << 20 | 0x1f << 15 | 0xfff << 3 | PHY_CTRL_RWOP | PHY_CTRL_CMD); WARNING: line length of 91 exceeds 80 columns #177: FILE: drivers/net/mdio/mdio-realtek-rtl.c:122: +static int realtek_mdio_read_c45(struct mii_bus *bus, int phy_id, int dev_addr, int regnum) WARNING: line length of 83 exceeds 80 columns #189: FILE: drivers/net/mdio/mdio-realtek-rtl.c:134: + err = regmap_write(regmap, reg_base + SMI_ACCESS_PHY_CTRL_2, phy_id << 16); WARNING: line length of 82 exceeds 80 columns #227: FILE: drivers/net/mdio/mdio-realtek-rtl.c:172: + err = regmap_write(regmap, reg_base + SMI_ACCESS_PHY_CTRL_0, BIT(phy_id)); WARNING: line length of 82 exceeds 80 columns #231: FILE: drivers/net/mdio/mdio-realtek-rtl.c:176: + err = regmap_write(regmap, reg_base + SMI_ACCESS_PHY_CTRL_2, value << 16); WARNING: line length of 91 exceeds 80 columns #343: FILE: drivers/net/mdio/mdio-realtek-rtl.c:288: + return dev_err_probe(dev, -EINVAL, "illegal port number %d\n", pn); WARNING: line length of 96 exceeds 80 columns #345: FILE: drivers/net/mdio/mdio-realtek-rtl.c:290: + err = fwnode_property_read_u32_array(child, "realtek,smi-address", smi_addr, 2); WARNING: line length of 89 exceeds 80 columns #352: FILE: drivers/net/mdio/mdio-realtek-rtl.c:297: + return dev_err_probe(dev, -EINVAL, "illegal smi bus number %d\n", WARNING: line length of 97 exceeds 80 columns #356: FILE: drivers/net/mdio/mdio-realtek-rtl.c:301: + return dev_err_probe(dev, -EINVAL, "illegal smi addr %d\n", smi_addr[1]); WARNING: line length of 85 exceeds 80 columns #358: FILE: drivers/net/mdio/mdio-realtek-rtl.c:303: + if (fwnode_device_is_compatible(child, "ethernet-phy-ieee802.3-c45")) WARNING: line length of 93 exceeds 80 columns #367: FILE: drivers/net/mdio/mdio-realtek-rtl.c:312: + return dev_err_probe(dev, err, "failed to initialise MDIO bus controller\n"); total: 0 errors, 19 warnings, 0 checks, 361 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 554bc99669f1 ("net: mdio: Add RTL9300 MDIO driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 19 warnings, 0 checks, 361 lines checked