WARNING: Non-standard signature: Submitted-by: #17: Submitted-by: Gur Stavi WARNING: line length of 85 exceeds 80 columns #99: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_cfg.c:37: + const struct cfg_cmd_dev_cap *dev_cap, enum func_type type) WARNING: line length of 91 exceeds 80 columns #316: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:71: +static int hinic3_comm_features_nego(struct hinic3_hwdev *hwdev, u8 opcode, u64 *s_feature, WARNING: line length of 82 exceeds 80 columns #344: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:99: +int hinic3_get_comm_features(struct hinic3_hwdev *hwdev, u64 *s_feature, u16 size) WARNING: line length of 82 exceeds 80 columns #350: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:105: +int hinic3_set_comm_features(struct hinic3_hwdev *hwdev, u64 *s_feature, u16 size) WARNING: line length of 85 exceeds 80 columns #356: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:111: +int hinic3_get_global_attr(struct hinic3_hwdev *hwdev, struct comm_global_attr *attr) WARNING: line length of 86 exceeds 80 columns #377: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:132: +int hinic3_set_func_svc_used_state(struct hinic3_hwdev *hwdev, u16 svc_type, u8 state) WARNING: line length of 90 exceeds 80 columns #402: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:157: +int hinic3_set_dma_attr_tbl(struct hinic3_hwdev *hwdev, u8 entry_idx, u8 st, u8 at, u8 ph, WARNING: line length of 99 exceeds 80 columns #418: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:173: + err = comm_msg_to_mgmt_sync(hwdev, COMM_MGMT_CMD_SET_DMA_ATTR, &dma_attr, sizeof(dma_attr), WARNING: line length of 84 exceeds 80 columns #429: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:184: +int hinic3_set_wq_page_size(struct hinic3_hwdev *hwdev, u16 func_idx, u32 page_size) WARNING: line length of 95 exceeds 80 columns #601: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.c:356: +int hinic3_set_root_ctxt(struct hinic3_hwdev *hwdev, u32 rq_depth, u32 sq_depth, int rx_buf_sz) WARNING: line length of 83 exceeds 80 columns #675: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h:28: +int hinic3_get_comm_features(struct hinic3_hwdev *hwdev, u64 *s_feature, u16 size); WARNING: line length of 83 exceeds 80 columns #676: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h:29: +int hinic3_set_comm_features(struct hinic3_hwdev *hwdev, u64 *s_feature, u16 size); WARNING: line length of 86 exceeds 80 columns #677: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h:30: +int hinic3_get_global_attr(struct hinic3_hwdev *hwdev, struct comm_global_attr *attr); WARNING: line length of 87 exceeds 80 columns #678: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h:31: +int hinic3_set_func_svc_used_state(struct hinic3_hwdev *hwdev, u16 svc_type, u8 state); WARNING: line length of 90 exceeds 80 columns #679: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h:32: +int hinic3_set_dma_attr_tbl(struct hinic3_hwdev *hwdev, u8 entry_idx, u8 st, u8 at, u8 ph, WARNING: line length of 85 exceeds 80 columns #682: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hw_comm.h:35: +int hinic3_set_wq_page_size(struct hinic3_hwdev *hwdev, u16 func_idx, u32 page_size); WARNING: line length of 91 exceeds 80 columns #1120: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c:271: + return hinic3_set_dma_attr_tbl(hwdev, PCIE_MSIX_ATTR_ENTRY, HINIC3_PCIE_ST_DISABLE, WARNING: line length of 86 exceeds 80 columns #1121: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c:272: + HINIC3_PCIE_AT_DISABLE, HINIC3_PCIE_PH_DISABLE, WARNING: line length of 83 exceeds 80 columns #1122: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c:273: + HINIC3_PCIE_SNOOP, HINIC3_PCIE_TPH_DISABLE); WARNING: line length of 96 exceeds 80 columns #1335: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c:485: + hwdev->workq = alloc_workqueue(HINIC3_HWDEV_WQ_NAME, WQ_MEM_RECLAIM, HINIC3_WQ_MAX_REQ); WARNING: line length of 87 exceeds 80 columns #1359: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwdev.c:509: + err = hinic3_set_comm_features(hwdev, hwdev->features, COMM_MAX_FEATURE_QWORD); WARNING: line length of 90 exceeds 80 columns #1533: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c:134: +static enum hinic3_doorbell_ctrl hinic3_get_doorbell_ctrl_status(struct hinic3_hwif *hwif) WARNING: line length of 90 exceeds 80 columns #1540: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c:141: +static enum hinic3_outbound_ctrl hinic3_get_outbound_ctrl_status(struct hinic3_hwif *hwif) WARNING: line length of 84 exceeds 80 columns #1582: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c:183: + hwif->cfg_regs_base = (u8 __iomem *)cfg_reg_base + HINIC3_VF_CFG_REG_OFFSET; WARNING: line length of 85 exceeds 80 columns #1681: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_hwif.c:391: + dev_err(hwdev->dev, "Chip status is not ready, attr1:0x%x\n", attr1); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1789: new file mode 100644 WARNING: line length of 82 exceeds 80 columns #1808: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.c:15: +void hinic3_mgmt_msg_aeqe_handler(struct hinic3_hwdev *hwdev, u8 *header, u8 size) WARNING: line length of 83 exceeds 80 columns #1823: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_mgmt.h:12: +void hinic3_mgmt_msg_aeqe_handler(struct hinic3_hwdev *hwdev, u8 *header, u8 size); WARNING: line length of 82 exceeds 80 columns #2062: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:118: + struct hinic3_dyna_txrxq_params *q_params) WARNING: line length of 82 exceeds 80 columns #2122: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:178: + struct hinic3_dyna_txrxq_params *q_params) WARNING: line length of 82 exceeds 80 columns #2195: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:251: + struct hinic3_dyna_qp_params *qp_params, WARNING: line length of 87 exceeds 80 columns #2196: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:252: + struct hinic3_dyna_txrxq_params *trxq_params) WARNING: line length of 82 exceeds 80 columns #2222: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:278: + struct hinic3_dyna_qp_params *qp_params, WARNING: line length of 87 exceeds 80 columns #2223: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_netdev_ops.c:279: + struct hinic3_dyna_txrxq_params *trxq_params) WARNING: line length of 88 exceeds 80 columns #2447: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:107: + cfg_bitmap = BIT(FUNC_CFG_INIT) | BIT(FUNC_CFG_MTU) | BIT(FUNC_CFG_RX_BUF_SIZE); WARNING: line length of 84 exceeds 80 columns #2448: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:108: + return hinic3_set_function_table(nic_dev->hwdev, cfg_bitmap, &func_tbl_cfg); WARNING: line length of 91 exceeds 80 columns #2532: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:341: + &dcb_state, sizeof(dcb_state), &dcb_state, &out_size); WARNING: line length of 82 exceeds 80 columns #2554: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:363: + sizeof(get_link), &get_link, &out_size, 0); WARNING: line length of 81 exceeds 80 columns #2566: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.c:375: +int hinic3_set_vport_enable(struct hinic3_hwdev *hwdev, u16 func_id, bool enable) WARNING: line length of 81 exceeds 80 columns #2636: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h:68: +int hinic3_set_ci_table(struct hinic3_hwdev *hwdev, struct hinic3_sq_attr *attr); WARNING: line length of 82 exceeds 80 columns #2642: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_cfg.h:74: +int hinic3_set_vport_enable(struct hinic3_hwdev *hwdev, u16 func_id, bool enable); WARNING: line length of 82 exceeds 80 columns #2961: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:297: + CI_TABLE_SIZE(nic_io->max_qps), WARNING: line length of 85 exceeds 80 columns #2962: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:298: + &nic_io->ci_dma_base, GFP_KERNEL); WARNING: line length of 83 exceeds 80 columns #2985: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:321: +static int hinic3_create_sq(struct hinic3_hwdev *hwdev, struct hinic3_io_queue *sq, WARNING: line length of 83 exceeds 80 columns #3007: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:343: +static int hinic3_create_rq(struct hinic3_hwdev *hwdev, struct hinic3_io_queue *rq, WARNING: line length of 87 exceeds 80 columns #3016: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:352: + (u16)BIT(HINIC3_RQ_WQEBB_SHIFT + HINIC3_NORMAL_RQ_WQE)); WARNING: line length of 89 exceeds 80 columns #3088: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:424: + err = create_qp(hwdev, &sqs[q_id], &rqs[q_id], q_id, qp_params->sq_depth, WARNING: line length of 89 exceeds 80 columns #3089: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:425: + qp_params->rq_depth, qps_msix_arry[q_id].msix_entry_idx); WARNING: line length of 94 exceeds 80 columns #3091: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:427: + dev_err(hwdev->dev, "Failed to allocate qp %u, err: %d\n", q_id, err); WARNING: line length of 81 exceeds 80 columns #3160: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:496: +static void hinic3_qp_prepare_cmdq_header(struct hinic3_qp_ctxt_hdr *qp_ctxt_hdr, WARNING: line length of 88 exceeds 80 columns #3245: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:581: + u32 *wq_page_pfn_hi, u32 *wq_page_pfn_lo, WARNING: line length of 90 exceeds 80 columns #3246: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:582: + u32 *wq_block_pfn_hi, u32 *wq_block_pfn_lo) WARNING: line length of 94 exceeds 80 columns #3261: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:597: +static void hinic3_rq_prepare_ctxt(struct hinic3_io_queue *rq, struct hinic3_rq_ctxt *rq_ctxt) WARNING: line length of 91 exceeds 80 columns #3267: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:603: + ci_start = (u16)((u32)(rq->wq.cons_idx & rq->wq.idx_mask) << HINIC3_NORMAL_RQ_WQE); WARNING: line length of 91 exceeds 80 columns #3268: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_nic_io.c:604: + pi_start = (u16)((u32)(rq->wq.prod_idx & rq->wq.idx_mask) << HINIC3_NORMAL_RQ_WQE); WARNING: line length of 83 exceeds 80 columns #3728: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rss.c:122: + nic_dev->rss_indir = kzalloc(sizeof(u32) * NIC_RSS_INDIR_SIZE, GFP_KERNEL); WARNING: line length of 85 exceeds 80 columns #3796: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rss.c:190: + err = l2nic_msg_to_mgmt_sync(hwdev, HINIC3_NIC_CMD_SET_RSS_CTX_TBL_INTO_FUNC, WARNING: line length of 82 exceeds 80 columns #4066: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:114: + cqe_dma = rxq->cqe_start_paddr + i * sizeof(struct hinic3_rq_cqe); WARNING: line length of 94 exceeds 80 columns #4145: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:474: + rqres->cqe_start_vaddr = dma_alloc_coherent(&nic_dev->pdev->dev, cqe_mem_size, WARNING: line length of 84 exceeds 80 columns #4146: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:475: + &rqres->cqe_start_paddr, WARNING: line length of 84 exceeds 80 columns #4153: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:482: + pkt_idx = hinic3_rx_alloc_buffers(netdev, rq_depth, rqres->rx_info); WARNING: line length of 86 exceeds 80 columns #4159: FILE: drivers/net/ethernet/huawei/hinic3/hinic3_rx.c:488: + netdev_err(netdev, "Failed to alloc rxq%d rx buffers\n", idx); total: 0 errors, 63 warnings, 0 checks, 4198 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 498a0edcc5b8 ("net: hinic3: sw and hw initialization code") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 63 warnings, 0 checks, 4198 lines checked