WARNING: line length of 92 exceeds 80 columns #55: FILE: arch/x86/kernel/uprobes.c:428: +static int tramp_mremap(const struct vm_special_mapping *sm, struct vm_area_struct *new_vma) WARNING: line length of 89 exceeds 80 columns #72: FILE: arch/x86/kernel/uprobes.c:445: + err = copy_from_user(&bp_vaddr, (void __user *)regs->sp + 3*8, sizeof(bp_vaddr)); CHECK: spaces preferred around that '*' (ctx:VxV) #72: FILE: arch/x86/kernel/uprobes.c:445: + err = copy_from_user(&bp_vaddr, (void __user *)regs->sp + 3*8, sizeof(bp_vaddr)); ^ CHECK: No space is necessary after a cast #80: FILE: arch/x86/kernel/uprobes.c:453: + if (!vma || vma->vm_private_data != (void *) &tramp_mapping) { CHECK: Lines should not end with a '(' #89: FILE: arch/x86/kernel/uprobes.c:462: +asm ( WARNING: externs should be avoided in .c files #108: FILE: arch/x86/kernel/uprobes.c:481: +extern __visible u8 uprobe_trampoline_entry[]; WARNING: externs should be avoided in .c files #109: FILE: arch/x86/kernel/uprobes.c:482: +extern __visible u8 uprobe_trampoline_end[]; CHECK: No space is necessary after a cast #128: FILE: arch/x86/kernel/uprobes.c:501: + tramp_mapping.pages = (struct page **) &pages; CHECK: extern prototypes should be avoided in .h files #159: FILE: include/linux/uprobes.h:235: +extern void handle_syscall_uprobe(struct pt_regs *regs, unsigned long bp_vaddr); WARNING: use of RCU tasks trace is incorrect outside BPF or core RCU code #176: FILE: kernel/events/uprobes.c:2737: + rcu_read_lock_trace(); WARNING: use of RCU tasks trace is incorrect outside BPF or core RCU code #190: FILE: kernel/events/uprobes.c:2751: + rcu_read_unlock_trace(); total: 0 errors, 6 warnings, 5 checks, 140 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 9e09006880d9 ("uprobes/x86: Add uprobe syscall to speed up uprobe") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 6 warnings, 5 checks, 140 lines checked