WARNING: Possible repeated word: 'for' #6: Adding support to add special mapping for for user space trampoline CHECK: extern prototypes should be avoided in .h files #63: FILE: include/linux/uprobes.h:231: +extern struct uprobe_trampoline *uprobe_trampoline_get(unsigned long vaddr); CHECK: extern prototypes should be avoided in .h files #64: FILE: include/linux/uprobes.h:232: +extern void uprobe_trampoline_put(struct uprobe_trampoline *area); CHECK: extern prototypes should be avoided in .h files #65: FILE: include/linux/uprobes.h:233: +extern bool arch_uprobe_is_callable(unsigned long vtramp, unsigned long vaddr); CHECK: extern prototypes should be avoided in .h files #66: FILE: include/linux/uprobes.h:234: +extern const struct vm_special_mapping *arch_uprobe_trampoline_mapping(void); WARNING: Missing a blank line after declarations #92: FILE: kernel/events/uprobes.c:632: + struct vm_area_struct *vma, *prev; + VMA_ITERATOR(vmi, mm, 0); WARNING: line length of 86 exceeds 80 columns #100: FILE: kernel/events/uprobes.c:640: + if (arch_uprobe_is_callable(vma->vm_start - PAGE_SIZE, vaddr)) WARNING: line length of 88 exceeds 80 columns #134: FILE: kernel/events/uprobes.c:674: + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, CHECK: Alignment should match open parenthesis #134: FILE: kernel/events/uprobes.c:674: + vma = _install_special_mapping(mm, tramp->vaddr, PAGE_SIZE, + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, CHECK: spaces preferred around that '|' (ctx:VxV) #134: FILE: kernel/events/uprobes.c:674: + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, ^ CHECK: spaces preferred around that '|' (ctx:VxV) #134: FILE: kernel/events/uprobes.c:674: + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, ^ CHECK: spaces preferred around that '|' (ctx:VxV) #134: FILE: kernel/events/uprobes.c:674: + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, ^ CHECK: spaces preferred around that '|' (ctx:VxV) #134: FILE: kernel/events/uprobes.c:674: + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, ^ CHECK: spaces preferred around that '|' (ctx:VxV) #134: FILE: kernel/events/uprobes.c:674: + VM_READ|VM_EXEC|VM_MAYEXEC|VM_MAYREAD|VM_DONTCOPY|VM_IO, ^ CHECK: Comparison to NULL could be written "!tramp" #173: FILE: kernel/events/uprobes.c:713: + if (tramp == NULL) total: 0 errors, 4 warnings, 11 checks, 163 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 4e893ef5fa51 ("uprobes: Add mapping for optimized uprobe trampolines") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 11 checks, 163 lines checked