WARNING: line length of 82 exceeds 80 columns
#89: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:131:
+ int i, num_tcs = esw_qos_num_tcs(vport->qos.sched_node->esw->dev);
WARNING: line length of 97 exceeds 80 columns
#106: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:165:
+ op, sched_node_type_str[node->type], node->vport->vport, node->tc, err);
WARNING: line length of 88 exceeds 80 columns
#127: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:272:
+ SCHEDULING_CONTEXT_ELEMENT_TYPE_RATE_LIMIT,
WARNING: line length of 91 exceeds 80 columns
#145: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:419:
+static int esw_qos_vport_tc_create_sched_element(struct mlx5_esw_sched_node *vport_tc_node,
WARNING: line length of 86 exceeds 80 columns
#154: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:428:
+ SCHEDULING_CONTEXT_ELEMENT_TYPE_VPORT_TC,
WARNING: line length of 84 exceeds 80 columns
#161: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:435:
+ MLX5_SET(vport_tc_element, attr, vport_number, vport_tc_node->vport->vport);
WARNING: line length of 83 exceeds 80 columns
#163: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:437:
+ MLX5_SET(scheduling_context, sched_ctx, max_bw_obj_id, rate_limit_elem_ix);
WARNING: line length of 94 exceeds 80 columns
#164: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:438:
+ MLX5_SET(scheduling_context, sched_ctx, parent_element_id, vport_tc_node->parent->ix);
WARNING: line length of 83 exceeds 80 columns
#165: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:439:
+ MLX5_SET(scheduling_context, sched_ctx, bw_share, vport_tc_node->bw_share);
WARNING: line length of 83 exceeds 80 columns
#167: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:441:
+ return esw_qos_node_create_sched_element(vport_tc_node, sched_ctx, extack);
WARNING: line length of 89 exceeds 80 columns
#179: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:642:
+ struct mlx5_esw_sched_node *vports_tc_node,
WARNING: line length of 90 exceeds 80 columns
#187: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:650:
+ vport_tc_node = __esw_qos_alloc_node(vport_node->esw, 0, SCHED_NODE_TYPE_VPORT_TC,
WARNING: line length of 95 exceeds 80 columns
#195: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:658:
+ err = esw_qos_vport_tc_create_sched_element(vport_tc_node, rate_limit_elem_ix, extack);
WARNING: line length of 83 exceeds 80 columns
#208: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:671:
+ struct netlink_ext_ack *extack)
WARNING: line length of 82 exceeds 80 columns
#214: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:677:
+ __esw_qos_destroy_node(vport->qos.sched_nodes[i], extack);
WARNING: line length of 81 exceeds 80 columns
#223: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:686:
+ struct netlink_ext_ack *extack)
WARNING: line length of 100 exceeds 80 columns
#230: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:693:
+ vport->qos.sched_nodes = kcalloc(num_tcs, sizeof(struct mlx5_esw_sched_node *), GFP_KERNEL);
WARNING: line length of 98 exceeds 80 columns
#232: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:695:
+ NL_SET_ERR_MSG_MOD(extack, "Allocating the vport TC scheduling elements failed.");
WARNING: line length of 87 exceeds 80 columns
#236: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:699:
+ rate_limit_elem_ix = type == SCHED_NODE_TYPE_RATE_LIMITER ? vport_node->ix : 0;
WARNING: line length of 97 exceeds 80 columns
#237: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:700:
+ tc_arbiter_node = type == SCHED_NODE_TYPE_RATE_LIMITER ? vport_node->parent : vport_node;
WARNING: line length of 99 exceeds 80 columns
#239: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:702:
+ err = esw_qos_create_vport_tc_sched_node(vport, rate_limit_elem_ix, vports_tc_node,
WARNING: line length of 87 exceeds 80 columns
#253: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:716:
+static int esw_qos_vport_tc_enable(struct mlx5_vport *vport, enum sched_node_type type,
WARNING: line length of 98 exceeds 80 columns
#261: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:724:
+ NL_SET_ERR_MSG_MOD(extack, "Setting up TC Arbiter for a vport is not supported.");
WARNING: line length of 81 exceeds 80 columns
#290: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:753:
+ list_add_tail(&vport_node->entry, &vport_node->parent->children);
WARNING: line length of 94 exceeds 80 columns
#297: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:760:
+static void esw_qos_vport_tc_disable(struct mlx5_vport *vport, struct netlink_ext_ack *extack)
WARNING: line length of 81 exceeds 80 columns
#310: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:773:
+static int esw_qos_set_vport_tcs_min_rate(struct mlx5_vport *vport, u32 min_rate,
WARNING: line length of 93 exceeds 80 columns
#317: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:780:
+ err = esw_qos_set_node_min_rate(vport->qos.sched_nodes[i], min_rate, extack);
WARNING: line length of 99 exceeds 80 columns
#326: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:789:
+ esw_qos_set_node_min_rate(vport->qos.sched_nodes[i], vport_node->min_rate, extack);
WARNING: line length of 84 exceeds 80 columns
#349: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:811:
+static int esw_qos_vport_enable(struct mlx5_vport *vport, enum sched_node_type type,
WARNING: line length of 88 exceeds 80 columns
#360: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:821:
+ err = esw_qos_vport_create_sched_element(vport->qos.sched_node, extack);
WARNING: line length of 84 exceeds 80 columns
#413: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:962:
+static int esw_qos_vport_update(struct mlx5_vport *vport, enum sched_node_type type,
WARNING: line length of 86 exceeds 80 columns
#461: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1001:
+ /* Set vport QoS type based on parent node type if different from default QoS;
WARNING: line length of 90 exceeds 80 columns
#480: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1302:
+static bool esw_qos_vport_validate_unsupported_tc_bw(struct mlx5_vport *vport, u32 *tc_bw)
WARNING: line length of 97 exceeds 80 columns
#483: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1305:
+ vport->qos.sched_node->parent->esw : vport->dev->priv.eswitch;
WARNING: line length of 95 exceeds 80 columns
#511: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1397:
+ NL_SET_ERR_MSG_MOD(extack, "E-Switch traffic classes number is not supported");
WARNING: line length of 87 exceeds 80 columns
#521: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1407:
+ err = esw_qos_vport_update(vport, SCHED_NODE_TYPE_VPORT, NULL, extack);
WARNING: line length of 99 exceeds 80 columns
#526: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1412:
+ err = mlx5_esw_qos_vport_enable(vport, SCHED_NODE_TYPE_TC_ARBITER_TSAR, NULL, 0, 0,
WARNING: line length of 97 exceeds 80 columns
#530: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1416:
+ err = esw_qos_vport_update(vport, SCHED_NODE_TYPE_TC_ARBITER_TSAR, NULL, extack);
WARNING: line length of 93 exceeds 80 columns
#546: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1540:
+ enum sched_node_type type = parent->type == SCHED_NODE_TYPE_TC_ARBITER_TSAR ?
WARNING: line length of 97 exceeds 80 columns
#547: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1541:
+ SCHED_NODE_TYPE_RATE_LIMITER : SCHED_NODE_TYPE_VPORT;
WARNING: line length of 83 exceeds 80 columns
#549: FILE: drivers/net/ethernet/mellanox/mlx5/core/esw/qos.c:1543:
+ err = mlx5_esw_qos_vport_enable(vport, type, parent, 0, 0, extack);
WARNING: line length of 87 exceeds 80 columns
#571: FILE: drivers/net/ethernet/mellanox/mlx5/core/eswitch.h:221:
+ * When TC is enabled in either mode, the vport owns vport TC scheduling nodes.
total: 0 errors, 42 warnings, 0 checks, 503 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
Commit 4e7fb603d16a ("net/mlx5: Add traffic class scheduling support for vport QoS") has style problems, please review.
NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 42 warnings, 0 checks, 503 lines checked