WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 WARNING: Improper SPDX comment style for 'tools/testing/selftests/drivers/net/hw/iou-zcrx.c', please use '//' instead #63: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:1: +/* SPDX-License-Identifier: GPL-2.0 */ WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #63: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:1: +/* SPDX-License-Identifier: GPL-2.0 */ ERROR: do not initialise statics to 0 #121: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:59: +static int cfg_server = 0; ERROR: do not initialise statics to 0 #122: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:60: +static int cfg_client = 0; ERROR: do not initialise statics to NULL #125: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:63: +static const char *cfg_ifname = NULL; WARNING: Prefer __aligned(PAGE_SIZE) over __attribute__((aligned(PAGE_SIZE))) #131: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:69: +static char payload[SEND_SIZE] __attribute__((aligned(PAGE_SIZE))); ERROR: do not initialise statics to NULL #132: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:70: +static void *area_ptr = NULL; ERROR: do not initialise statics to NULL #133: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:71: +static void *ring_ptr = NULL; ERROR: do not initialise statics to 0 #134: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:72: +static size_t ring_size = 0; ERROR: do not initialise statics to 0 #137: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:75: +static int connfd = 0; ERROR: do not initialise statics to false #138: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:76: +static bool stop = false; ERROR: do not initialise statics to 0 #139: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:77: +static size_t received = 0; ERROR: "(foo*)" should be "(foo *)" #210: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:148: + rq_ring.khead = (unsigned int*)((char*)ring_ptr + reg.offsets.head); ERROR: "(foo*)" should be "(foo *)" #210: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:148: + rq_ring.khead = (unsigned int*)((char*)ring_ptr + reg.offsets.head); ERROR: "(foo*)" should be "(foo *)" #211: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:149: + rq_ring.ktail = (unsigned int*)((char*)ring_ptr + reg.offsets.tail); ERROR: "(foo*)" should be "(foo *)" #211: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:149: + rq_ring.ktail = (unsigned int*)((char*)ring_ptr + reg.offsets.tail); WARNING: line length of 87 exceeds 80 columns #212: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:150: + rq_ring.rqes = (struct io_uring_zcrx_rqe*)((char*)ring_ptr + reg.offsets.rqes); ERROR: "(foo*)" should be "(foo *)" #212: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:150: + rq_ring.rqes = (struct io_uring_zcrx_rqe*)((char*)ring_ptr + reg.offsets.rqes); ERROR: "(foo*)" should be "(foo *)" #212: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:150: + rq_ring.rqes = (struct io_uring_zcrx_rqe*)((char*)ring_ptr + reg.offsets.rqes); WARNING: Prefer 'unsigned int' to bare use of 'unsigned' #253: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:191: + unsigned rq_mask = rq_ring.ring_entries - 1; ERROR: "foo* bar" should be "foo *bar" #255: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:193: + struct io_uring_zcrx_rqe* rqe; ERROR: "(foo*)" should be "(foo *)" #273: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:211: + rcqe = (struct io_uring_zcrx_cqe*)(cqe + 1); ERROR: Bad function definition - void run_server() should probably be void run_server(void) #312: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:250: +static void run_server() ERROR: Bad function definition - void run_client() should probably be void run_client(void) #355: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:293: +static void run_client() WARNING: quoted string split across lines #386: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:324: + error(1, 0, "Usage: %s (-4|-6) (-s|-c) -h -p " + "-l -i -q", filepath); CHECK: No space is necessary after a cast #395: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:333: + struct sockaddr_in6 *addr6 = (void *) &cfg_addr; CHECK: No space is necessary after a cast #396: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:334: + struct sockaddr_in *addr4 = (void *) &cfg_addr; CHECK: Unnecessary parentheses around addr4->sin_addr #457: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:395: + inet_pton(AF_INET, addr, &(addr4->sin_addr)) != 1) CHECK: Unnecessary parentheses around addr6->sin6_addr #467: FILE: tools/testing/selftests/drivers/net/hw/iou-zcrx.c:405: + inet_pton(AF_INET6, addr, &(addr6->sin6_addr)) != 1) total: 19 errors, 7 warnings, 4 checks, 519 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit c78aca3a48b6 ("io_uring/zcrx: add selftest") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.