========== checkpatch - FAILED ERROR: Macros with complex values should be enclosed in parentheses #56: FILE: include/trace/events/rxrpc.h:500: +#define rxrpc_rotate_traces \ + EM(rxrpc_rotate_trace_hack, "hard-ack") \ + EM(rxrpc_rotate_trace_sack, "soft-ack") \ + E_(rxrpc_rotate_trace_snak, "soft-nack") CHECK: Lines should not end with a '(' #136: FILE: include/trace/events/rxrpc.h:1866: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #143: FILE: include/trace/events/rxrpc.h:1873: + TP_fast_assign( CHECK: Lines should not end with a '(' #190: FILE: include/trace/events/rxrpc.h:1920: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #198: FILE: include/trace/events/rxrpc.h:1928: + TP_fast_assign( WARNING: line length of 82 exceeds 80 columns #225: FILE: net/rxrpc/ar-internal.h:217: + u16 nr_acks; /* Number of acks+nacks */ WARNING: line length of 98 exceeds 80 columns #257: FILE: net/rxrpc/ar-internal.h:858: + u8 nr_reported_acks; /* Number of segments explicitly acked/nacked */ WARNING: line length of 87 exceeds 80 columns #259: FILE: net/rxrpc/ar-internal.h:860: + unsigned long segment_lost; /* Bit-per-buf: Set if declared lost */ WARNING: line length of 94 exceeds 80 columns #260: FILE: net/rxrpc/ar-internal.h:861: + unsigned long segment_retransmitted; /* Bit-per-buf: Set if retransmitted */ WARNING: line length of 90 exceeds 80 columns #269: FILE: net/rxrpc/ar-internal.h:939: +void rxrpc_resend(struct rxrpc_call *call, rxrpc_serial_t ack_serial, bool ping_response); WARNING: line length of 89 exceeds 80 columns #331: FILE: net/rxrpc/call_event.c:100: +void rxrpc_resend(struct rxrpc_call *call, rxrpc_serial_t ack_serial, bool ping_response) WARNING: line length of 98 exceeds 80 columns #346: FILE: net/rxrpc/call_event.c:106: + ktime_t lowest_xmit_ts = KTIME_MAX, rto = ns_to_ktime(call->peer->rto_us * NSEC_PER_USEC); WARNING: line length of 91 exceeds 80 columns #399: FILE: net/rxrpc/call_event.c:131: + tq->segment_acked, tq->nr_reported_acks, call->debug_id, tq->qbase); WARNING: line length of 85 exceeds 80 columns #451: FILE: net/rxrpc/call_event.c:158: + tq->qbase + tq->nr_reported_acks); WARNING: line length of 82 exceeds 80 columns #452: FILE: net/rxrpc/call_event.c:159: + rxrpc_seq_t stop = earliest(tq_top, call->tx_transmitted); WARNING: line length of 81 exceeds 80 columns #455: FILE: net/rxrpc/call_event.c:162: + for (rxrpc_seq_t seq = start; before(seq, stop); seq++) { WARNING: line length of 89 exceeds 80 columns #456: FILE: net/rxrpc/call_event.c:163: + struct rxrpc_txbuf *txb = tq->bufs[seq & RXRPC_TXQ_MASK]; WARNING: line length of 83 exceeds 80 columns #459: FILE: net/rxrpc/call_event.c:166: + before(txb->serial, call->acks_highest_serial)) WARNING: line length of 96 exceeds 80 columns #460: FILE: net/rxrpc/call_event.c:167: + break; /* Wasn't accounted for by a more recent ping. */ WARNING: line length of 81 exceeds 80 columns #464: FILE: net/rxrpc/call_event.c:171: + if (rxrpc_retransmit_data(call, &req, rto, true)) WARNING: line length of 93 exceeds 80 columns #489: FILE: net/rxrpc/call_event.c:184: + _debug("lowest[%x] %llx %u", tq->qbase, tq->xmit_ts_base, lowest_us); WARNING: line length of 94 exceeds 80 columns #494: FILE: net/rxrpc/call_event.c:187: + ktime_t lowest_ns = ktime_add_us(tq->xmit_ts_base, lowest_us); WARNING: line length of 92 exceeds 80 columns #653: FILE: net/rxrpc/input.c:244: + trace_rxrpc_rotate(call, tq, summary, seq, rxrpc_rotate_trace_hack); WARNING: line length of 92 exceeds 80 columns #657: FILE: net/rxrpc/input.c:248: + trace_rxrpc_rotate(call, tq, summary, seq, rxrpc_rotate_trace_sack); WARNING: line length of 92 exceeds 80 columns #663: FILE: net/rxrpc/input.c:254: + trace_rxrpc_rotate(call, tq, summary, seq, rxrpc_rotate_trace_snak); WARNING: line length of 89 exceeds 80 columns #705: FILE: net/rxrpc/input.c:790: + : "+d"(shift_from), "+m"(*(shift_from)), "+rm"(rotate_into) \ CHECK: Macro argument 'rotate_into' may be better as '(rotate_into)' to avoid precedence issues #709: FILE: net/rxrpc/input.c:794: +#define shiftr_adv_rotr(shift_from, rotate_into) ({ \ + typeof(rotate_into) __bit0 = *(shift_from) & 1; \ + *(shift_from) >>= 1; \ + shift_from++; \ + rotate_into >>= 1; \ + rotate_into |= __bit0 << (sizeof(rotate_into) * 8 - 1); \ + }) WARNING: line length of 81 exceeds 80 columns #714: FILE: net/rxrpc/input.c:799: + rotate_into |= __bit0 << (sizeof(rotate_into) * 8 - 1); \ WARNING: line length of 84 exceeds 80 columns #787: FILE: net/rxrpc/input.c:849: + _debug("new_a %16lx new=%d a=%d n=%d", new_acks, new, a, n); WARNING: line length of 87 exceeds 80 columns #870: FILE: net/rxrpc/input.c:912: + rxrpc_input_soft_ack_tq(call, summary, tq, extracted, RXRPC_NR_TXQUEUE, WARNING: line length of 82 exceeds 80 columns #886: FILE: net/rxrpc/input.c:925: + rxrpc_input_soft_ack_tq(call, summary, tq, extracted, nr_reported, WARNING: line length of 94 exceeds 80 columns #959: FILE: net/rxrpc/input.c:1121: + rxrpc_resend(call, ack_serial, summary.ack_reason == RXRPC_ACK_PING_RESPONSE); WARNING: line length of 84 exceeds 80 columns #972: FILE: net/rxrpc/output.c:464: + trace_rxrpc_tx_data(call, txb->seq, txb->serial, txb->flags | flags, false); total: 1 errors, 27 warnings, 5 checks, 906 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0d7c1f7de98a ("rxrpc: Use the new rxrpc_tx_queue struct to more efficiently process ACKs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.