========== checkpatch - FAILED ERROR: Macros with complex values should be enclosed in parentheses #50: FILE: include/trace/events/rxrpc.h:381: +#define rxrpc_ca_states \ + EM(RXRPC_CA_CONGEST_AVOIDANCE, "CongAvoid") \ + EM(RXRPC_CA_FAST_RETRANSMIT, "FastReTx ") \ + EM(RXRPC_CA_PACKET_LOSS, "PktLoss ") \ + E_(RXRPC_CA_SLOW_START, "SlowStart") WARNING: line length of 81 exceeds 80 columns #138: FILE: include/trace/events/rxrpc.h:1741: + __entry->lowest_nak, __entry->sum.new_low_snack ? "!" : "", WARNING: line length of 83 exceeds 80 columns #139: FILE: include/trace/events/rxrpc.h:1742: + __print_symbolic(__entry->sum.change, rxrpc_congest_changes), WARNING: line length of 91 exceeds 80 columns #208: FILE: net/rxrpc/ar-internal.h:734: + u16 cong_dup_acks; /* Count of ACKs showing missing packets */ WARNING: line length of 82 exceeds 80 columns #217: FILE: net/rxrpc/ar-internal.h:766: + unsigned short acks_nr_sacks; /* Number of soft acks recorded */ WARNING: line length of 83 exceeds 80 columns #218: FILE: net/rxrpc/ar-internal.h:767: + unsigned short acks_nr_snacks; /* Number of soft nacks recorded */ WARNING: line length of 88 exceeds 80 columns #240: FILE: net/rxrpc/ar-internal.h:774: + u16 in_flight; /* Number of unreceived transmissions */ WARNING: line length of 87 exceeds 80 columns #242: FILE: net/rxrpc/ar-internal.h:776: + u16 nr_new_sacks; /* Number of new soft ACKs in packet */ WARNING: line length of 88 exceeds 80 columns #243: FILE: net/rxrpc/ar-internal.h:777: + u16 nr_new_snacks; /* Number of new soft nacks in packet */ WARNING: line length of 91 exceeds 80 columns #244: FILE: net/rxrpc/ar-internal.h:778: + u16 nr_retained_snacks; /* Number of nacks retained between ACKs */ WARNING: line length of 82 exceeds 80 columns #247: FILE: net/rxrpc/ar-internal.h:781: + bool new_low_snack:1; /* T if new low soft NACK found */ WARNING: line length of 87 exceeds 80 columns #248: FILE: net/rxrpc/ar-internal.h:782: + bool retrans_timeo:1; /* T if reTx due to timeout happened */ WARNING: line length of 84 exceeds 80 columns #285: FILE: net/rxrpc/input.c:40: + summary->in_flight = (call->tx_top - call->tx_bottom) - call->acks_nr_sacks; WARNING: line length of 81 exceeds 80 columns #555: FILE: net/rxrpc/input.c:861: + summary->nr_new_sacks += summary->nr_retained_snacks - old_nacks; WARNING: line length of 84 exceeds 80 columns #587: FILE: net/rxrpc/output.c:422: + else if (call->cong_ca_state == RXRPC_CA_SLOW_START && call->cong_cwnd <= 2) total: 1 errors, 14 warnings, 0 checks, 507 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 12662fa41c1b ("rxrpc: Adjust names and types of congestion-related fields") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.