tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files ../drivers/net/ovpn/udp.c:270:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 270 | if (unlikely(!bind)) { | ^~~~~~~~~~~~~~~ ../include/linux/compiler.h:77:22: note: expanded from macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/udp.c:292:9: note: uninitialized use occurs here 292 | return ret; | ^~~ ../drivers/net/ovpn/udp.c:270:2: note: remove the 'if' if its condition is always false 270 | if (unlikely(!bind)) { | ^~~~~~~~~~~~~~~~~~~~~~ 271 | net_warn_ratelimited("%s: no bind for remote peer %u\n", | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 272 | netdev_name(peer->ovpn->dev), peer->id); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 273 | goto out; | ~~~~~~~~~ 274 | } | ~ ../drivers/net/ovpn/udp.c:259:9: note: initialize the variable 'ret' to silence this warning 259 | int ret; | ^ | = 0 1 warning generated. ../drivers/net/ovpn/peer.c:434:9: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 434 | head = ovpn_get_hash_head(ovpn->peers->by_id, &peer_id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 435 | sizeof(peer_id)); | ~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' 201 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:748:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 748 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 749 | &peer->vpn_addrs.ipv6, | ~~~~~~~~~~~~~~~~~~~~~~ 750 | sizeof(peer->vpn_addrs.ipv6)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' 201 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:741:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 741 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 742 | &peer->vpn_addrs.ipv4, | ~~~~~~~~~~~~~~~~~~~~~~ 743 | sizeof(peer->vpn_addrs.ipv4)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' 201 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:737:7: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 737 | ovpn_get_hash_head(ovpn->peers->by_id, &peer->id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 738 | sizeof(peer->id))); | ~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' 201 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:731:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 731 | nhead = ovpn_get_hash_head(ovpn->peers->by_transp_addr, &sa, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 732 | salen); | ~~~~~~ ../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' 201 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ 5 warnings generated. tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files ../drivers/net/ovpn/udp.c:270:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] 270 | if (unlikely(!bind)) { | ^~~~~~~~~~~~~~~ ../include/linux/compiler.h:77:22: note: expanded from macro 'unlikely' 77 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/udp.c:292:9: note: uninitialized use occurs here 292 | return ret; | ^~~ ../drivers/net/ovpn/udp.c:270:2: note: remove the 'if' if its condition is always false 270 | if (unlikely(!bind)) { | ^~~~~~~~~~~~~~~~~~~~~~ 271 | net_warn_ratelimited("%s: no bind for remote peer %u\n", | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 272 | netdev_name(peer->ovpn->dev), peer->id); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 273 | goto out; | ~~~~~~~~~ 274 | } | ~ ../drivers/net/ovpn/udp.c:259:9: note: initialize the variable 'ret' to silence this warning 259 | int ret; | ^ | = 0 1 warning generated. ../drivers/net/ovpn/peer.c:268:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 268 | nhead = ovpn_get_hash_head(peer->ovpn->peers->by_transp_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 269 | &bind->remote, salen); | ~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' 142 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:606:9: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 606 | head = ovpn_get_hash_head(ovpn->peers->by_id, &peer_id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 607 | sizeof(peer_id)); | ~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' 142 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:875:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 875 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 876 | &peer->vpn_addrs.ipv6, | ~~~~~~~~~~~~~~~~~~~~~~ 877 | sizeof(peer->vpn_addrs.ipv6)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' 142 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:868:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 868 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 869 | &peer->vpn_addrs.ipv4, | ~~~~~~~~~~~~~~~~~~~~~~ 870 | sizeof(peer->vpn_addrs.ipv4)); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' 142 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:864:7: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 864 | ovpn_get_hash_head(ovpn->peers->by_id, &peer->id, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 865 | sizeof(peer->id))); | ~~~~~~~~~~~~~~~~~ ../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' 142 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ ../drivers/net/ovpn/peer.c:858:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] 858 | nhead = ovpn_get_hash_head(ovpn->peers->by_transp_addr, &sa, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 859 | salen); | ~~~~~~ ../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ ../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' 142 | typeof(_tbl) *__tbl = &(_tbl); \ | ~~~~~ ^~~~ 6 warnings generated. New errors added --- /tmp/tmp.i8vmCW8qsj 2024-12-02 10:15:11.043875229 -0800 +++ /tmp/tmp.53jdlDjzcb 2024-12-02 10:16:15.214253401 -0800 @@ -29,2 +29,13 @@ -../drivers/net/ovpn/peer.c:434:9: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] - 434 | head = ovpn_get_hash_head(ovpn->peers->by_id, &peer_id, +../drivers/net/ovpn/peer.c:268:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] + 268 | nhead = ovpn_get_hash_head(peer->ovpn->peers->by_transp_addr, + | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + 269 | &bind->remote, salen); + | ~~~~~~~~~~~~~~~~~~~~~ +../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' + 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ + | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ +../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' + 142 | typeof(_tbl) *__tbl = &(_tbl); \ + | ~~~~~ ^~~~ +../drivers/net/ovpn/peer.c:606:9: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] + 606 | head = ovpn_get_hash_head(ovpn->peers->by_id, &peer_id, @@ -32 +43 @@ - 435 | sizeof(peer_id)); + 607 | sizeof(peer_id)); @@ -34,2 +45,2 @@ -../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' - 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ +../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' + 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ @@ -37,2 +48,2 @@ -../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' - 201 | typeof(_tbl) *__tbl = &(_tbl); \ +../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' + 142 | typeof(_tbl) *__tbl = &(_tbl); \ @@ -40,2 +51,2 @@ -../drivers/net/ovpn/peer.c:748:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] - 748 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, +../drivers/net/ovpn/peer.c:875:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] + 875 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, @@ -43 +54 @@ - 749 | &peer->vpn_addrs.ipv6, + 876 | &peer->vpn_addrs.ipv6, @@ -45 +56 @@ - 750 | sizeof(peer->vpn_addrs.ipv6)); + 877 | sizeof(peer->vpn_addrs.ipv6)); @@ -47,2 +58,2 @@ -../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' - 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ +../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' + 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ @@ -50,2 +61,2 @@ -../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' - 201 | typeof(_tbl) *__tbl = &(_tbl); \ +../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' + 142 | typeof(_tbl) *__tbl = &(_tbl); \ @@ -53,2 +64,2 @@ -../drivers/net/ovpn/peer.c:741:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] - 741 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, +../drivers/net/ovpn/peer.c:868:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] + 868 | nhead = ovpn_get_hash_head(ovpn->peers->by_vpn_addr, @@ -56 +67 @@ - 742 | &peer->vpn_addrs.ipv4, + 869 | &peer->vpn_addrs.ipv4, @@ -58 +69 @@ - 743 | sizeof(peer->vpn_addrs.ipv4)); + 870 | sizeof(peer->vpn_addrs.ipv4)); @@ -60,2 +71,2 @@ -../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' - 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ +../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' + 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ @@ -63,2 +74,2 @@ -../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' - 201 | typeof(_tbl) *__tbl = &(_tbl); \ +../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' + 142 | typeof(_tbl) *__tbl = &(_tbl); \ @@ -66,2 +77,2 @@ -../drivers/net/ovpn/peer.c:737:7: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] - 737 | ovpn_get_hash_head(ovpn->peers->by_id, &peer->id, +../drivers/net/ovpn/peer.c:864:7: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] + 864 | ovpn_get_hash_head(ovpn->peers->by_id, &peer->id, @@ -69 +80 @@ - 738 | sizeof(peer->id))); + 865 | sizeof(peer->id))); @@ -71,2 +82,2 @@ -../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' - 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ +../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' + 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ @@ -74,2 +85,2 @@ -../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' - 201 | typeof(_tbl) *__tbl = &(_tbl); \ +../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' + 142 | typeof(_tbl) *__tbl = &(_tbl); \ @@ -77,2 +88,2 @@ -../drivers/net/ovpn/peer.c:731:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] - 731 | nhead = ovpn_get_hash_head(ovpn->peers->by_transp_addr, &sa, +../drivers/net/ovpn/peer.c:858:11: warning: variable '__tbl' is uninitialized when used within its own initialization [-Wuninitialized] + 858 | nhead = ovpn_get_hash_head(ovpn->peers->by_transp_addr, &sa, @@ -80 +91 @@ - 732 | salen); + 859 | salen); @@ -82,2 +93,2 @@ -../drivers/net/ovpn/peer.c:207:48: note: expanded from macro 'ovpn_get_hash_head' - 207 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ +../drivers/net/ovpn/peer.c:148:48: note: expanded from macro 'ovpn_get_hash_head' + 148 | &(*__tbl)[ovpn_get_hash_slot(_key, _key_len, *__tbl)]; \ @@ -85,2 +96,2 @@ -../drivers/net/ovpn/peer.c:201:26: note: expanded from macro 'ovpn_get_hash_slot' - 201 | typeof(_tbl) *__tbl = &(_tbl); \ +../drivers/net/ovpn/peer.c:142:26: note: expanded from macro 'ovpn_get_hash_slot' + 142 | typeof(_tbl) *__tbl = &(_tbl); \ @@ -88 +99 @@ -5 warnings generated. +6 warnings generated. Per-file breakdown --- /tmp/tmp.y2n9i3MSZj 2024-12-02 10:17:04.711773757 -0800 +++ /tmp/tmp.8oMktAGM4X 2024-12-02 10:17:04.714773728 -0800 @@ -1 +1 @@ - 5 ../drivers/net/ovpn/peer.c + 6 ../drivers/net/ovpn/peer.c