========== checkpatch - FAILED ERROR: Macros with complex values should be enclosed in parentheses #88: FILE: include/trace/events/rxrpc.h:511: +#define rxrpc_rack_timer_modes \ + EM(RXRPC_CALL_RACKTIMER_OFF, "---") \ + EM(RXRPC_CALL_RACKTIMER_RACK_REORDER, "REO") \ + EM(RXRPC_CALL_RACKTIMER_TLP_PTO, "TLP") \ + E_(RXRPC_CALL_RACKTIMER_RTO, "RTO") ERROR: Macros with complex values should be enclosed in parentheses #94: FILE: include/trace/events/rxrpc.h:517: +#define rxrpc_tlp_probe_traces \ + EM(rxrpc_tlp_probe_trace_busy, "busy") \ + EM(rxrpc_tlp_probe_trace_transmit_new, "transmit-new") \ + E_(rxrpc_tlp_probe_trace_retransmit, "retransmit") ERROR: Macros with complex values should be enclosed in parentheses #99: FILE: include/trace/events/rxrpc.h:522: +#define rxrpc_tlp_ack_traces \ + EM(rxrpc_tlp_ack_trace_acked, "acked") \ + EM(rxrpc_tlp_ack_trace_dup_acked, "dup-acked") \ + EM(rxrpc_tlp_ack_trace_hard_beyond, "hard-beyond") \ + EM(rxrpc_tlp_ack_trace_incomplete, "incomplete") \ + E_(rxrpc_tlp_ack_trace_new_data, "new-data") CHECK: Lines should not end with a '(' #142: FILE: include/trace/events/rxrpc.h:650: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #146: FILE: include/trace/events/rxrpc.h:654: + TP_fast_assign( WARNING: line length of 82 exceeds 80 columns #198: FILE: include/trace/events/rxrpc.h:1807: + TP_PROTO(struct rxrpc_call *call, ktime_t since_last_tx, ktime_t rtt), WARNING: line length of 92 exceeds 80 columns #242: FILE: include/trace/events/rxrpc.h:1969: + TP_PROTO(struct rxrpc_call *call, struct rxrpc_txqueue *tq, unsigned long lost), CHECK: Lines should not end with a '(' #246: FILE: include/trace/events/rxrpc.h:1973: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #253: FILE: include/trace/events/rxrpc.h:1980: + TP_fast_assign( CHECK: Lines should not end with a '(' #279: FILE: include/trace/events/rxrpc.h:2437: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #291: FILE: include/trace/events/rxrpc.h:2449: + TP_fast_assign( WARNING: line length of 81 exceeds 80 columns #312: FILE: include/trace/events/rxrpc.h:2470: + TP_PROTO(struct rxrpc_call *call, struct rxrpc_ack_summary *summary), CHECK: Lines should not end with a '(' #316: FILE: include/trace/events/rxrpc.h:2474: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #323: FILE: include/trace/events/rxrpc.h:2481: + TP_fast_assign( WARNING: line length of 94 exceeds 80 columns #327: FILE: include/trace/events/rxrpc.h:2485: + __entry->xmit_ts = ktime_sub(call->acks_latest_ts, call->rack_xmit_ts); CHECK: Lines should not end with a '(' #340: FILE: include/trace/events/rxrpc.h:2498: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #346: FILE: include/trace/events/rxrpc.h:2504: + TP_fast_assign( CHECK: Lines should not end with a '(' #363: FILE: include/trace/events/rxrpc.h:2521: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #371: FILE: include/trace/events/rxrpc.h:2529: + TP_fast_assign( CHECK: Lines should not end with a '(' #390: FILE: include/trace/events/rxrpc.h:2548: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #396: FILE: include/trace/events/rxrpc.h:2554: + TP_fast_assign( CHECK: Lines should not end with a '(' #411: FILE: include/trace/events/rxrpc.h:2569: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #420: FILE: include/trace/events/rxrpc.h:2578: + TP_fast_assign( CHECK: Lines should not end with a '(' #439: FILE: include/trace/events/rxrpc.h:2597: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #446: FILE: include/trace/events/rxrpc.h:2604: + TP_fast_assign( CHECK: Lines should not end with a '(' #464: FILE: include/trace/events/rxrpc.h:2622: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #472: FILE: include/trace/events/rxrpc.h:2630: + TP_fast_assign( CHECK: Lines should not end with a '(' #491: FILE: include/trace/events/rxrpc.h:2649: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #498: FILE: include/trace/events/rxrpc.h:2656: + TP_fast_assign( WARNING: line length of 81 exceeds 80 columns #556: FILE: net/rxrpc/ar-internal.h:653: + ktime_t rack_timo_at; /* When ACK is figured as lost */ WARNING: line length of 85 exceeds 80 columns #564: FILE: net/rxrpc/ar-internal.h:709: + rxrpc_serial_t tx_last_serial; /* Serial of last DATA transmitted */ WARNING: line length of 89 exceeds 80 columns #567: FILE: net/rxrpc/ar-internal.h:711: + u16 tx_nr_sent; /* Number of packets sent, but unacked */ WARNING: line length of 83 exceeds 80 columns #568: FILE: net/rxrpc/ar-internal.h:712: + u16 tx_nr_lost; /* Number of packets marked lost */ WARNING: line length of 91 exceeds 80 columns #569: FILE: net/rxrpc/ar-internal.h:713: + u16 tx_nr_resent; /* Number of packets resent, but unacked */ WARNING: line length of 83 exceeds 80 columns #579: FILE: net/rxrpc/ar-internal.h:745: + ktime_t rack_xmit_ts; /* Latest transmission timestamp */ WARNING: line length of 88 exceeds 80 columns #580: FILE: net/rxrpc/ar-internal.h:746: + ktime_t rack_rtt; /* RTT of most recently ACK'd segment */ WARNING: line length of 91 exceeds 80 columns #583: FILE: net/rxrpc/ar-internal.h:749: + unsigned int rack_reo_wnd_mult; /* Multiplier applied to rack_reo_wnd */ WARNING: line length of 100 exceeds 80 columns #584: FILE: net/rxrpc/ar-internal.h:750: + int rack_reo_wnd_persist; /* Num loss recoveries before reset reo_wnd */ WARNING: line length of 83 exceeds 80 columns #585: FILE: net/rxrpc/ar-internal.h:751: + rxrpc_seq_t rack_fack; /* Highest sequence so far ACK'd */ WARNING: line length of 92 exceeds 80 columns #587: FILE: net/rxrpc/ar-internal.h:753: + rxrpc_seq_t rack_dsack_round; /* DSACK opt recv'd in latest roundtrip */ WARNING: line length of 87 exceeds 80 columns #588: FILE: net/rxrpc/ar-internal.h:754: + bool rack_dsack_round_none; /* T if dsack_round is "None" */ WARNING: line length of 90 exceeds 80 columns #589: FILE: net/rxrpc/ar-internal.h:755: + bool rack_reordering_seen; /* T if detected reordering event */ WARNING: line length of 84 exceeds 80 columns #590: FILE: net/rxrpc/ar-internal.h:756: + enum rxrpc_rack_timer_mode rack_timer_mode; /* Current mode of RACK timer */ WARNING: line length of 85 exceeds 80 columns #591: FILE: net/rxrpc/ar-internal.h:757: + bool tlp_is_retrans; /* T if unacked TLP retransmission */ WARNING: line length of 100 exceeds 80 columns #592: FILE: net/rxrpc/ar-internal.h:758: + rxrpc_serial_t tlp_serial; /* Serial of TLP probe (or 0 if none in progress) */ WARNING: line length of 99 exceeds 80 columns #595: FILE: net/rxrpc/ar-internal.h:761: + ktime_t tlp_max_ack_delay; /* Sender budget for max delayed ACK interval */ WARNING: line length of 86 exceeds 80 columns #606: FILE: net/rxrpc/ar-internal.h:823: + bool tlp_probe_acked:1; /* T if the TLP probe seq was acked */ WARNING: line length of 96 exceeds 80 columns #614: FILE: net/rxrpc/ar-internal.h:905: + unsigned long ever_retransmitted; /* Bit-per-buf: Set if ever retransmitted */ WARNING: line length of 83 exceeds 80 columns #622: FILE: net/rxrpc/ar-internal.h:925: + bool retrans; /* T if this is a retransmission */ WARNING: line length of 87 exceeds 80 columns #659: FILE: net/rxrpc/ar-internal.h:1183: +void rxrpc_tlp_process_ack(struct rxrpc_call *call, struct rxrpc_ack_summary *summary); WARNING: line length of 84 exceeds 80 columns #677: FILE: net/rxrpc/ar-internal.h:1470: +static inline bool rxrpc_seq_in_txq(const struct rxrpc_txqueue *tq, rxrpc_seq_t seq) CHECK: Please use a blank line after function/struct/union/enum declarations #677: FILE: net/rxrpc/ar-internal.h:1470: } +static inline bool rxrpc_seq_in_txq(const struct rxrpc_txqueue *tq, rxrpc_seq_t seq) WARNING: line length of 81 exceeds 80 columns #693: FILE: net/rxrpc/ar-internal.h:1487: + int winsize = umin(call->tx_winsize, call->cong_cwnd + call->cong_extra); WARNING: line length of 84 exceeds 80 columns #899: FILE: net/rxrpc/call_event.c:129: + * Resend the highest-seq DATA packet so far transmitted for RACK-TLP [RFC8985 7.3]. WARNING: line length of 85 exceeds 80 columns #925: FILE: net/rxrpc/call_event.c:151: + before(call->tx_transmitted, req.tq->qbase + RXRPC_NR_TXQUEUE)) { WARNING: line length of 82 exceeds 80 columns #950: FILE: net/rxrpc/call_event.c:194: +static void rxrpc_transmit_fresh_data(struct rxrpc_call *call, unsigned int limit, WARNING: line length of 98 exceeds 80 columns #1014: FILE: net/rxrpc/call_event.c:343: + rxrpc_timer_trace_rack_off + call->rack_timer_mode); WARNING: line length of 82 exceeds 80 columns #1188: FILE: net/rxrpc/input.c:209: + ktime_t xmit_ts = ktime_add_us(tq->xmit_ts_base, tq->segment_xmit_ts[ix]); WARNING: line length of 88 exceeds 80 columns #1279: FILE: net/rxrpc/input.c:355: + trace_rxrpc_timer_can(call, rxrpc_timer_trace_rack_off + call->rack_timer_mode); WARNING: line length of 81 exceeds 80 columns #1294: FILE: net/rxrpc/input.c:876: + old_reported = ~0UL >> (RXRPC_NR_TXQUEUE - tq->nr_reported_acks); WARNING: line length of 90 exceeds 80 columns #1352: FILE: net/rxrpc/input.c:1125: + summary.acked_serial, summary.ack_serial, WARNING: line length of 83 exceeds 80 columns #1356: FILE: net/rxrpc/input.c:1129: + if (after(summary.acked_serial, call->acks_highest_serial)) WARNING: line length of 81 exceeds 80 columns #1357: FILE: net/rxrpc/input.c:1130: + call->acks_highest_serial = summary.acked_serial; WARNING: line length of 81 exceeds 80 columns #1393: FILE: net/rxrpc/input.c:1185: + if (call->tlp_serial && after_eq(summary.acked_serial, call->tlp_serial)) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #1399: new file mode 100644 WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #1404: FILE: net/rxrpc/input_rack.c:1: +/* RACK-TLP [RFC8958] Implementation WARNING: line length of 81 exceeds 80 columns #1445: FILE: net/rxrpc/input_rack.c:42: +static ktime_t rxrpc_get_xmit_ts(const struct rxrpc_txqueue *tq, unsigned int ix) WARNING: line length of 90 exceeds 80 columns #1500: FILE: net/rxrpc/input_rack.c:97: + if (rxrpc_rack_sent_after(xmit_ts, seq, call->rack_xmit_ts, call->rack_end_seq)) { WARNING: line length of 81 exceeds 80 columns #1567: FILE: net/rxrpc/input_rack.c:164: + rxrpc_seq_t snd_nxt = call->tx_transmitted + 1; /* Next seq to be sent */ WARNING: line length of 89 exceeds 80 columns #1597: FILE: net/rxrpc/input_rack.c:194: + return us_to_ktime(umin(call->rack_reo_wnd_mult * minmax_get(&call->min_rtt) / 4, WARNING: line length of 89 exceeds 80 columns #1632: FILE: net/rxrpc/input_rack.c:229: + if (rxrpc_rack_sent_after(call->rack_xmit_ts, call->rack_end_seq, WARNING: line length of 91 exceeds 80 columns #1634: FILE: net/rxrpc/input_rack.c:231: + remaining = ktime_sub(ktime_add(xmit_ts, lost_after), now); WARNING: line length of 89 exceeds 80 columns #1637: FILE: net/rxrpc/input_rack.c:234: + trace_rxrpc_rack_detect_loss(call, summary, seq); WARNING: line length of 81 exceeds 80 columns #1660: FILE: net/rxrpc/input_rack.c:257: + trace_rxrpc_timer_set(call, timeout, rxrpc_timer_trace_rack_reo); WARNING: line length of 85 exceeds 80 columns #1739: FILE: net/rxrpc/input_rack.c:336: + rxrpc_transmit_some_data(call, 1, rxrpc_txdata_tlp_new_data); WARNING: line length of 88 exceeds 80 columns #1742: FILE: net/rxrpc/input_rack.c:339: + trace_rxrpc_tlp_probe(call, rxrpc_tlp_probe_trace_transmit_new); WARNING: line length of 86 exceeds 80 columns #1749: FILE: net/rxrpc/input_rack.c:346: + trace_rxrpc_tlp_probe(call, rxrpc_tlp_probe_trace_retransmit); WARNING: line length of 86 exceeds 80 columns #1768: FILE: net/rxrpc/input_rack.c:365: +void rxrpc_tlp_process_ack(struct rxrpc_call *call, struct rxrpc_ack_summary *summary) WARNING: line length of 81 exceeds 80 columns #1775: FILE: net/rxrpc/input_rack.c:372: + trace_rxrpc_tlp_ack(call, summary, rxrpc_tlp_ack_trace_new_data); WARNING: line length of 82 exceeds 80 columns #1780: FILE: net/rxrpc/input_rack.c:377: + trace_rxrpc_tlp_ack(call, summary, rxrpc_tlp_ack_trace_dup_acked); WARNING: line length of 84 exceeds 80 columns #1784: FILE: net/rxrpc/input_rack.c:381: + trace_rxrpc_tlp_ack(call, summary, rxrpc_tlp_ack_trace_hard_beyond); WARNING: line length of 83 exceeds 80 columns #1795: FILE: net/rxrpc/input_rack.c:392: + trace_rxrpc_tlp_ack(call, summary, rxrpc_tlp_ack_trace_incomplete); WARNING: line length of 81 exceeds 80 columns #1834: FILE: net/rxrpc/io_thread.c:473: + trace_rxrpc_iothread_rx(local, skb_queue_len(&rx_queue)); WARNING: Block comments use a trailing */ on a separate line #1892: FILE: net/rxrpc/output.c:602: + * to elicit a response. */ WARNING: line length of 81 exceeds 80 columns #1901: FILE: net/rxrpc/output.c:609: + trace_rxrpc_timer_set(call, pto, rxrpc_timer_trace_rack_tlp_pto); total: 3 errors, 59 warnings, 23 checks, 1777 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7c30f501ddf3 ("rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.