ERROR: Macros with complex values should be enclosed in parentheses #62: FILE: include/trace/events/rxrpc.h:484: +#define rxrpc_tq_traces \ + EM(rxrpc_tq_alloc, "ALLOC") \ + EM(rxrpc_tq_cleaned, "CLEAN") \ + EM(rxrpc_tq_decant, "DCNT ") \ + EM(rxrpc_tq_decant_advance, "DCNT>") \ + EM(rxrpc_tq_queue, "QUEUE") \ + EM(rxrpc_tq_queue_dup, "QUE!!") \ + EM(rxrpc_tq_rotate, "ROT ") \ + EM(rxrpc_tq_rotate_and_free, "ROT-F") \ + EM(rxrpc_tq_rotate_and_keep, "ROT-K") \ + EM(rxrpc_tq_transmit, "XMIT ") \ + E_(rxrpc_tq_transmit_advance, "XMIT>") CHECK: Lines should not end with a '(' #154: FILE: include/trace/events/rxrpc.h:969: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #161: FILE: include/trace/events/rxrpc.h:976: + TP_fast_assign( CHECK: Lines should not end with a '(' #226: FILE: include/trace/events/rxrpc.h:2074: + TP_STRUCT__entry( CHECK: Lines should not end with a '(' #233: FILE: include/trace/events/rxrpc.h:2081: + TP_fast_assign( WARNING: line length of 88 exceeds 80 columns #267: FILE: net/rxrpc/ar-internal.h:696: + rxrpc_seq_t send_top; /* Highest Tx slot filled by sendmsg. */ WARNING: line length of 88 exceeds 80 columns #268: FILE: net/rxrpc/ar-internal.h:697: + struct rxrpc_txqueue *send_queue; /* Queue that sendmsg is writing into */ WARNING: line length of 83 exceeds 80 columns #274: FILE: net/rxrpc/ar-internal.h:701: + struct rxrpc_txqueue *tx_queue; /* Start of transmission buffers */ WARNING: line length of 81 exceeds 80 columns #275: FILE: net/rxrpc/ar-internal.h:702: + struct rxrpc_txqueue *tx_qtail; /* End of transmission buffers */ WARNING: line length of 89 exceeds 80 columns #321: FILE: net/rxrpc/ar-internal.h:878: + struct rxrpc_txqueue *tq; /* Tx queue segment holding first DATA */ WARNING: line length of 95 exceeds 80 columns #323: FILE: net/rxrpc/ar-internal.h:880: + int n; /* Number of DATA packets to glue into jumbo */ WARNING: line length of 86 exceeds 80 columns #342: FILE: net/rxrpc/ar-internal.h:1225: +void rxrpc_send_data_packet(struct rxrpc_call *call, struct rxrpc_send_data_req *req); WARNING: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'. #370: FILE: net/rxrpc/call_event.c:77: + _enter("%x,%x,%x,%px", tq->qbase, req->seq, ix, txb); WARNING: line length of 93 exceeds 80 columns #457: FILE: net/rxrpc/call_event.c:140: + resend_at = ktime_add_us(tq->xmit_ts_base, tq->segment_xmit_ts[qix]); WARNING: line length of 85 exceeds 80 columns #513: FILE: net/rxrpc/call_event.c:181: + resend_at = ktime_add_us(tq->xmit_ts_base, tq->segment_xmit_ts[qix]); WARNING: line length of 87 exceeds 80 columns #630: FILE: net/rxrpc/call_event.c:319: + trace_rxrpc_tq(call, tq, seq, rxrpc_tq_decant_advance); WARNING: line length of 86 exceeds 80 columns #720: FILE: net/rxrpc/call_object.c:543: + rxrpc_put_txbuf(tq->bufs[i], rxrpc_txbuf_put_cleaned); WARNING: line length of 90 exceeds 80 columns #795: FILE: net/rxrpc/input.c:240: + _debug("tq=%x seq=%x i=%d f=%x", tq->qbase, seq, ix, tq->bufs[ix]->flags); WARNING: memory barrier without comment #806: FILE: net/rxrpc/input.c:248: + smp_store_release(&call->tx_bottom, seq); WARNING: memory barrier without comment #807: FILE: net/rxrpc/input.c:249: + smp_store_release(&call->acks_hard_ack, seq); WARNING: line length of 88 exceeds 80 columns #819: FILE: net/rxrpc/input.c:260: + trace_rxrpc_tq(call, tq, seq, rxrpc_tq_rotate_and_free); WARNING: line length of 88 exceeds 80 columns #823: FILE: net/rxrpc/input.c:264: + trace_rxrpc_tq(call, tq, seq, rxrpc_tq_rotate_and_keep); WARNING: line length of 81 exceeds 80 columns #916: FILE: net/rxrpc/output.c:438: + rxrpc_begin_rtt_probe(call, serial, req->now, rxrpc_rtt_tx_data); WARNING: line length of 97 exceeds 80 columns #951: FILE: net/rxrpc/output.c:487: +static size_t rxrpc_prepare_data_packet(struct rxrpc_call *call, struct rxrpc_send_data_req *req) WARNING: line length of 81 exceeds 80 columns #996: FILE: net/rxrpc/output.c:518: + trace_rxrpc_tq(call, tq, seq, rxrpc_tq_transmit_advance); WARNING: line length of 85 exceeds 80 columns #1026: FILE: net/rxrpc/output.c:544: +void rxrpc_send_data_packet(struct rxrpc_call *call, struct rxrpc_send_data_req *req) WARNING: else is not generally useful after a break or return #1221: FILE: net/rxrpc/sendmsg.c:299: + return -ENOMEM; + } else { WARNING: line length of 92 exceeds 80 columns #1241: FILE: net/rxrpc/sendmsg.c:386: + if (!call->send_queue || !((call->send_top + 1) & RXRPC_TXQ_MASK)) { total: 1 errors, 23 warnings, 4 checks, 1131 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f6b0afb79d74 ("rxrpc: Implement progressive transmission queue struct") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.