========== checkpatch - FAILED WARNING: line length of 86 exceeds 80 columns #138: FILE: drivers/net/ethernet/intel/ice/ice_main.c:6164: + struct net_device *dev, const unsigned char *addr, u16 vid, u16 inner_vid, WARNING: line length of 83 exceeds 80 columns #154: FILE: drivers/net/ethernet/intel/ice/ice_main.c:6206: + __always_unused u16 vid, __always_unused u16 inner_vid, bool *notified, WARNING: line length of 81 exceeds 80 columns #268: FILE: drivers/net/ethernet/mscc/ocelot_net.c:733: + u16 vid, u16 inner_vid, u16 flags, bool *notified, WARNING: line length of 81 exceeds 80 columns #277: FILE: drivers/net/ethernet/mscc/ocelot_net.c:746: + const unsigned char *addr, u16 vid, u16 inner_vid, WARNING: line length of 90 exceeds 80 columns #290: FILE: drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:370: + const unsigned char *addr, u16 vid, u16 inner_vid, bool *notified, WARNING: line length of 85 exceeds 80 columns #307: FILE: drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:396: + const unsigned char *addr, u16 vid, u16 inner_vid, u16 flags, WARNING: line length of 86 exceeds 80 columns #315: FILE: drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c:403: + return ndo_dflt_fdb_add(ndm, tb, netdev, addr, vid, inner_vid, flags); WARNING: line length of 93 exceeds 80 columns #337: FILE: drivers/net/macvlan.c:1052: + const unsigned char *addr, u16 vid, u16 inner_vid, bool *notified, WARNING: line length of 86 exceeds 80 columns #350: FILE: drivers/net/vxlan/vxlan_core.c:1243: + const unsigned char *addr, u16 vid, u16 inner_vid, u16 flags, WARNING: line length of 94 exceeds 80 columns #359: FILE: drivers/net/vxlan/vxlan_core.c:1322: + const unsigned char *addr, u16 vid, u16 inner_vid, bool *notified, WARNING: line length of 91 exceeds 80 columns #421: FILE: include/linux/netdevice.h:1554: + u16 vid, u16 inner_vid, u32 portid, u32 seq, WARNING: line length of 83 exceeds 80 columns #454: FILE: include/trace/events/bridge.h:15: + const unsigned char *addr, u16 vid, u16 inner_vid, u16 nlh_flags), WARNING: line length of 89 exceeds 80 columns #491: FILE: include/trace/events/bridge.h:100: + const unsigned char *addr, u16 vid, u16 inner_vid, unsigned long flags), WARNING: line length of 87 exceeds 80 columns #518: FILE: include/trace/events/bridge.h:125: + __entry->addr[4], __entry->addr[5], __entry->vid, __entry->inner_vid, WARNING: line length of 93 exceeds 80 columns #573: FILE: net/bridge/br_arp_nd_proxy.c:400: + u16 vid, u16 inner_vid, struct net_bridge_port *p, struct nd_msg *msg) WARNING: line length of 81 exceeds 80 columns #603: FILE: net/bridge/br_device.c:67: + if (!br_allowed_ingress(br, br_vlan_group_rcu(br), skb, &vid, &inner_vid, WARNING: line length of 86 exceeds 80 columns #621: FILE: net/bridge/br_device.c:86: + br_do_suppress_nd(skb, br, vid, inner_vid, NULL, msg); ERROR: do not use assignment in if condition #630: FILE: net/bridge/br_device.c:108: + } else if ((dst = br_fdb_find_rcu(br, dest, vid, inner_vid)) != NULL) { WARNING: line length of 99 exceeds 80 columns #816: FILE: net/bridge/br_fdb.c:761: + desc.port_ifindex, desc.vlan_id, desc.inner_vlan_id, desc.flags, desc.flags_mask); WARNING: line length of 90 exceeds 80 columns #834: FILE: net/bridge/br_fdb.c:897: + const unsigned char *addr, u16 vid, u16 inner_vid, unsigned long flags) WARNING: line length of 81 exceeds 80 columns #851: FILE: net/bridge/br_fdb.c:911: + source->dev->name, addr, vid, inner_vid); WARNING: line length of 93 exceeds 80 columns #860: FILE: net/bridge/br_fdb.c:946: + trace_br_fdb_update(br, source, addr, vid, inner_vid, flags); WARNING: line length of 85 exceeds 80 columns #870: FILE: net/bridge/br_fdb.c:954: + trace_br_fdb_update(br, source, addr, vid, inner_vid, flags); WARNING: line length of 94 exceeds 80 columns #897: FILE: net/bridge/br_fdb.c:1069: + const u8 *addr, struct ndmsg *ndm, u16 flags, u16 vid, u16 inner_vid, WARNING: line length of 88 exceeds 80 columns #921: FILE: net/bridge/br_fdb.c:1167: + u16 nlh_flags, u16 vid, u16 inner_vid, struct nlattr *nfea_tb[], WARNING: line length of 86 exceeds 80 columns #930: FILE: net/bridge/br_fdb.c:1183: + br_fdb_update(br, p, addr, vid, inner_vid, BIT(BR_FDB_ADDED_BY_USER)); WARNING: line length of 90 exceeds 80 columns #939: FILE: net/bridge/br_fdb.c:1195: + err = fdb_add_entry(br, p, addr, ndm, nlh_flags, vid, inner_vid, nfea_tb); WARNING: line length of 88 exceeds 80 columns #966: FILE: net/bridge/br_fdb.c:1275: + err = __br_fdb_add(ndm, br, p, addr, nlh_flags, vid, inner_vid, nfea_tb, WARNING: line length of 90 exceeds 80 columns #979: FILE: net/bridge/br_fdb.c:1290: + err = __br_fdb_add(ndm, br, p, addr, nlh_flags, v->vid, inner_vid, WARNING: line length of 96 exceeds 80 columns #988: FILE: net/bridge/br_fdb.c:1303: + const u8 *addr, u16 vlan, u16 inner_vlan, bool *notified) WARNING: line length of 93 exceeds 80 columns #1002: FILE: net/bridge/br_fdb.c:1319: + const unsigned char *addr, u16 vid, u16 inner_vid, bool *notified) WARNING: line length of 81 exceeds 80 columns #1008: FILE: net/bridge/br_fdb.c:1324: + err = fdb_delete_by_addr_and_port(br, p, addr, vid, inner_vid, notified); WARNING: line length of 84 exceeds 80 columns #1017: FILE: net/bridge/br_fdb.c:1333: + const unsigned char *addr, u16 vid, u16 inner_vid, bool *notified, WARNING: line length of 89 exceeds 80 columns #1040: FILE: net/bridge/br_fdb.c:1368: + err &= __br_fdb_delete(br, p, addr, v->vid, inner_vid, notified); WARNING: line length of 84 exceeds 80 columns #1097: FILE: net/bridge/br_input.c:108: + if (!br_allowed_ingress(p->br, nbp_vlan_group_rcu(p), skb, &vid, &inner_vid, WARNING: line length of 84 exceeds 80 columns #1104: FILE: net/bridge/br_input.c:114: + br_fdb_find_rcu(br, eth_hdr(skb)->h_source, vid, inner_vid); WARNING: line length of 82 exceeds 80 columns #1113: FILE: net/bridge/br_input.c:122: + vid, inner_vid, BIT(BR_FDB_LOCKED)); WARNING: line length of 84 exceeds 80 columns #1122: FILE: net/bridge/br_input.c:132: + br_fdb_update(br, p, eth_hdr(skb)->h_source, vid, inner_vid, WARNING: line length of 83 exceeds 80 columns #1149: FILE: net/bridge/br_input.c:179: + br_do_suppress_nd(skb, br, vid, inner_vid, p, msg); WARNING: line length of 83 exceeds 80 columns #1175: FILE: net/bridge/br_input.c:243: + br_fdb_update(p->br, p, eth_hdr(skb)->h_source, vid, inner_vid, 0); WARNING: line length of 91 exceeds 80 columns #1266: FILE: net/bridge/br_private.h:855: + const unsigned char *addr, u16 vid, u16 inner_vid, unsigned long flags); WARNING: line length of 92 exceeds 80 columns #1270: FILE: net/bridge/br_private.h:858: + struct net_device *dev, const unsigned char *addr, u16 vid, u16 inner_vid, WARNING: line length of 86 exceeds 80 columns #1282: FILE: net/bridge/br_private.h:868: + const unsigned char *addr, u16 vid, u16 inner_vid, u32 portid, u32 seq, WARNING: line length of 95 exceeds 80 columns #1296: FILE: net/bridge/br_private.h:1542: +bool br_should_learn(struct net_bridge_port *p, struct sk_buff *skb, u16 *vid, u16 *inner_vid); WARNING: line length of 81 exceeds 80 columns #1314: FILE: net/bridge/br_private.h:1666: + struct sk_buff *skb, u16 *vid, u16 *inner_vid) WARNING: line length of 81 exceeds 80 columns #1323: FILE: net/bridge/br_private.h:2293: + u16 vid, u16 inner_vid, struct net_bridge_port *p); WARNING: line length of 94 exceeds 80 columns #1326: FILE: net/bridge/br_private.h:2295: + u16 vid, u16 inner_vid, struct net_bridge_port *p, struct nd_msg *msg); WARNING: line length of 94 exceeds 80 columns #1392: FILE: net/bridge/br_vlan.c:691: +bool br_should_learn(struct net_bridge_port *p, struct sk_buff *skb, u16 *vid, u16 *inner_vid) WARNING: line length of 86 exceeds 80 columns #1438: FILE: net/core/rtnetlink.c:4406: + u8 *addr, u16 vid, u16 inner_vid, u32 pid, u32 seq, WARNING: line length of 95 exceeds 80 columns #1458: FILE: net/core/rtnetlink.c:4452: +static void rtnl_fdb_notify(struct net_device *dev, u8 *addr, u16 vid, u16 inner_vid, int type, WARNING: line length of 82 exceeds 80 columns #1528: FILE: net/core/rtnetlink.c:4615: + err = ndo_dflt_fdb_add(ndm, tb, dev, addr, vid, inner_vid, WARNING: line length of 90 exceeds 80 columns #1571: FILE: net/core/rtnetlink.c:4727: + err = ops->ndo_fdb_del(ndm, tb, dev, addr, vid, inner_vid, WARNING: line length of 90 exceeds 80 columns #1580: FILE: net/core/rtnetlink.c:4747: + err = ops->ndo_fdb_del(ndm, tb, dev, addr, vid, inner_vid, WARNING: line length of 91 exceeds 80 columns #1584: FILE: net/core/rtnetlink.c:4750: + err = ndo_dflt_fdb_del(ndm, tb, dev, addr, vid, inner_vid); WARNING: line length of 88 exceeds 80 columns #1593: FILE: net/core/rtnetlink.c:4760: + rtnl_fdb_notify(dev, addr, vid, inner_vid, RTM_DELNEIGH, WARNING: line length of 89 exceeds 80 columns #1611: FILE: net/core/rtnetlink.c:5023: + u16 *vid, u16 *inner_vid, struct netlink_ext_ack *extack) WARNING: line length of 81 exceeds 80 columns #1636: FILE: net/core/rtnetlink.c:5105: + &brport_idx, &addr, &vid, &inner_vid, extack); total: 1 errors, 56 warnings, 0 checks, 1306 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 708dd25cb0da ("bridge: Make the FDB consider inner tag for Q-in-Q") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.