WARNING: 'unecessary' may be misspelled - perhaps 'unnecessary'? #18: cumbersome and is unecessary. ^^^^^^^^^^ WARNING: 'unitialized' may be misspelled - perhaps 'uninitialized'? #35: The logic to detect initialized and unitialized irq flag slots, marking ^^^^^^^^^^^ WARNING: 'unsinged' may be misspelled - perhaps 'unsigned'? #95: FILE: kernel/bpf/helpers.c:3060: +/* Keep unsinged long in prototype so that kfunc is usable when emitted to ^^^^^^^^ WARNING: line length of 84 exceeds 80 columns #142: FILE: kernel/bpf/verifier.c:664: +static int irq_flag_get_spi(struct bpf_verifier_env *env, struct bpf_reg_state *reg) CHECK: Alignment should match open parenthesis #158: FILE: kernel/bpf/verifier.c:1168: +static int mark_stack_slot_irq_flag(struct bpf_verifier_env *env, + struct bpf_kfunc_call_arg_meta *meta, WARNING: line length of 94 exceeds 80 columns #189: FILE: kernel/bpf/verifier.c:1199: +static int unmark_stack_slot_irq_flag(struct bpf_verifier_env *env, struct bpf_reg_state *reg) WARNING: line length of 85 exceeds 80 columns #212: FILE: kernel/bpf/verifier.c:1222: + /* see unmark_stack_slots_dynptr() for why we need to set REG_LIVE_WRITTEN */ WARNING: line length of 97 exceeds 80 columns #222: FILE: kernel/bpf/verifier.c:1232: +static bool is_irq_flag_reg_valid_uninit(struct bpf_verifier_env *env, struct bpf_reg_state *reg) WARNING: line length of 94 exceeds 80 columns #246: FILE: kernel/bpf/verifier.c:1256: +static int is_irq_flag_reg_valid_init(struct bpf_verifier_env *env, struct bpf_reg_state *reg) WARNING: else is not generally useful after a break or return #333: FILE: kernel/bpf/verifier.c:1575: + return 0; + } else { WARNING: line length of 86 exceeds 80 columns #356: FILE: kernel/bpf/verifier.c:3398: +static int mark_irq_flag_read(struct bpf_verifier_env *env, struct bpf_reg_state *reg) WARNING: line length of 98 exceeds 80 columns #374: FILE: kernel/bpf/verifier.c:10185: + verbose(env, "global function calls are not allowed with IRQs disabled,\n" WARNING: line length of 96 exceeds 80 columns #387: FILE: kernel/bpf/verifier.c:10715: + verbose(env, "%s cannot be used inside bpf_local_irq_save-ed region\n", prefix); WARNING: line length of 87 exceeds 80 columns #400: FILE: kernel/bpf/verifier.c:10925: + verbose(env, "sleepable helper %s#%d in IRQ-disabled region\n", WARNING: line length of 84 exceeds 80 columns #406: FILE: kernel/bpf/verifier.c:10931: + env->insn_aux_data[insn_idx].storage_get_func_atomic = true; WARNING: line length of 85 exceeds 80 columns #416: FILE: kernel/bpf/verifier.c:11495: +static bool is_kfunc_arg_irq_flag(const struct btf *btf, const struct btf_param *arg) CHECK: Alignment should match open parenthesis #465: FILE: kernel/bpf/verifier.c:11952: +static int process_irq_flag(struct bpf_verifier_env *env, int regno, + struct bpf_kfunc_call_arg_meta *meta) WARNING: line length of 83 exceeds 80 columns #473: FILE: kernel/bpf/verifier.c:11960: + } else if (meta->func_id == special_kfunc_list[KF_bpf_local_irq_restore]) { WARNING: line length of 83 exceeds 80 columns #476: FILE: kernel/bpf/verifier.c:11963: + verbose(env, "verifier internal error: unknown irq flags kfunc\n"); WARNING: line length of 91 exceeds 80 columns #482: FILE: kernel/bpf/verifier.c:11969: + verbose(env, "expected uninitialized irq flag as arg#%d\n", regno); WARNING: line length of 106 exceeds 80 columns #486: FILE: kernel/bpf/verifier.c:11973: + err = check_mem_access(env, env->insn_idx, regno, 0, BPF_DW, BPF_WRITE, -1, false, false); WARNING: line length of 92 exceeds 80 columns #496: FILE: kernel/bpf/verifier.c:11983: + verbose(env, "expected an initialized irq flag as arg#%d\n", regno); CHECK: Please don't use multiple blank lines #511: FILE: kernel/bpf/verifier.c:11998: + + WARNING: line length of 98 exceeds 80 columns #529: FILE: kernel/bpf/verifier.c:12884: + verbose(env, "arg#%d doesn't point to an irq flag on stack\n", i); WARNING: line length of 100 exceeds 80 columns #544: FILE: kernel/bpf/verifier.c:13072: + verbose(env, "kernel func %s is sleepable within IRQ-disabled region\n", func_name); WARNING: line length of 88 exceeds 80 columns #558: FILE: kernel/bpf/verifier.c:18012: + if (!check_ids(old_reg->ref_obj_id, cur_reg->ref_obj_id, idmap)) total: 0 errors, 23 warnings, 3 checks, 483 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 1008482f8d7f ("bpf: Introduce support for bpf_local_irq_{save,restore}") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 23 warnings, 3 checks, 483 lines checked