========== checkpatch - FAILED WARNING: line length of 81 exceeds 80 columns #32: FILE: tools/testing/selftests/bpf/test_progs.h:189: +#define DUMP_BUFFER(name, buf, len) \ CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues #32: FILE: tools/testing/selftests/bpf/test_progs.h:189: +#define DUMP_BUFFER(name, buf, len) \ + ({ \ + fprintf(stdout, "%s:\n", name); \ + for (int i = 0; i < len; i++) { \ + if (i && !(i % 16)) \ + fprintf(stdout, "\n"); \ + if (i && !(i % 8) && (i % 16)) \ + fprintf(stdout, "\t"); \ + fprintf(stdout, "%02X ", ((uint8_t *)(buf))[i]); \ + } \ + fprintf(stdout, "\n"); \ + }) WARNING: line length of 81 exceeds 80 columns #33: FILE: tools/testing/selftests/bpf/test_progs.h:190: + ({ \ WARNING: line length of 81 exceeds 80 columns #34: FILE: tools/testing/selftests/bpf/test_progs.h:191: + fprintf(stdout, "%s:\n", name); \ WARNING: line length of 81 exceeds 80 columns #35: FILE: tools/testing/selftests/bpf/test_progs.h:192: + for (int i = 0; i < len; i++) { \ WARNING: line length of 81 exceeds 80 columns #36: FILE: tools/testing/selftests/bpf/test_progs.h:193: + if (i && !(i % 16)) \ WARNING: line length of 81 exceeds 80 columns #37: FILE: tools/testing/selftests/bpf/test_progs.h:194: + fprintf(stdout, "\n"); \ WARNING: line length of 81 exceeds 80 columns #38: FILE: tools/testing/selftests/bpf/test_progs.h:195: + if (i && !(i % 8) && (i % 16)) \ WARNING: line length of 81 exceeds 80 columns #39: FILE: tools/testing/selftests/bpf/test_progs.h:196: + fprintf(stdout, "\t"); \ WARNING: line length of 81 exceeds 80 columns #40: FILE: tools/testing/selftests/bpf/test_progs.h:197: + fprintf(stdout, "%02X ", ((uint8_t *)(buf))[i]); \ WARNING: line length of 81 exceeds 80 columns #41: FILE: tools/testing/selftests/bpf/test_progs.h:198: + } \ WARNING: line length of 81 exceeds 80 columns #42: FILE: tools/testing/selftests/bpf/test_progs.h:199: + fprintf(stdout, "\n"); \ ERROR: do not initialise statics to 0 #53: FILE: tools/testing/selftests/bpf/test_progs.h:361: + static int duration = 0; \ total: 1 errors, 11 warnings, 1 checks, 37 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit dc82bf60ce43 ("selftests/bpf: add a macro to compare raw memory") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.