========== checkpatch - FAILED WARNING: line length of 92 exceeds 80 columns #59: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:792: +static int uprobe_attach(struct uprobe_multi_consumers *skel, int idx, unsigned long offset) WARNING: line length of 89 exceeds 80 columns #80: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:813: + *link = bpf_program__attach_uprobe_multi(prog, 0, "/proc/self/exe", NULL, &opts); WARNING: line length of 96 exceeds 80 columns #99: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:848: + if (!ASSERT_OK(uprobe_attach(skel, idx, offset), "uprobe_attach_after")) WARNING: line length of 81 exceeds 80 columns #114: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:863: +#define __CONSUMER_TEST(func) \ WARNING: please, no space before tabs #114: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:863: +#define __CONSUMER_TEST(func) ^I^I^I^I^I^I^I\$ WARNING: macros should not use a trailing semicolon #114: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:863: +#define __CONSUMER_TEST(func) \ +noinline int func(struct uprobe_multi_consumers *skel, unsigned long before, \ + unsigned long after, unsigned long offset) \ +{ \ + return uprobe_consumer_test(skel, before, after, offset); \ +} \ +void *__ ## func __used __attribute__((section("consumers"))) = (void *) func; WARNING: line length of 81 exceeds 80 columns #115: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:864: +noinline int func(struct uprobe_multi_consumers *skel, unsigned long before, \ WARNING: line length of 81 exceeds 80 columns #116: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:865: + unsigned long after, unsigned long offset) \ WARNING: line length of 81 exceeds 80 columns #117: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:866: +{ \ WARNING: line length of 81 exceeds 80 columns #118: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:867: + return uprobe_consumer_test(skel, before, after, offset); \ WARNING: line length of 81 exceeds 80 columns #119: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:868: +} \ CHECK: No space is necessary after a cast #120: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:869: +void *__ ## func __used __attribute__((section("consumers"))) = (void *) func; WARNING: Prefer __section("consumers") over __attribute__((section("consumers"))) #120: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:869: +void *__ ## func __used __attribute__((section("consumers"))) = (void *) func; ERROR: Macros with complex values should be enclosed in parentheses #125: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:874: +#define C4 C1 C1 C1 C1 ERROR: Macros with complex values should be enclosed in parentheses #126: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:875: +#define C16 C4 C4 C4 C4 WARNING: line length of 97 exceeds 80 columns #145: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:893: + if (!ASSERT_OK(uprobe_attach(skel, idx, offset), "uprobe_attach_before")) CHECK: No space is necessary after a cast #169: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:976: + unsigned long idx = (unsigned long) arg; CHECK: Please don't use multiple blank lines #196: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:1001: + + WARNING: line length of 84 exceeds 80 columns #214: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:1048: + err = pthread_create(&pt[idx], NULL, consumer_thread, (void *) idx); CHECK: No space is necessary after a cast #214: FILE: tools/testing/selftests/bpf/prog_tests/uprobe_multi_test.c:1048: + err = pthread_create(&pt[idx], NULL, consumer_thread, (void *) idx); total: 2 errors, 14 warnings, 4 checks, 164 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 0218bd9f8d53 ("selftests/bpf: Add threads to consumer test") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.