========== checkpatch - FAILED WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: .../{bpf_testmod.c => bpf_testmod_core.c} | 25 ++ CHECK: Lines should not end with a '(' #94: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1326: +asm ( WARNING: unnecessary whitespace before a quoted newline #95: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1327: +" .pushsection .data, \"a\" \n" WARNING: unnecessary whitespace before a quoted newline #96: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1328: +" .global test_inlinable_kfuncs_data \n" WARNING: unnecessary whitespace before a quoted newline #97: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1329: +"test_inlinable_kfuncs_data: \n" WARNING: unnecessary whitespace before a quoted newline #98: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1330: +" .incbin \"test_inlinable_kfuncs.bpf.linked.o\" \n" WARNING: unnecessary whitespace before a quoted newline #99: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1331: +" .global test_inlinable_kfuncs_data_end \n" WARNING: unnecessary whitespace before a quoted newline #100: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1332: +"test_inlinable_kfuncs_data_end: \n" WARNING: unnecessary whitespace before a quoted newline #101: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1333: +" .popsection \n" WARNING: externs should be avoided in .c files #104: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1336: +extern void test_inlinable_kfuncs_data; WARNING: externs should be avoided in .c files #105: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1337: +extern void test_inlinable_kfuncs_data_end; WARNING: line length of 111 exceeds 80 columns #115: FILE: tools/testing/selftests/bpf/bpf_testmod/bpf_testmod_core.c:1362: + &test_inlinable_kfuncs_data_end - &test_inlinable_kfuncs_data, WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #134: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:1: +#include ERROR: space prohibited before open square bracket '[' #136: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:3: +#define __imm(name) [name]"i"(name) WARNING: externs should be avoided in .c files #138: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:5: +__bpf_kfunc int bpf_test_inline_kfunc1(int p); WARNING: externs should be avoided in .c files #139: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:6: +__bpf_kfunc int bpf_test_inline_kfunc2(int *p); WARNING: externs should be avoided in .c files #140: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:7: +__bpf_kfunc int bpf_test_inline_kfunc3(void *p, u64 p__sz); WARNING: externs should be avoided in .c files #141: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:8: +__bpf_kfunc int bpf_test_inline_kfunc4(void); WARNING: externs should be avoided in .c files #142: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:9: +__bpf_kfunc int bpf_test_inline_kfunc5(struct bpf_dynptr *d); WARNING: externs should be avoided in .c files #143: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:10: +__bpf_kfunc int bpf_test_inline_kfunc6(void); WARNING: externs should be avoided in .c files #144: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:11: +__bpf_kfunc int bpf_test_inline_kfunc7(void); WARNING: externs should be avoided in .c files #145: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:12: +__bpf_kfunc int bpf_test_inline_kfunc8(void); CHECK: Lines should not end with a '(' #151: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:18: + asm volatile ( CHECK: Lines should not end with a '(' #164: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:31: + asm volatile ( CHECK: Lines should not end with a '(' #175: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:42: + asm volatile ( CHECK: Lines should not end with a '(' #186: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:53: + asm volatile ( CHECK: Lines should not end with a '(' #199: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:66: + asm volatile ( CHECK: Lines should not end with a '(' #220: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:87: + asm volatile ( CHECK: Lines should not end with a '(' #232: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:99: + asm volatile ( CHECK: Lines should not end with a '(' #242: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:109: + asm volatile ( WARNING: line length of 82 exceeds 80 columns #253: FILE: tools/testing/selftests/bpf/bpf_testmod/test_inlinable_kfuncs.c:120: +/* Only interested in BPF assembly bodies of these functions, keep dummy bodies */ WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #294: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:1: +#include CHECK: No space is necessary after a cast #304: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:11: +extern int bpf_test_inline_kfunc4(void) __ksym; CHECK: No space is necessary after a cast #306: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:13: +extern int bpf_test_inline_kfunc6(void) __ksym; CHECK: No space is necessary after a cast #307: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:14: +extern int bpf_test_inline_kfunc7(void) __ksym; CHECK: No space is necessary after a cast #308: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:15: +extern int bpf_test_inline_kfunc8(void) __ksym; WARNING: line length of 82 exceeds 80 columns #321: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:28: +/* check that dead code elimination took place independently for both callsites */ CHECK: Lines should not end with a '(' #334: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:41: + asm volatile ( CHECK: Lines should not end with a '(' #355: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:62: + asm volatile ( CHECK: Lines should not end with a '(' #377: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:84: + asm volatile ( CHECK: Lines should not end with a '(' #406: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:113: + asm volatile ( CHECK: Lines should not end with a '(' #431: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:138: + asm volatile ( CHECK: Lines should not end with a '(' #448: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:155: + asm volatile ( CHECK: Lines should not end with a '(' #463: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:170: + asm volatile ( CHECK: Lines should not end with a '(' #484: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:191: + asm volatile ( CHECK: Lines should not end with a '(' #514: FILE: tools/testing/selftests/bpf/progs/verifier_inlinable_kfuncs.c:221: + asm volatile ( total: 1 errors, 23 warnings, 22 checks, 483 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7847311301e7 ("selftests/bpf: tests to verify handling of inlined kfuncs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.