========== checkpatch - FAILED WARNING: line length of 87 exceeds 80 columns #61: FILE: include/linux/bpf_verifier.h:563: + /* for kfunc calls, instance of the inlinable kfunc instance subprog */ WARNING: line length of 91 exceeds 80 columns #70: FILE: include/linux/bpf_verifier.h:727: + u32 first_kfunc_instance; /* first inlinable kfunc instance subprog number */ WARNING: line length of 90 exceeds 80 columns #71: FILE: include/linux/bpf_verifier.h:728: + u32 last_kfunc_instance; /* last inlinable kfunc instance subprog number */ WARNING: line length of 116 exceeds 80 columns #119: FILE: kernel/bpf/verifier.c:3929: + is_inlinable_kfunc_call(env, idx) && subseq_idx == inlinable_kfunc_instance_start(env, idx); WARNING: line length of 89 exceeds 80 columns #129: FILE: kernel/bpf/verifier.c:3935: + subprog = env->insn_aux_data[idx].kfunc_instance_subprog; WARNING: line length of 87 exceeds 80 columns #145: FILE: kernel/bpf/verifier.c:3965: + verbose(env, "BUG regs %x\n", bt_reg_mask(bt)); WARNING: line length of 94 exceeds 80 columns #149: FILE: kernel/bpf/verifier.c:3969: + /* do not backtrack to the callsite, clear any precision marks WARNING: line length of 100 exceeds 80 columns #150: FILE: kernel/bpf/verifier.c:3970: + * that might be present in the fake frame (e.g. dynptr type spill). WARNING: line length of 81 exceeds 80 columns #161: FILE: kernel/bpf/verifier.c:12565: +/* Establish an independent call stack for inlinable kfunc instance verification, WARNING: line length of 99 exceeds 80 columns #177: FILE: kernel/bpf/verifier.c:12581: +static int push_inlinable_kfunc(struct bpf_verifier_env *env, struct bpf_kfunc_call_arg_meta *meta, CHECK: Alignment should match open parenthesis #178: FILE: kernel/bpf/verifier.c:12582: +static int push_inlinable_kfunc(struct bpf_verifier_env *env, struct bpf_kfunc_call_arg_meta *meta, + u32 subprog) WARNING: line length of 92 exceeds 80 columns #225: FILE: kernel/bpf/verifier.c:12629: + verbose(env, "BUG: can't recognize dynptr param\n"); WARNING: line length of 90 exceeds 80 columns #228: FILE: kernel/bpf/verifier.c:12632: + type = func(env, reg)->stack[spi].spilled_ptr.dynptr.type; WARNING: line length of 91 exceeds 80 columns #232: FILE: kernel/bpf/verifier.c:12636: + grow_stack_state(env, st->frame[0], (fake_spi + 2) * BPF_REG_SIZE); WARNING: line length of 92 exceeds 80 columns #236: FILE: kernel/bpf/verifier.c:12640: + /* Setup bpf_dynptr_kern->size as expected by bpf_dynptr_get_type(). WARNING: line length of 88 exceeds 80 columns #237: FILE: kernel/bpf/verifier.c:12641: + * Exact value of the dynptr type could be recovered by verifier WARNING: line length of 90 exceeds 80 columns #238: FILE: kernel/bpf/verifier.c:12642: + * when BPF code generated for bpf_dynptr_get_type() is processed. WARNING: line length of 91 exceeds 80 columns #242: FILE: kernel/bpf/verifier.c:12646: + c = tnum_lshift(tnum_unknown, 31); /* read-only bit */ WARNING: line length of 88 exceeds 80 columns #245: FILE: kernel/bpf/verifier.c:12649: + save_register_state(env, st->frame[0], fake_spi++, fake_reg, 4); WARNING: line length of 99 exceeds 80 columns #249: FILE: kernel/bpf/verifier.c:12653: + save_register_state(env, st->frame[0], fake_spi++, fake_reg, BPF_REG_SIZE); ERROR: space prohibited after that '-' (ctx:BxW) #252: FILE: kernel/bpf/verifier.c:12656: + sh_reg->var_off = tnum_const(- fake_spi * BPF_REG_SIZE); ^ WARNING: line length of 89 exceeds 80 columns #317: FILE: kernel/bpf/verifier.c:12780: + err = push_inlinable_kfunc(env, &meta, insn_aux->kfunc_instance_subprog); ERROR: code indent should use tabs where possible #321: FILE: kernel/bpf/verifier.c:12784: + * propagate precision from within inlinable kfunc$ ERROR: code indent should use tabs where possible #322: FILE: kernel/bpf/verifier.c:12785: + * instance body. As push_inlinable_kfunc() passes$ ERROR: code indent should use tabs where possible #323: FILE: kernel/bpf/verifier.c:12786: + * scalar parameters as-is any such parameter might be$ ERROR: code indent should use tabs where possible #324: FILE: kernel/bpf/verifier.c:12787: + * used in the precise context. Conservatively mark$ ERROR: code indent should use tabs where possible #325: FILE: kernel/bpf/verifier.c:12788: + * these parameters as precise.$ WARNING: line length of 98 exceeds 80 columns #349: FILE: kernel/bpf/verifier.c:16439: + /* visit inlinable kfunc instance bodies to establish prune point marks */ WARNING: line length of 96 exceeds 80 columns #350: FILE: kernel/bpf/verifier.c:16440: + ret = push_insn(t, inlinable_kfunc_instance_start(env, t), BRANCH, env); WARNING: line length of 95 exceeds 80 columns #373: FILE: kernel/bpf/verifier.c:18905: + state->frame[state->curframe]->callsite != BPF_MAIN_FUNC) { WARNING: line length of 105 exceeds 80 columns #382: FILE: kernel/bpf/verifier.c:21228: + int insn_idx, int *cnt, s32 stack_base, u16 *stack_depth_extra, WARNING: line length of 92 exceeds 80 columns #420: FILE: kernel/bpf/verifier.c:21274: + memcpy(insn_buf + extra_slots, subprog_insns, subprog_insn_cnt * sizeof(*insn_buf)); WARNING: line length of 97 exceeds 80 columns #484: FILE: kernel/bpf/verifier.c:21387: + err = verifier_remove_insns(env, subprogs[env->first_kfunc_instance].start, cnt); WARNING: line length of 86 exceeds 80 columns #532: FILE: kernel/bpf/verifier.c:21506: + err = add_kfunc_call(env, sh->insns[j].imm, sh->insns[j].off); WARNING: line length of 90 exceeds 80 columns #537: FILE: kernel/bpf/verifier.c:21511: + insn_buf = kmalloc_array(sh->insn_num + 1, sizeof(*insn_buf), GFP_KERNEL); WARNING: line length of 83 exceeds 80 columns #542: FILE: kernel/bpf/verifier.c:21516: + memcpy(insn_buf + 1, sh->insns, sh->insn_num * sizeof(*insn_buf)); WARNING: line length of 88 exceeds 80 columns #552: FILE: kernel/bpf/verifier.c:21526: + memset(&aux->func_info[aux->func_info_cnt], 0, sizeof(*aux->func_info)); WARNING: line length of 95 exceeds 80 columns #553: FILE: kernel/bpf/verifier.c:21527: + aux->func_info[aux->func_info_cnt].insn_off = env->subprog_info[subprog].start; WARNING: line length of 96 exceeds 80 columns #559: FILE: kernel/bpf/verifier.c:21533: + memset(&aux->func_info_aux[aux->func_info_cnt], 0, sizeof(*aux->func_info_aux)); WARNING: line length of 81 exceeds 80 columns #560: FILE: kernel/bpf/verifier.c:21534: + aux->func_info_aux[aux->func_info_cnt].linkage = BTF_FUNC_STATIC; CHECK: Alignment should match open parenthesis #601: FILE: kernel/bpf/verifier.c:23520: + env->explored_states = kvcalloc(state_htab_size(env), + sizeof(struct bpf_verifier_state_list *), total: 6 errors, 33 warnings, 2 checks, 525 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. NOTE: Whitespace errors detected. You may wish to use scripts/cleanpatch or scripts/cleanfile Commit be0f932cf65e ("bpf: instantiate inlinable kfuncs before verification") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.