WARNING: line length of 84 exceeds 80 columns #47: FILE: tools/testing/selftests/bpf/progs/crib_common.h:21: +extern struct file *bpf_fget_task(struct task_struct *task, unsigned int fd) __ksym; CHECK: extern prototypes should be avoided in .h files #47: FILE: tools/testing/selftests/bpf/progs/crib_common.h:21: +extern struct file *bpf_fget_task(struct task_struct *task, unsigned int fd) __ksym; CHECK: extern prototypes should be avoided in .h files #48: FILE: tools/testing/selftests/bpf/progs/crib_common.h:22: +extern unsigned int bpf_get_file_ops_type(struct file *file) __ksym; CHECK: extern prototypes should be avoided in .h files #49: FILE: tools/testing/selftests/bpf/progs/crib_common.h:23: +extern void bpf_put_file(struct file *file) __ksym; CHECK: Comparison to NULL could be written "!task" #98: FILE: tools/testing/selftests/bpf/progs/crib_files_success.c:82: + if (task == NULL) { CHECK: Comparison to NULL could be written "!file" #104: FILE: tools/testing/selftests/bpf/progs/crib_files_success.c:88: + if (file == NULL) { CHECK: Comparison to NULL could be written "!file" #112: FILE: tools/testing/selftests/bpf/progs/crib_files_success.c:96: + if (file == NULL) { CHECK: Comparison to NULL could be written "!file" #120: FILE: tools/testing/selftests/bpf/progs/crib_files_success.c:104: + if (file == NULL) { CHECK: Comparison to NULL could be written "file" #128: FILE: tools/testing/selftests/bpf/progs/crib_files_success.c:112: + if (file != NULL) { total: 0 errors, 1 warnings, 8 checks, 89 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5c8569bc6e05 ("selftests/bpf: Add tests for struct file related CRIB kfuncs") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 8 checks, 89 lines checked