CHECK: Please use a blank line after function/struct/union/enum declarations #76: FILE: include/net/udp.h:316: +} +static inline void udp4_hash4(struct sock *sk) WARNING: line length of 82 exceeds 80 columns #105: FILE: net/ipv4/udp.c:491: +static void udp_rehash4(struct udp_table *udptable, struct sock *sk, u16 newhash4) WARNING: line length of 89 exceeds 80 columns #132: FILE: net/ipv4/udp.c:518: + /* Because SLAB_TYPESAFE_BY_RCU is not used, we don't need to touch sk_refcnt. */ WARNING: line length of 95 exceeds 80 columns #139: FILE: net/ipv4/udp.c:525: + /* if the nulls value we got at the end of this lookup is not the expected one, we must WARNING: line length of 97 exceeds 80 columns #140: FILE: net/ipv4/udp.c:526: + * restart lookup. We probably met an item that was moved to another chain due to rehash. WARNING: line length of 85 exceeds 80 columns #148: FILE: net/ipv4/udp.c:534: +/* In hash4, rehash can also happen in connect(), where hash4_cnt keeps unchanged. */ WARNING: line length of 82 exceeds 80 columns #149: FILE: net/ipv4/udp.c:535: +static void udp_rehash4(struct udp_table *udptable, struct sock *sk, u16 newhash4) WARNING: line length of 91 exceeds 80 columns #164: FILE: net/ipv4/udp.c:550: + hlist_nulls_add_head_rcu(&udp_sk(sk)->udp_lrpa_node, &nhslot4->nulls_head); WARNING: line length of 98 exceeds 80 columns #195: FILE: net/ipv4/udp.c:581: + /* Connected udp socket can re-connect to another remote address, so rehash4 is needed. */ WARNING: line length of 82 exceeds 80 columns #212: FILE: net/ipv4/udp.c:598: + hlist_nulls_add_head_rcu(&udp_sk(sk)->udp_lrpa_node, &hslot4->nulls_head); WARNING: line length of 90 exceeds 80 columns #232: FILE: net/ipv4/udp.c:618: + hash = udp_ehashfn(net, sk->sk_rcv_saddr, sk->sk_num, sk->sk_daddr, sk->sk_dport); WARNING: line length of 95 exceeds 80 columns #246: FILE: net/ipv4/udp.c:640: + result = udp4_lib_lookup4(net, saddr, sport, daddr, hnum, dif, sdif, udptable); total: 0 errors, 11 warnings, 1 checks, 268 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 130088fa30f8 ("ipv4/udp: Add 4-tuple hash for connected socket") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 11 warnings, 1 checks, 268 lines checked