WARNING: line length of 81 exceeds 80 columns #200: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1667: + return ena_com_check_supported_feature_id(ena_dev, ENA_ADMIN_PHC_CONFIG); WARNING: line length of 85 exceeds 80 columns #210: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1677: + phc->virt_addr = dma_alloc_coherent(ena_dev->dmadev, sizeof(*phc->virt_addr), WARNING: line length of 84 exceeds 80 columns #232: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1699: + ret = ena_com_get_feature(ena_dev, &get_feat_resp, ENA_ADMIN_PHC_CONFIG, 0); WARNING: line length of 88 exceeds 80 columns #235: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1702: + "Failed to get PHC feature configuration, error: %d\n", ret); WARNING: line length of 99 exceeds 80 columns #246: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1713: + /* Update PHC doorbell offset according to device value, used to write req_id to PHC bar */ WARNING: line length of 83 exceeds 80 columns #249: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1716: + /* Update PHC expire timeout according to device or default driver value */ WARNING: line length of 82 exceeds 80 columns #254: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1721: + /* Update PHC block timeout according to device or default driver value */ WARNING: line length of 96 exceeds 80 columns #268: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1735: + ret = ena_com_mem_addr_set(ena_dev, &set_feat_cmd.u.phc.output_address, phc->phys_addr); WARNING: line length of 87 exceeds 80 columns #277: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1744: + (struct ena_admin_aq_entry *)&set_feat_cmd, WARNING: line length of 89 exceeds 80 columns #279: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1746: + (struct ena_admin_acq_entry *)&set_feat_resp, WARNING: line length of 90 exceeds 80 columns #283: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1750: + netdev_err(ena_dev->net_device, "Failed to enable PHC, error: %d\n", ret); WARNING: line length of 100 exceeds 80 columns #306: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1773: + dma_free_coherent(ena_dev->dmadev, sizeof(*phc->virt_addr), phc->virt_addr, phc->phys_addr); WARNING: Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst #312: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1779: + volatile struct ena_admin_phc_resp *read_resp = ena_dev->phc.virt_addr; WARNING: line length of 85 exceeds 80 columns #330: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1797: + block_time = ktime_add_us(phc->system_time, phc->block_timeout_usec); WARNING: line length of 97 exceeds 80 columns #338: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1805: + /* PHC is in active state, update statistics according to req_id and timestamp */ CHECK: Unnecessary parentheses around 'read_resp->timestamp == ENA_PHC_TIMESTAMP_ERROR' #339: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1806: + if ((READ_ONCE(read_resp->req_id) != phc->req_id) || + (read_resp->timestamp == ENA_PHC_TIMESTAMP_ERROR)) { WARNING: line length of 100 exceeds 80 columns #341: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1808: + /* Device didn't update req_id during blocking time or timestamp is invalid, WARNING: line length of 93 exceeds 80 columns #346: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1813: + /* Device updated req_id during blocking time with valid timestamp */ WARNING: line length of 94 exceeds 80 columns #356: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1823: + /* We expect the device to return this req_id once the new PHC timestamp is updated */ WARNING: line length of 99 exceeds 80 columns #359: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1826: + /* Initialize PHC shared memory with different req_id value to be able to identify once the WARNING: line length of 98 exceeds 80 columns #370: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1837: + /* Gave up waiting for updated req_id, PHC enters into blocked state until WARNING: line length of 92 exceeds 80 columns #379: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1846: + /* req_id was not updated by the device, check again on next loop */ WARNING: line length of 91 exceeds 80 columns #383: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1850: + /* req_id was updated which indicates that PHC timestamp was updated too */ WARNING: line length of 95 exceeds 80 columns #388: FILE: drivers/net/ethernet/amazon/ena/ena_com.c:1855: + /* Retrieved invalid PHC timestamp, PHC enters into blocked state until WARNING: line length of 98 exceeds 80 columns #452: FILE: drivers/net/ethernet/amazon/ena/ena_com.h:289: + * Max time for valid PHC retrieval, passing this threshold will fail the get time request WARNING: line length of 95 exceeds 80 columns #453: FILE: drivers/net/ethernet/amazon/ena/ena_com.h:290: + * and block new PHC requests for block_timeout_usec in order to prevent floods on busy WARNING: line length of 98 exceeds 80 columns #459: FILE: drivers/net/ethernet/amazon/ena/ena_com.h:296: + * PHC requests block period, blocking starts once PHC request expired in order to prevent WARNING: line length of 86 exceeds 80 columns #460: FILE: drivers/net/ethernet/amazon/ena/ena_com.h:297: + * floods on busy device, any PHC requests during block period will be skipped WARNING: line length of 83 exceeds 80 columns #589: FILE: drivers/net/ethernet/amazon/ena/ena_ethtool.c:164: +#define ENA_STATS_ARRAY_ENA_COM_ADMIN ARRAY_SIZE(ena_stats_ena_com_admin_strings) WARNING: line length of 81 exceeds 80 columns #590: FILE: drivers/net/ethernet/amazon/ena/ena_ethtool.c:165: +#define ENA_STATS_ARRAY_ENA_COM_PHC ARRAY_SIZE(ena_stats_ena_com_phc_strings) WARNING: line length of 83 exceeds 80 columns #624: FILE: drivers/net/ethernet/amazon/ena/ena_ethtool.c:292: + ptr = (u64 *)&adapter->ena_dev->phc.stats + ena_stats->stat_offset; WARNING: line length of 90 exceeds 80 columns #648: FILE: drivers/net/ethernet/amazon/ena/ena_ethtool.c:332: +static int ena_get_ts_info(struct net_device *netdev, struct kernel_ethtool_ts_info *info) WARNING: line length of 86 exceeds 80 columns #664: FILE: drivers/net/ethernet/amazon/ena/ena_ethtool.c:345: + int count = adapter->num_io_queues * (ENA_STATS_ARRAY_TX + ENA_STATS_ARRAY_RX) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #844: new file mode 100644 WARNING: line length of 98 exceeds 80 columns #868: FILE: drivers/net/ethernet/amazon/ena/ena_phc.c:20: +static int ena_phc_feature_enable(struct ptp_clock_info *clock_info, struct ptp_clock_request *rq, WARNING: line length of 87 exceeds 80 columns #874: FILE: drivers/net/ethernet/amazon/ena/ena_phc.c:26: +static int ena_phc_gettimex64(struct ptp_clock_info *clock_info, struct timespec64 *ts, WARNING: line length of 98 exceeds 80 columns #877: FILE: drivers/net/ethernet/amazon/ena/ena_phc.c:29: + struct ena_phc_info *phc_info = container_of(clock_info, struct ena_phc_info, clock_info); WARNING: line length of 93 exceeds 80 columns #969: FILE: drivers/net/ethernet/amazon/ena/ena_phc.c:121: + netdev_err(adapter->netdev, "Failed registering ptp clock, error: %d\n", rc); total: 0 errors, 37 warnings, 1 checks, 1016 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f08ebc6147d9 ("net: ena: Add PHC support in the ENA driver") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 37 warnings, 1 checks, 1016 lines checked