CHECK: Comparison to NULL could be written "!file" #115: FILE: tools/testing/selftests/connector/proc_filter.c:298: + if (file == NULL) { WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #149: new file mode 100644 CHECK: No space is necessary after a cast #192: FILE: tools/testing/selftests/connector/thread.c:39: + unsigned int exit_code = (unsigned int) sig; CHECK: Alignment should match open parenthesis #218: FILE: tools/testing/selftests/connector/thread.c:65: + printf("Child 2 thread id %d, wants to exit with value %d\n", + gettid(), exit_val); CHECK: Comparison to NULL could be written "!data" #234: FILE: tools/testing/selftests/connector/thread.c:81: + if (data == NULL) { CHECK: Comparison to NULL could be written "!file" #240: FILE: tools/testing/selftests/connector/thread.c:87: + if (file == NULL) { CHECK: Alignment should match open parenthesis #248: FILE: tools/testing/selftests/connector/thread.c:95: + ret = sscanf(data, "pid %d tgid %d code %d", + &pid, &tgid, &exit_code); WARNING: line length of 86 exceeds 80 columns #261: FILE: tools/testing/selftests/connector/thread.c:108: + printf("Successful notification of SIGSEGV, tid %d\n", CHECK: Alignment should match open parenthesis #262: FILE: tools/testing/selftests/connector/thread.c:109: + printf("Successful notification of SIGSEGV, tid %d\n", + pid); CHECK: Alignment should match open parenthesis #265: FILE: tools/testing/selftests/connector/thread.c:112: + printf("Failure SIGSEGV tid %d, exit code %d\n", + pid, exit_code); WARNING: line length of 89 exceeds 80 columns #270: FILE: tools/testing/selftests/connector/thread.c:117: + printf("Successful notification of thread exit tid %d\n", CHECK: Alignment should match open parenthesis #271: FILE: tools/testing/selftests/connector/thread.c:118: + printf("Successful notification of thread exit tid %d\n", + pid); WARNING: line length of 84 exceeds 80 columns #273: FILE: tools/testing/selftests/connector/thread.c:120: + printf("Failure thread exit tid %d, exit code %d\n", CHECK: Alignment should match open parenthesis #274: FILE: tools/testing/selftests/connector/thread.c:121: + printf("Failure thread exit tid %d, exit code %d\n", + pid, exit_code); CHECK: Please don't use multiple blank lines #318: FILE: tools/testing/selftests/connector/thread.c:165: + + ERROR: "foo* bar" should be "foo *bar" #330: FILE: tools/testing/selftests/connector/thread.c:177: + char* arr[] = {"proc_filter", "-f", NULL}; WARNING: Missing a blank line after declarations #331: FILE: tools/testing/selftests/connector/thread.c:178: + char* arr[] = {"proc_filter", "-f", NULL}; + execv("./proc_filter", arr); total: 1 errors, 5 warnings, 11 checks, 428 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit f1374d754ea9 ("connector/cn_proc: Selftest for threads") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.