ERROR: do not initialise globals to NULL
#89: FILE: tools/testing/selftests/connector/proc_filter.c:36:
+FILE *file = NULL;

CHECK: Comparison to NULL could be written "!file"
#121: FILE: tools/testing/selftests/connector/proc_filter.c:298:
+	if (file == NULL) {

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#155: 
new file mode 100644

CHECK: No space is necessary after a cast
#205: FILE: tools/testing/selftests/connector/thread.c:46:
+	unsigned int exit_code = (unsigned int) sig;

CHECK: Alignment should match open parenthesis
#231: FILE: tools/testing/selftests/connector/thread.c:72:
+	printf("Child 2 thread id %d, wants to exit with value %d\n",
+			gettid(), exit_val);

CHECK: Comparison to NULL could be written "!data"
#246: FILE: tools/testing/selftests/connector/thread.c:87:
+	if (data == NULL) {

CHECK: Comparison to NULL could be written "!file"
#252: FILE: tools/testing/selftests/connector/thread.c:93:
+	if (file == NULL) {

WARNING: unchecked sscanf return value
#259: FILE: tools/testing/selftests/connector/thread.c:100:
+		sscanf(data, "pid %d tgid %d code %d",
+				&pid, &tgid, &exit_code);

CHECK: Alignment should match open parenthesis
#260: FILE: tools/testing/selftests/connector/thread.c:101:
+		sscanf(data, "pid %d tgid %d code %d",
+				&pid, &tgid, &exit_code);

WARNING: braces {} are not necessary for single statement blocks
#262: FILE: tools/testing/selftests/connector/thread.c:103:
+		if (tgid != getpid()) {
+			continue;
+		}

WARNING: suspect code indent for conditional statements (16, 23)
#266: FILE: tools/testing/selftests/connector/thread.c:107:
+		if (pid == tid1) {
+		       if (exit_code == 11) {

WARNING: Statements should start on a tabstop
#267: FILE: tools/testing/selftests/connector/thread.c:108:
+		       if (exit_code == 11) {

WARNING: suspect code indent for conditional statements (23, 32)
#267: FILE: tools/testing/selftests/connector/thread.c:108:
+		       if (exit_code == 11) {
+				printf("Successful notification of SIGSEGV, tid %d\n",

WARNING: line length of 86 exceeds 80 columns
#268: FILE: tools/testing/selftests/connector/thread.c:109:
+				printf("Successful notification of SIGSEGV, tid %d\n",

CHECK: Alignment should match open parenthesis
#269: FILE: tools/testing/selftests/connector/thread.c:110:
+				printf("Successful notification of SIGSEGV, tid %d\n",
+						pid);

CHECK: Alignment should match open parenthesis
#272: FILE: tools/testing/selftests/connector/thread.c:113:
+				printf("Failure SIGSEGV tid %d, exit code %d\n",
+					       pid, exit_code);

WARNING: line length of 89 exceeds 80 columns
#277: FILE: tools/testing/selftests/connector/thread.c:118:
+				printf("Successful notification of thread exit tid %d\n",

CHECK: Alignment should match open parenthesis
#278: FILE: tools/testing/selftests/connector/thread.c:119:
+				printf("Successful notification of thread exit tid %d\n",
+						pid);

WARNING: line length of 84 exceeds 80 columns
#280: FILE: tools/testing/selftests/connector/thread.c:121:
+				printf("Failure thread exit tid %d, exit code %d\n",

CHECK: Alignment should match open parenthesis
#281: FILE: tools/testing/selftests/connector/thread.c:122:
+				printf("Failure thread exit tid %d, exit code %d\n",
+					       pid, exit_code);

total: 1 errors, 9 warnings, 10 checks, 398 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 4edcdec310cc ("connector/cn_proc: Selftest for threads") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.