CHECK: Alignment should match open parenthesis #44: FILE: drivers/connector/cn_hash.c:174: +int cn_hash_display_hlist(struct cn_hash_dev *hdev, pid_t pid, int max_len, + int *hkey, int *key_display) CHECK: Alignment should match open parenthesis #54: FILE: drivers/connector/cn_hash.c:184: + hlist_for_each_entry(hnode, + &hdev->uexit_pid_htable[key], CHECK: Comparison to NULL could be written "!hnode->uexit_pid_hlist.next" #57: FILE: drivers/connector/cn_hash.c:187: + if (hnode->uexit_pid_hlist.next == NULL) CHECK: Unnecessary parentheses around 'key_display[key] != 1' #67: FILE: drivers/connector/cn_hash.c:197: + if ((key_display[key] != 1) && !count) CHECK: Alignment should match open parenthesis #76: FILE: drivers/connector/cn_hash.c:206: + pr_err("%d entries in hlist for key %d, expected %d\n", + count, key, max_len); CHECK: Alignment should match open parenthesis #119: FILE: include/linux/connector.h:173: +int cn_hash_display_hlist(struct cn_hash_dev *hdev, pid_t pid, int max_len, + int *hkey, int *key_display); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #163: new file mode 100644 CHECK: Alignment should match open parenthesis #210: FILE: lib/cn_hash_test.c:43: + err = cn_display_hlist(adata[i].pid, len, &adata[i].key, + key_display); CHECK: Alignment should match open parenthesis #236: FILE: lib/cn_hash_test.c:69: + KUNIT_EXPECT_EQ_MSG(test, 0, err, + "Adding pid %d returned err %d", CHECK: Alignment should match open parenthesis #254: FILE: lib/cn_hash_test.c:87: + KUNIT_EXPECT_GT_MSG(test, err, 0, + "Deleting pid %d returned err %d", CHECK: Please use a blank line after function/struct/union/enum declarations #278: FILE: lib/cn_hash_test.c:111: +} +static void cn_hash_test_dup_add(struct kunit *test) CHECK: Please use a blank line after function/struct/union/enum declarations #331: FILE: lib/cn_hash_test.c:164: +}; +kunit_test_suite(cn_hashtable_test_module); total: 0 errors, 1 warnings, 11 checks, 279 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 7d873ee0d8cd ("connector/cn_proc: Kunit tests for threads hash table") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 1 warnings, 11 checks, 279 lines checked