WARNING: line length of 100 exceeds 80 columns
#162: FILE: tools/testing/selftests/net/ovpn/data-test.sh:26:
+			ip link add veth${p} netns peer0 type veth peer name veth${p} netns peer${p}

WARNING: line length of 95 exceeds 80 columns
#180: FILE: tools/testing/selftests/net/ovpn/data-test.sh:44:
+			ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE}

WARNING: line length of 96 exceeds 80 columns
#183: FILE: tools/testing/selftests/net/ovpn/data-test.sh:47:
+				ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 \

WARNING: line length of 97 exceeds 80 columns
#187: FILE: tools/testing/selftests/net/ovpn/data-test.sh:51:
+			ip netns exec peer${1} ${OVPN_CLI} new_peer tun${1} 1 ${1} 10.10.${1}.1 1

WARNING: line length of 94 exceeds 80 columns
#188: FILE: tools/testing/selftests/net/ovpn/data-test.sh:52:
+			ip netns exec peer${1} ${OVPN_CLI} new_key tun${1} ${1} 1 0 ${ALG} 1 \

WARNING: line length of 93 exceeds 80 columns
#193: FILE: tools/testing/selftests/net/ovpn/data-test.sh:57:
+			(ip netns exec peer0 ${OVPN_CLI} listen tun0 1 ${TCP_PEERS_FILE} && {

WARNING: line length of 95 exceeds 80 columns
#195: FILE: tools/testing/selftests/net/ovpn/data-test.sh:59:
+					ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 \

WARNING: line length of 96 exceeds 80 columns
#201: FILE: tools/testing/selftests/net/ovpn/data-test.sh:65:
+			ip netns exec peer${1} ${OVPN_CLI} connect tun${1} ${1} 10.10.${1}.1 1 \

WARNING: line length of 88 exceeds 80 columns
#212: FILE: tools/testing/selftests/net/ovpn/data-test.sh:76:
+		ip netns exec peer${p} ${OVPN_CLI} del_iface tun${p} 2>/dev/null || true

WARNING: line length of 81 exceeds 80 columns
#253: FILE: tools/testing/selftests/net/ovpn/data-test.sh:117:
+	ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 2 1 ${ALG} 0 data64.key

WARNING: line length of 87 exceeds 80 columns
#254: FILE: tools/testing/selftests/net/ovpn/data-test.sh:118:
+	ip netns exec peer${p} ${OVPN_CLI} new_key tun${p} ${p} 2 1 ${ALG} 1 data64.key

WARNING: line length of 100 exceeds 80 columns
#336: FILE: tools/testing/selftests/net/ovpn/float-test.sh:26:
+			ip link add veth${p} netns peer0 type veth peer name veth${p} netns peer${p}

WARNING: line length of 95 exceeds 80 columns
#354: FILE: tools/testing/selftests/net/ovpn/float-test.sh:44:
+			ip netns exec peer0 ${OVPN_CLI} new_multi_peer tun0 1 ${UDP_PEERS_FILE}

WARNING: line length of 96 exceeds 80 columns
#357: FILE: tools/testing/selftests/net/ovpn/float-test.sh:47:
+				ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 ${ALG} 0 \

WARNING: line length of 97 exceeds 80 columns
#361: FILE: tools/testing/selftests/net/ovpn/float-test.sh:51:
+			ip netns exec peer${1} ${OVPN_CLI} new_peer tun${1} 1 ${1} 10.10.${1}.1 1

WARNING: line length of 94 exceeds 80 columns
#362: FILE: tools/testing/selftests/net/ovpn/float-test.sh:52:
+			ip netns exec peer${1} ${OVPN_CLI} new_key tun${1} ${1} 1 0 ${ALG} 1 \

WARNING: line length of 93 exceeds 80 columns
#367: FILE: tools/testing/selftests/net/ovpn/float-test.sh:57:
+			(ip netns exec peer0 ${OVPN_CLI} listen tun0 1 ${TCP_PEERS_FILE} && {

WARNING: line length of 95 exceeds 80 columns
#369: FILE: tools/testing/selftests/net/ovpn/float-test.sh:59:
+					ip netns exec peer0 ${OVPN_CLI} new_key tun0 ${p} 1 0 \

WARNING: line length of 96 exceeds 80 columns
#375: FILE: tools/testing/selftests/net/ovpn/float-test.sh:65:
+			ip netns exec peer${1} ${OVPN_CLI} connect tun${1} ${1} 10.10.${1}.1 1 \

WARNING: line length of 88 exceeds 80 columns
#386: FILE: tools/testing/selftests/net/ovpn/float-test.sh:76:
+		ip netns exec peer${p} ${OVPN_CLI} del_iface tun${p} 2>/dev/null || true

WARNING: __always_unused or __maybe_unused is preferred over __attribute__((__unused__))
#475: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:37:
+#define __always_unused __attribute__((__unused__))

WARNING: Macros with flow control statements should be avoided
#1391: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:953:
+#define OVPN_ADDATTR(_msg, _max_size, _attr, _data, _size) {		\
+	if (ovpn_addattr(_msg, _max_size, _attr, _data, _size) < 0)	\
+		goto err;                                               \
+}

CHECK: Macro argument '_nest' may be better as '(_nest)' to avoid precedence issues
#1406: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:968:
+#define OVPN_NEST_END(_msg, _nest) {					\
+	_nest->rta_len = (void *)NLMSG_TAIL(_msg) - (void *)_nest;	\
+}

WARNING: line length of 91 exceeds 80 columns
#1571: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:1133:
+		 * iov_len is modified by recvmsg(), therefore has to be initialized before

WARNING: Missing a blank line after declarations
#1639: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:1201:
+						int r = cb(h, arg_cb);
+						if (r <= 0)

WARNING: Too many leading tabs - consider code refactoring
#1639: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:1201:
+						if (r <= 0)

WARNING: line length of 85 exceeds 80 columns
#1779: FILE: tools/testing/selftests/net/ovpn/ovpn-cli.c:1341:
+			    grp->group, nla_len(tb_mcgrp[CTRL_ATTR_MCAST_GRP_NAME])))

total: 0 errors, 26 warnings, 1 checks, 2481 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 00ac72f93374 ("testing/selftest: add test tool and scripts for ovpn module") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 26 warnings, 1 checks, 2481 lines checked