CHECK: Alignment should match open parenthesis
#53: FILE: drivers/connector/cn_hash.c:193:
+int cn_hash_display_hlist(struct cn_hash_dev *hdev, pid_t pid, int max_len,
+				int *hkey, int *key_display)

CHECK: Alignment should match open parenthesis
#63: FILE: drivers/connector/cn_hash.c:203:
+	hlist_for_each_entry(hnode,
+			&hdev->uexit_pid_htable[key],

CHECK: Comparison to NULL could be written "!hnode->uexit_pid_hlist.next"
#66: FILE: drivers/connector/cn_hash.c:206:
+			if (hnode->uexit_pid_hlist.next == NULL)

CHECK: Unnecessary parentheses around 'key_display[key] != 1'
#76: FILE: drivers/connector/cn_hash.c:216:
+	if ((key_display[key] != 1) && !count)

CHECK: Alignment should match open parenthesis
#85: FILE: drivers/connector/cn_hash.c:225:
+		pr_err("%d entries in hlist for key %d, expected %d\n",
+				count, key, max_len);

CHECK: Alignment should match open parenthesis
#120: FILE: drivers/connector/connector.c:325:
+int cn_display_hlist(pid_t pid, int max_len, int *hkey,
+			int *key_display)

CHECK: Alignment should match open parenthesis
#160: FILE: include/linux/connector.h:185:
+int cn_hash_display_hlist(struct cn_hash_dev *hdev, pid_t pid, int max_len,
+				int *hkey, int *key_display);

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#204: 
new file mode 100644

CHECK: Alignment should match open parenthesis
#251: FILE: lib/cn_hash_test.c:43:
+		err = cn_display_hlist(adata[i].pid, len, &adata[i].key,
+					key_display);

CHECK: Alignment should match open parenthesis
#277: FILE: lib/cn_hash_test.c:69:
+		KUNIT_EXPECT_EQ_MSG(test, 0, err,
+				"Adding pid %d returned err %d",

CHECK: Alignment should match open parenthesis
#295: FILE: lib/cn_hash_test.c:87:
+		KUNIT_EXPECT_EQ_MSG(test, 0, err,
+				"Deleting pid %d returned err %d",

CHECK: Please use a blank line after function/struct/union/enum declarations
#319: FILE: lib/cn_hash_test.c:111:
+}
+static void cn_hash_test_dup_add(struct kunit *test)

CHECK: Please use a blank line after function/struct/union/enum declarations
#372: FILE: lib/cn_hash_test.c:164:
+};
+kunit_test_suite(cn_hashtable_test_module);

CHECK: extern prototypes should be avoided in .h files
#387: FILE: lib/cn_hash_test.h:6:
+extern int cn_display_hlist(pid_t pid, int max_len, int *hkey,

CHECK: Alignment should match open parenthesis
#388: FILE: lib/cn_hash_test.h:7:
+extern int cn_display_hlist(pid_t pid, int max_len, int *hkey,
+				int *key_display);

CHECK: extern prototypes should be avoided in .h files
#389: FILE: lib/cn_hash_test.h:8:
+extern int cn_del_elem(pid_t pid);

CHECK: extern prototypes should be avoided in .h files
#390: FILE: lib/cn_hash_test.h:9:
+extern int cn_add_elem(__u32 uexit_code, pid_t pid);

CHECK: extern prototypes should be avoided in .h files
#391: FILE: lib/cn_hash_test.h:10:
+extern __u32 cn_del_get_exval(pid_t pid);

CHECK: extern prototypes should be avoided in .h files
#392: FILE: lib/cn_hash_test.h:11:
+extern int cn_get_exval(pid_t pid);

CHECK: extern prototypes should be avoided in .h files
#393: FILE: lib/cn_hash_test.h:12:
+extern bool cn_table_empty(void);

total: 0 errors, 1 warnings, 19 checks, 319 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit b0a5906ce149 ("connector/cn_proc: Kunit tests for threads hash table") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 19 checks, 319 lines checked