WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 CHECK: Alignment should match open parenthesis #103: FILE: drivers/connector/cn_hash.c:41: + hash_for_each_safe(hdev->uexit_pid_htable, bucket, tmp, + hnode, uexit_pid_hlist) { CHECK: Alignment should match open parenthesis #106: FILE: drivers/connector/cn_hash.c:44: + pr_debug("%s: Freeing node for pid %d\n", + __func__, hnode->pid); CHECK: Alignment should match open parenthesis #115: FILE: drivers/connector/cn_hash.c:53: + pr_info("Waiting for %s to become free: refcnt=%d\n", + hdev->name, atomic_read(&hdev->hrefcnt)); CHECK: Alignment should match open parenthesis #148: FILE: drivers/connector/cn_hash.c:86: + pr_err("%s: cn_hash_alloc_elem() returned NULL pid %d\n", + __func__, pid); CHECK: Alignment should match open parenthesis #157: FILE: drivers/connector/cn_hash.c:95: + hash_for_each_possible(hdev->uexit_pid_htable, + hnode, uexit_pid_hlist, pid) { CHECK: Alignment should match open parenthesis #162: FILE: drivers/connector/cn_hash.c:100: + pr_debug("%s: pid %d already exists in hash table\n", + __func__, pid); CHECK: Alignment should match open parenthesis #173: FILE: drivers/connector/cn_hash.c:111: + pr_debug("%s: After hash_add of pid %d elem %p hrefcnt %d\n", + __func__, pid, elem, atomic_read(&hdev->hrefcnt)); CHECK: Alignment should match open parenthesis #184: FILE: drivers/connector/cn_hash.c:122: + hash_for_each_possible_safe(hdev->uexit_pid_htable, + hnode, tmp, uexit_pid_hlist, pid) { CHECK: Alignment should match open parenthesis #191: FILE: drivers/connector/cn_hash.c:129: + pr_debug("%s: After hash_del of pid %d, hrefcnt %d\n", + __func__, pid, CHECK: Alignment should match open parenthesis #199: FILE: drivers/connector/cn_hash.c:137: + pr_err("%s: pid %d not found in hash table\n", + __func__, pid); CHECK: Alignment should match open parenthesis #211: FILE: drivers/connector/cn_hash.c:149: + hash_for_each_possible_safe(hdev->uexit_pid_htable, + hnode, tmp, uexit_pid_hlist, pid) { CHECK: Alignment should match open parenthesis #219: FILE: drivers/connector/cn_hash.c:157: + pr_debug("%s: After hash_del of pid %d, found exit code %u hrefcnt %d\n", + __func__, pid, excde, CHECK: Alignment should match open parenthesis #227: FILE: drivers/connector/cn_hash.c:165: + pr_err("%s: pid %d not found in hash table\n", + __func__, pid); CHECK: Alignment should match open parenthesis #238: FILE: drivers/connector/cn_hash.c:176: + hash_for_each_possible(hdev->uexit_pid_htable, + hnode, uexit_pid_hlist, pid) { CHECK: Alignment should match open parenthesis #243: FILE: drivers/connector/cn_hash.c:181: + pr_debug("%s: Found exit code %u for pid %d\n", + __func__, excde, pid); CHECK: Alignment should match open parenthesis #250: FILE: drivers/connector/cn_hash.c:188: + pr_debug("%s: pid %d not found in hash table\n", + __func__, pid); CHECK: Alignment should match open parenthesis #302: FILE: drivers/connector/cn_proc.c:357: + pr_debug("%s: Returning with task's exit code %u\n", + __func__, task->exit_code); CHECK: Alignment should match open parenthesis #307: FILE: drivers/connector/cn_proc.c:362: + pr_debug("%s: Reset PF_EXIT_NOTIFY & retrieved exit code %u from hash table, pid %d\n", + __func__, task->pid, CHECK: Alignment should match open parenthesis #323: FILE: drivers/connector/cn_proc.c:446: + pr_debug("%s: Received PROC_CN_MCAST_NOTIFY, pid %d\n", + __func__, current->pid); WARNING: Possible unnecessary 'out of memory' message #337: FILE: drivers/connector/cn_proc.c:472: if (sk->sk_user_data == NULL) { + pr_err("%s: ENOMEM for sk_user_data, pid %d\n", CHECK: Alignment should match open parenthesis #338: FILE: drivers/connector/cn_proc.c:473: + pr_err("%s: ENOMEM for sk_user_data, pid %d\n", + __func__, current->pid); CHECK: Alignment should match open parenthesis #347: FILE: drivers/connector/cn_proc.c:485: + pr_debug("%s: sk: %p pid: %d event_type: %x\n", + __func__, sk, current->pid, ev_type); CHECK: Unnecessary parentheses around 'prev_mc_op != PROC_CN_MCAST_LISTEN' #354: FILE: drivers/connector/cn_proc.c:491: + if (initial || (prev_mc_op != PROC_CN_MCAST_LISTEN)) { CHECK: Alignment should match open parenthesis #357: FILE: drivers/connector/cn_proc.c:494: + pr_debug("%s: PROC_CN_MCAST_LISTEN pid %d: Incremented listeners to %d\n", + __func__, current->pid, CHECK: Unnecessary parentheses around 'prev_mc_op != PROC_CN_MCAST_IGNORE' #363: FILE: drivers/connector/cn_proc.c:499: + if (!initial && (prev_mc_op != PROC_CN_MCAST_IGNORE)) { CHECK: Alignment should match open parenthesis #366: FILE: drivers/connector/cn_proc.c:502: + pr_debug("%s: PROC_CN_MCAST_IGNORE pid %d: Decremented listeners to %d\n", + __func__, current->pid, CHECK: Alignment should match open parenthesis #374: FILE: drivers/connector/cn_proc.c:510: + pr_warn("%s: Invalid value for mc_op %d\n", + __func__, mc_op); CHECK: Alignment should match open parenthesis #457: FILE: drivers/connector/connector.c:349: + pr_err("%s: netlink_kernel_create failed, connector not initialized\n", + __func__); CHECK: Alignment should match open parenthesis #464: FILE: drivers/connector/connector.c:356: + pr_err("%s: Allocation of dev->cbdev failed, connector not initialized\n", + __func__); CHECK: Alignment should match open parenthesis #472: FILE: drivers/connector/connector.c:364: + pr_err("%s: Allocation of dev->hdev failed, connector not initialized\n", + __func__); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. #483: FILE: drivers/connector/connector.c:374: + proc_create_single("connector", S_IRUGO, init_net.proc_net, CHECK: Alignment should match open parenthesis #484: FILE: drivers/connector/connector.c:375: + proc_create_single("connector", S_IRUGO, init_net.proc_net, + cn_proc_show); CHECK: struct mutex definition without comment #522: FILE: include/linux/connector.h:59: + struct mutex uexit_hash_lock; CHECK: Alignment should match open parenthesis #544: FILE: include/linux/connector.h:159: +struct uexit_pid_hnode *cn_hash_find_pid_node(struct cn_hash_dev *hdev, + pid_t pid); CHECK: Alignment should match open parenthesis #558: FILE: include/linux/connector.h:173: +struct uexit_pid_hnode *cn_hash_find_pid_node(struct cn_hash_dev *hdev, + pid_t pid); WARNING: line length of 140 exceeds 80 columns #578: FILE: include/linux/sched.h:1676: +#define PF_EXIT_NOTIFY 0x00010000 /* This thread has sent an exit value to be sent as a notification to listening processes */ total: 0 errors, 4 warnings, 33 checks, 510 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit fc24cf82843b ("connector/cn_proc: Add hash table for threads") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 4 warnings, 33 checks, 510 lines checked