WARNING: please write a help paragraph that fully describes the config symbol #104: FILE: drivers/net/dsa/mv88e6xxx/Kconfig:21: +config NET_DSA_MV88E6XXX_LEDS + bool "LED support for Marvell 88E6xxx" + default y + depends on NET_DSA_MV88E6XXX + depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_MV88E6XXX + depends on LEDS_TRIGGERS + help + This enabled support for controlling the LEDs attached to the + Marvell 88E6xxx switch chips. WARNING: line length of 87 exceeds 80 columns #165: FILE: drivers/net/dsa/mv88e6xxx/chip.c:3399: + p->fiber = fwnode_property_present(port_fwnode, "sfp"); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #260: new file mode 100644 WARNING: line length of 83 exceeds 80 columns #276: FILE: drivers/net/dsa/mv88e6xxx/leds.c:12: +static int mv88e6xxx_port_led_write(struct mv88e6xxx_chip *chip, int port, u16 reg) WARNING: line length of 81 exceeds 80 columns #280: FILE: drivers/net/dsa/mv88e6xxx/leds.c:16: + return mv88e6xxx_port_write(chip, port, MV88E6XXX_PORT_LED_CONTROL, reg); WARNING: line length of 84 exceeds 80 columns #305: FILE: drivers/net/dsa/mv88e6xxx/leds.c:41: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, WARNING: line length of 81 exceeds 80 columns #335: FILE: drivers/net/dsa/mv88e6xxx/leds.c:71: + enum led_brightness brightness) WARNING: line length of 83 exceeds 80 columns #337: FILE: drivers/net/dsa/mv88e6xxx/leds.c:73: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 81 exceeds 80 columns #348: FILE: drivers/net/dsa/mv88e6xxx/leds.c:84: + enum led_brightness brightness) WARNING: line length of 83 exceeds 80 columns #350: FILE: drivers/net/dsa/mv88e6xxx/leds.c:86: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 86 exceeds 80 columns #401: FILE: drivers/net/dsa/mv88e6xxx/leds.c:137: + .rules = BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 84 exceeds 80 columns #408: FILE: drivers/net/dsa/mv88e6xxx/leds.c:144: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_100), WARNING: line length of 84 exceeds 80 columns #438: FILE: drivers/net/dsa/mv88e6xxx/leds.c:174: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_100), WARNING: line length of 85 exceeds 80 columns #501: FILE: drivers/net/dsa/mv88e6xxx/leds.c:237: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 85 exceeds 80 columns #522: FILE: drivers/net/dsa/mv88e6xxx/leds.c:258: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 85 exceeds 80 columns #529: FILE: drivers/net/dsa/mv88e6xxx/leds.c:265: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 86 exceeds 80 columns #581: FILE: drivers/net/dsa/mv88e6xxx/leds.c:317: + .rules = BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 86 exceeds 80 columns #587: FILE: drivers/net/dsa/mv88e6xxx/leds.c:323: + .rules = BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 95 exceeds 80 columns #601: FILE: drivers/net/dsa/mv88e6xxx/leds.c:337: +static int mv88e6xxx_led_match_selector(struct mv88e6xxx_port *p, int led, bool blink_activity, WARNING: line length of 87 exceeds 80 columns #602: FILE: drivers/net/dsa/mv88e6xxx/leds.c:338: + bool fiber, unsigned long rules, u16 *selector) WARNING: line length of 81 exceeds 80 columns #646: FILE: drivers/net/dsa/mv88e6xxx/leds.c:382: +/* mv88e6xxx_led_match_selector() - find Linux netdev rules from a selector value WARNING: line length of 95 exceeds 80 columns #653: FILE: drivers/net/dsa/mv88e6xxx/leds.c:389: +mv88e6xxx_led_match_rule(struct mv88e6xxx_port *p, u16 selector, int led, unsigned long *rules) WARNING: line length of 85 exceeds 80 columns #690: FILE: drivers/net/dsa/mv88e6xxx/leds.c:426: + bool fiber, unsigned long rules, u16 *selector) WARNING: line length of 82 exceeds 80 columns #699: FILE: drivers/net/dsa/mv88e6xxx/leds.c:435: + err = mv88e6xxx_led_match_selector(p, led, false, fiber, rules, selector); WARNING: line length of 90 exceeds 80 columns #701: FILE: drivers/net/dsa/mv88e6xxx/leds.c:437: + return mv88e6xxx_led_match_selector(p, led, true, fiber, rules, selector); WARNING: line length of 93 exceeds 80 columns #708: FILE: drivers/net/dsa/mv88e6xxx/leds.c:444: + unsigned long delay_on, unsigned long delay_off) WARNING: line length of 83 exceeds 80 columns #746: FILE: drivers/net/dsa/mv88e6xxx/leds.c:482: + /* This is usually pretty useless and will make the LED look OFF */ WARNING: line length of 85 exceeds 80 columns #774: FILE: drivers/net/dsa/mv88e6xxx/leds.c:510: + unsigned long *delay_on, unsigned long *delay_off) WARNING: line length of 84 exceeds 80 columns #794: FILE: drivers/net/dsa/mv88e6xxx/leds.c:530: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, WARNING: line length of 83 exceeds 80 columns #819: FILE: drivers/net/dsa/mv88e6xxx/leds.c:555: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #833: FILE: drivers/net/dsa/mv88e6xxx/leds.c:569: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 86 exceeds 80 columns #844: FILE: drivers/net/dsa/mv88e6xxx/leds.c:580: +mv88e6xxx_led0_hw_control_is_supported(struct led_classdev *ldev, unsigned long rules) WARNING: line length of 83 exceeds 80 columns #846: FILE: drivers/net/dsa/mv88e6xxx/leds.c:582: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 86 exceeds 80 columns #853: FILE: drivers/net/dsa/mv88e6xxx/leds.c:589: +mv88e6xxx_led1_hw_control_is_supported(struct led_classdev *ldev, unsigned long rules) WARNING: line length of 83 exceeds 80 columns #855: FILE: drivers/net/dsa/mv88e6xxx/leds.c:591: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 84 exceeds 80 columns #868: FILE: drivers/net/dsa/mv88e6xxx/leds.c:604: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, WARNING: line length of 88 exceeds 80 columns #887: FILE: drivers/net/dsa/mv88e6xxx/leds.c:623: + (unsigned int)(reg & MV88E6XXX_PORT_LED_CONTROL_LED0_SEL_MASK)); WARNING: line length of 93 exceeds 80 columns #891: FILE: drivers/net/dsa/mv88e6xxx/leds.c:627: + (unsigned int)(reg & MV88E6XXX_PORT_LED_CONTROL_LED1_SEL_MASK) >> 4); WARNING: line length of 85 exceeds 80 columns #897: FILE: drivers/net/dsa/mv88e6xxx/leds.c:633: +mv88e6xxx_led_hw_control_get(struct mv88e6xxx_port *p, int led, unsigned long *rules) WARNING: line length of 91 exceeds 80 columns #904: FILE: drivers/net/dsa/mv88e6xxx/leds.c:640: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, &val); WARNING: line length of 81 exceeds 80 columns #934: FILE: drivers/net/dsa/mv88e6xxx/leds.c:670: + dev_dbg(p->chip->dev, "couldn't find matching selector for %04x\n", val); WARNING: line length of 83 exceeds 80 columns #942: FILE: drivers/net/dsa/mv88e6xxx/leds.c:678: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #955: FILE: drivers/net/dsa/mv88e6xxx/leds.c:691: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 83 exceeds 80 columns #968: FILE: drivers/net/dsa/mv88e6xxx/leds.c:704: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #976: FILE: drivers/net/dsa/mv88e6xxx/leds.c:712: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 83 exceeds 80 columns #981: FILE: drivers/net/dsa/mv88e6xxx/leds.c:717: +static struct device *mv88e6xxx_led_hw_control_get_device(struct mv88e6xxx_port *p) WARNING: line length of 83 exceeds 80 columns #996: FILE: drivers/net/dsa/mv88e6xxx/leds.c:732: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #1004: FILE: drivers/net/dsa/mv88e6xxx/leds.c:740: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 92 exceeds 80 columns #1069: FILE: drivers/net/dsa/mv88e6xxx/leds.c:805: + l->brightness_set_blocking = mv88e6xxx_led0_brightness_set_blocking; WARNING: line length of 92 exceeds 80 columns #1071: FILE: drivers/net/dsa/mv88e6xxx/leds.c:807: + l->hw_control_is_supported = mv88e6xxx_led0_hw_control_is_supported; WARNING: line length of 88 exceeds 80 columns #1074: FILE: drivers/net/dsa/mv88e6xxx/leds.c:810: + l->hw_control_get_device = mv88e6xxx_led0_hw_control_get_device; WARNING: line length of 92 exceeds 80 columns #1076: FILE: drivers/net/dsa/mv88e6xxx/leds.c:812: + l->brightness_set_blocking = mv88e6xxx_led1_brightness_set_blocking; WARNING: line length of 92 exceeds 80 columns #1078: FILE: drivers/net/dsa/mv88e6xxx/leds.c:814: + l->hw_control_is_supported = mv88e6xxx_led1_hw_control_is_supported; WARNING: line length of 88 exceeds 80 columns #1081: FILE: drivers/net/dsa/mv88e6xxx/leds.c:817: + l->hw_control_get_device = mv88e6xxx_led1_hw_control_get_device; WARNING: line length of 92 exceeds 80 columns #1088: FILE: drivers/net/dsa/mv88e6xxx/leds.c:824: + init_data.devicename = kasprintf(GFP_KERNEL, "%s:0%d:0%d", chip->info->name, WARNING: line length of 89 exceeds 80 columns #1097: FILE: drivers/net/dsa/mv88e6xxx/leds.c:833: + dev_err(dev, "Failed to init LED %d for port %d", led_num, port); WARNING: line length of 106 exceeds 80 columns #1128: FILE: drivers/net/dsa/mv88e6xxx/port.h:316: +#define MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL (0x00 << 12) /* Control for LED 0 and 1 */ WARNING: line length of 104 exceeds 80 columns #1129: FILE: drivers/net/dsa/mv88e6xxx/port.h:317: +#define MV88E6XXX_PORT_LED_CONTROL_POINTER_STRETCH_BLINK (0x06 << 12) /* Stetch and Blink Rate */ WARNING: line length of 117 exceeds 80 columns #1130: FILE: drivers/net/dsa/mv88e6xxx/port.h:318: +#define MV88E6XXX_PORT_LED_CONTROL_POINTER_CNTL_SPECIAL (0x07 << 12) /* Control for the Port's Special LED */ WARNING: line length of 84 exceeds 80 columns #1138: FILE: drivers/net/dsa/mv88e6xxx/port.h:326: + * 4..7 LED 1 control selector on ports 1-4 on port 5 this controls LED 0 of port 6 WARNING: line length of 107 exceeds 80 columns #1141: FILE: drivers/net/dsa/mv88e6xxx/port.h:329: + * 0 1-4 0 Link/Act/Speed by Blink Rate (off=no link, on=link, blink=activity, blink speed=link speed) WARNING: line length of 84 exceeds 80 columns #1145: FILE: drivers/net/dsa/mv88e6xxx/port.h:333: + * 1 1-4 0 100/1000 Link/Act (off=no link, on=100 or 1000 link, blink=activity) WARNING: line length of 81 exceeds 80 columns #1165: FILE: drivers/net/dsa/mv88e6xxx/port.h:353: + * 6 1-4 0 Duplex/Collision (off=half-duplex,on=full-duplex,blink=collision) WARNING: line length of 82 exceeds 80 columns #1166: FILE: drivers/net/dsa/mv88e6xxx/port.h:354: + * 1-4 1 10/1000 Link/Act (off=no link, on=10 or 1000 link, blink=activity) WARNING: line length of 84 exceeds 80 columns #1167: FILE: drivers/net/dsa/mv88e6xxx/port.h:355: + * 5-6 0 Port 5 Duplex/Collision (off=half-duplex, on=full-duplex, blink=col) WARNING: line length of 84 exceeds 80 columns #1168: FILE: drivers/net/dsa/mv88e6xxx/port.h:356: + * 5-6 1 Port 6 Duplex/Collision (off=half-duplex, on=full-duplex, blink=col) WARNING: line length of 82 exceeds 80 columns #1169: FILE: drivers/net/dsa/mv88e6xxx/port.h:357: + * 7 1-4 0 10/1000 Link/Act (off=no link, on=10 or 1000 link, blink=activity) WARNING: line length of 114 exceeds 80 columns #1171: FILE: drivers/net/dsa/mv88e6xxx/port.h:359: + * 5-6 0 Port 5 Link/Act/Speed by Blink rate (off=no link, on=link, blink=activity, blink speed=link speed) WARNING: line length of 115 exceeds 80 columns #1172: FILE: drivers/net/dsa/mv88e6xxx/port.h:360: + * 5-6 1 Port 6 Link/Act/Speed by Blink rate (off=no link, on=link, blink=activity, blink speed=link speed) CHECK: Prefer using the BIT macro #1230: FILE: drivers/net/dsa/mv88e6xxx/port.h:418: +#define MV88E6XXX_PORT_LED_CONTROL_0x06_PULSE_STRETCH_21MS (1 << 4) WARNING: line length of 102 exceeds 80 columns #1242: FILE: drivers/net/dsa/mv88e6xxx/port.h:430: +#define MV88E6XXX_PORT_LED_CONTROL_0x07_P0_LAN_LINKACT_SHIFT 0 /* bits 6:0 LAN Link Activity LED */ WARNING: line length of 102 exceeds 80 columns #1244: FILE: drivers/net/dsa/mv88e6xxx/port.h:432: +#define MV88E6XXX_PORT_LED_CONTROL_0x07_P1_WAN_LINKACT_SHIFT 0 /* bits 6:0 WAN Link Activity LED */ WARNING: line length of 93 exceeds 80 columns #1246: FILE: drivers/net/dsa/mv88e6xxx/port.h:434: +#define MV88E6XXX_PORT_LED_CONTROL_0x07_P2_PTP_ACT 0 /* bits 6:0 PTP Activity */ total: 0 errors, 72 warnings, 1 checks, 1127 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 90917988fa33 ("net: dsa: mv88e6xxx: Support LED control") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 72 warnings, 1 checks, 1127 lines checked