WARNING: please write a help paragraph that fully describes the config symbol #101: FILE: drivers/net/dsa/mv88e6xxx/Kconfig:21: +config NET_DSA_MV88E6XXX_LEDS + bool "LED support for Marvell 88E6xxx" + default y + depends on NET_DSA_MV88E6XXX + depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_MV88E6XXX + depends on LEDS_TRIGGERS + help + This enabled support for controlling the LEDs attached to the + Marvell 88E6xxx switch chips. WARNING: line length of 87 exceeds 80 columns #162: FILE: drivers/net/dsa/mv88e6xxx/chip.c:3399: + p->fiber = fwnode_property_present(port_fwnode, "sfp"); WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #233: new file mode 100644 WARNING: line length of 83 exceeds 80 columns #249: FILE: drivers/net/dsa/mv88e6xxx/leds.c:12: +static int mv88e6xxx_port_led_write(struct mv88e6xxx_chip *chip, int port, u16 reg) WARNING: line length of 81 exceeds 80 columns #253: FILE: drivers/net/dsa/mv88e6xxx/leds.c:16: + return mv88e6xxx_port_write(chip, port, MV88E6XXX_PORT_LED_CONTROL, reg); WARNING: line length of 84 exceeds 80 columns #278: FILE: drivers/net/dsa/mv88e6xxx/leds.c:41: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, WARNING: line length of 81 exceeds 80 columns #308: FILE: drivers/net/dsa/mv88e6xxx/leds.c:71: + enum led_brightness brightness) WARNING: line length of 83 exceeds 80 columns #310: FILE: drivers/net/dsa/mv88e6xxx/leds.c:73: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 81 exceeds 80 columns #321: FILE: drivers/net/dsa/mv88e6xxx/leds.c:84: + enum led_brightness brightness) WARNING: line length of 83 exceeds 80 columns #323: FILE: drivers/net/dsa/mv88e6xxx/leds.c:86: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 86 exceeds 80 columns #374: FILE: drivers/net/dsa/mv88e6xxx/leds.c:137: + .rules = BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 84 exceeds 80 columns #381: FILE: drivers/net/dsa/mv88e6xxx/leds.c:144: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_100), WARNING: line length of 84 exceeds 80 columns #411: FILE: drivers/net/dsa/mv88e6xxx/leds.c:174: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_100), WARNING: line length of 85 exceeds 80 columns #474: FILE: drivers/net/dsa/mv88e6xxx/leds.c:237: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 85 exceeds 80 columns #495: FILE: drivers/net/dsa/mv88e6xxx/leds.c:258: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 85 exceeds 80 columns #502: FILE: drivers/net/dsa/mv88e6xxx/leds.c:265: + .rules = BIT(TRIGGER_NETDEV_LINK_10) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 86 exceeds 80 columns #554: FILE: drivers/net/dsa/mv88e6xxx/leds.c:317: + .rules = BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 86 exceeds 80 columns #560: FILE: drivers/net/dsa/mv88e6xxx/leds.c:323: + .rules = BIT(TRIGGER_NETDEV_LINK_100) | BIT(TRIGGER_NETDEV_LINK_1000), WARNING: line length of 95 exceeds 80 columns #574: FILE: drivers/net/dsa/mv88e6xxx/leds.c:337: +static int mv88e6xxx_led_match_selector(struct mv88e6xxx_port *p, int led, bool blink_activity, WARNING: line length of 87 exceeds 80 columns #575: FILE: drivers/net/dsa/mv88e6xxx/leds.c:338: + bool fiber, unsigned long rules, u16 *selector) WARNING: line length of 81 exceeds 80 columns #619: FILE: drivers/net/dsa/mv88e6xxx/leds.c:382: +/* mv88e6xxx_led_match_selector() - find Linux netdev rules from a selector value WARNING: line length of 95 exceeds 80 columns #626: FILE: drivers/net/dsa/mv88e6xxx/leds.c:389: +mv88e6xxx_led_match_rule(struct mv88e6xxx_port *p, u16 selector, int led, unsigned long *rules) WARNING: line length of 85 exceeds 80 columns #663: FILE: drivers/net/dsa/mv88e6xxx/leds.c:426: + bool fiber, unsigned long rules, u16 *selector) WARNING: line length of 82 exceeds 80 columns #672: FILE: drivers/net/dsa/mv88e6xxx/leds.c:435: + err = mv88e6xxx_led_match_selector(p, led, false, fiber, rules, selector); WARNING: line length of 90 exceeds 80 columns #674: FILE: drivers/net/dsa/mv88e6xxx/leds.c:437: + return mv88e6xxx_led_match_selector(p, led, true, fiber, rules, selector); WARNING: line length of 93 exceeds 80 columns #681: FILE: drivers/net/dsa/mv88e6xxx/leds.c:444: + unsigned long delay_on, unsigned long delay_off) WARNING: line length of 83 exceeds 80 columns #719: FILE: drivers/net/dsa/mv88e6xxx/leds.c:482: + /* This is usually pretty useless and will make the LED look OFF */ WARNING: line length of 85 exceeds 80 columns #747: FILE: drivers/net/dsa/mv88e6xxx/leds.c:510: + unsigned long *delay_on, unsigned long *delay_off) WARNING: line length of 84 exceeds 80 columns #767: FILE: drivers/net/dsa/mv88e6xxx/leds.c:530: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, WARNING: line length of 83 exceeds 80 columns #792: FILE: drivers/net/dsa/mv88e6xxx/leds.c:555: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #806: FILE: drivers/net/dsa/mv88e6xxx/leds.c:569: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 86 exceeds 80 columns #817: FILE: drivers/net/dsa/mv88e6xxx/leds.c:580: +mv88e6xxx_led0_hw_control_is_supported(struct led_classdev *ldev, unsigned long rules) WARNING: line length of 83 exceeds 80 columns #819: FILE: drivers/net/dsa/mv88e6xxx/leds.c:582: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 86 exceeds 80 columns #826: FILE: drivers/net/dsa/mv88e6xxx/leds.c:589: +mv88e6xxx_led1_hw_control_is_supported(struct led_classdev *ldev, unsigned long rules) WARNING: line length of 83 exceeds 80 columns #828: FILE: drivers/net/dsa/mv88e6xxx/leds.c:591: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 84 exceeds 80 columns #841: FILE: drivers/net/dsa/mv88e6xxx/leds.c:604: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, WARNING: line length of 88 exceeds 80 columns #860: FILE: drivers/net/dsa/mv88e6xxx/leds.c:623: + (unsigned int)(reg & MV88E6XXX_PORT_LED_CONTROL_LED0_SEL_MASK)); WARNING: line length of 93 exceeds 80 columns #864: FILE: drivers/net/dsa/mv88e6xxx/leds.c:627: + (unsigned int)(reg & MV88E6XXX_PORT_LED_CONTROL_LED1_SEL_MASK) >> 4); WARNING: line length of 85 exceeds 80 columns #870: FILE: drivers/net/dsa/mv88e6xxx/leds.c:633: +mv88e6xxx_led_hw_control_get(struct mv88e6xxx_port *p, int led, unsigned long *rules) WARNING: line length of 91 exceeds 80 columns #877: FILE: drivers/net/dsa/mv88e6xxx/leds.c:640: + MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL, &val); WARNING: line length of 81 exceeds 80 columns #907: FILE: drivers/net/dsa/mv88e6xxx/leds.c:670: + dev_dbg(p->chip->dev, "couldn't find matching selector for %04x\n", val); WARNING: line length of 83 exceeds 80 columns #915: FILE: drivers/net/dsa/mv88e6xxx/leds.c:678: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #928: FILE: drivers/net/dsa/mv88e6xxx/leds.c:691: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 83 exceeds 80 columns #941: FILE: drivers/net/dsa/mv88e6xxx/leds.c:704: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #949: FILE: drivers/net/dsa/mv88e6xxx/leds.c:712: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 83 exceeds 80 columns #954: FILE: drivers/net/dsa/mv88e6xxx/leds.c:717: +static struct device *mv88e6xxx_led_hw_control_get_device(struct mv88e6xxx_port *p) WARNING: line length of 83 exceeds 80 columns #969: FILE: drivers/net/dsa/mv88e6xxx/leds.c:732: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led0); WARNING: line length of 83 exceeds 80 columns #977: FILE: drivers/net/dsa/mv88e6xxx/leds.c:740: + struct mv88e6xxx_port *p = container_of(ldev, struct mv88e6xxx_port, led1); WARNING: line length of 83 exceeds 80 columns #1043: FILE: drivers/net/dsa/mv88e6xxx/leds.c:806: + mv88e6xxx_led_set_blinking_period(p, led_num, delay_on, delay_off); WARNING: line length of 92 exceeds 80 columns #1047: FILE: drivers/net/dsa/mv88e6xxx/leds.c:810: + l->brightness_set_blocking = mv88e6xxx_led0_brightness_set_blocking; WARNING: line length of 92 exceeds 80 columns #1049: FILE: drivers/net/dsa/mv88e6xxx/leds.c:812: + l->hw_control_is_supported = mv88e6xxx_led0_hw_control_is_supported; WARNING: line length of 88 exceeds 80 columns #1052: FILE: drivers/net/dsa/mv88e6xxx/leds.c:815: + l->hw_control_get_device = mv88e6xxx_led0_hw_control_get_device; WARNING: line length of 92 exceeds 80 columns #1054: FILE: drivers/net/dsa/mv88e6xxx/leds.c:817: + l->brightness_set_blocking = mv88e6xxx_led1_brightness_set_blocking; WARNING: line length of 92 exceeds 80 columns #1056: FILE: drivers/net/dsa/mv88e6xxx/leds.c:819: + l->hw_control_is_supported = mv88e6xxx_led1_hw_control_is_supported; WARNING: line length of 88 exceeds 80 columns #1059: FILE: drivers/net/dsa/mv88e6xxx/leds.c:822: + l->hw_control_get_device = mv88e6xxx_led1_hw_control_get_device; WARNING: line length of 92 exceeds 80 columns #1066: FILE: drivers/net/dsa/mv88e6xxx/leds.c:829: + init_data.devicename = kasprintf(GFP_KERNEL, "%s:0%d:0%d", chip->info->name, WARNING: line length of 89 exceeds 80 columns #1075: FILE: drivers/net/dsa/mv88e6xxx/leds.c:838: + dev_err(dev, "Failed to init LED %d for port %d", led_num, port); WARNING: line length of 106 exceeds 80 columns #1106: FILE: drivers/net/dsa/mv88e6xxx/port.h:316: +#define MV88E6XXX_PORT_LED_CONTROL_POINTER_LED01_CTRL (0x00 << 12) /* Control for LED 0 and 1 */ WARNING: line length of 104 exceeds 80 columns #1107: FILE: drivers/net/dsa/mv88e6xxx/port.h:317: +#define MV88E6XXX_PORT_LED_CONTROL_POINTER_STRETCH_BLINK (0x06 << 12) /* Stetch and Blink Rate */ WARNING: line length of 117 exceeds 80 columns #1108: FILE: drivers/net/dsa/mv88e6xxx/port.h:318: +#define MV88E6XXX_PORT_LED_CONTROL_POINTER_CNTL_SPECIAL (0x07 << 12) /* Control for the Port's Special LED */ WARNING: line length of 84 exceeds 80 columns #1116: FILE: drivers/net/dsa/mv88e6xxx/port.h:326: + * 4..7 LED 1 control selector on ports 1-4 on port 5 this controls LED 0 of port 6 WARNING: line length of 107 exceeds 80 columns #1119: FILE: drivers/net/dsa/mv88e6xxx/port.h:329: + * 0 1-4 0 Link/Act/Speed by Blink Rate (off=no link, on=link, blink=activity, blink speed=link speed) WARNING: line length of 84 exceeds 80 columns #1123: FILE: drivers/net/dsa/mv88e6xxx/port.h:333: + * 1 1-4 0 100/1000 Link/Act (off=no link, on=100 or 1000 link, blink=activity) WARNING: line length of 81 exceeds 80 columns #1143: FILE: drivers/net/dsa/mv88e6xxx/port.h:353: + * 6 1-4 0 Duplex/Collision (off=half-duplex,on=full-duplex,blink=collision) WARNING: line length of 82 exceeds 80 columns #1144: FILE: drivers/net/dsa/mv88e6xxx/port.h:354: + * 1-4 1 10/1000 Link/Act (off=no link, on=10 or 1000 link, blink=activity) WARNING: line length of 84 exceeds 80 columns #1145: FILE: drivers/net/dsa/mv88e6xxx/port.h:355: + * 5-6 0 Port 5 Duplex/Collision (off=half-duplex, on=full-duplex, blink=col) WARNING: line length of 84 exceeds 80 columns #1146: FILE: drivers/net/dsa/mv88e6xxx/port.h:356: + * 5-6 1 Port 6 Duplex/Collision (off=half-duplex, on=full-duplex, blink=col) WARNING: line length of 82 exceeds 80 columns #1147: FILE: drivers/net/dsa/mv88e6xxx/port.h:357: + * 7 1-4 0 10/1000 Link/Act (off=no link, on=10 or 1000 link, blink=activity) WARNING: line length of 114 exceeds 80 columns #1149: FILE: drivers/net/dsa/mv88e6xxx/port.h:359: + * 5-6 0 Port 5 Link/Act/Speed by Blink rate (off=no link, on=link, blink=activity, blink speed=link speed) WARNING: line length of 115 exceeds 80 columns #1150: FILE: drivers/net/dsa/mv88e6xxx/port.h:360: + * 5-6 1 Port 6 Link/Act/Speed by Blink rate (off=no link, on=link, blink=activity, blink speed=link speed) CHECK: Prefer using the BIT macro #1208: FILE: drivers/net/dsa/mv88e6xxx/port.h:418: +#define MV88E6XXX_PORT_LED_CONTROL_0x06_PULSE_STRETCH_21MS (1 << 4) WARNING: line length of 102 exceeds 80 columns #1220: FILE: drivers/net/dsa/mv88e6xxx/port.h:430: +#define MV88E6XXX_PORT_LED_CONTROL_0x07_P0_LAN_LINKACT_SHIFT 0 /* bits 6:0 LAN Link Activity LED */ WARNING: line length of 102 exceeds 80 columns #1222: FILE: drivers/net/dsa/mv88e6xxx/port.h:432: +#define MV88E6XXX_PORT_LED_CONTROL_0x07_P1_WAN_LINKACT_SHIFT 0 /* bits 6:0 WAN Link Activity LED */ WARNING: line length of 93 exceeds 80 columns #1224: FILE: drivers/net/dsa/mv88e6xxx/port.h:434: +#define MV88E6XXX_PORT_LED_CONTROL_0x07_P2_PTP_ACT 0 /* bits 6:0 PTP Activity */ total: 0 errors, 73 warnings, 1 checks, 1111 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit b2de0239e846 ("net: dsa: mv88e6xxx: Support LED control") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 73 warnings, 1 checks, 1111 lines checked