WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59: 
new file mode 100755

WARNING: Missing or malformed SPDX-License-Identifier tag in line 2
#65: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:2:
+#

WARNING: line length of 101 exceeds 80 columns
#111: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:48:
+if ! ip link add veth0 netns "$nsrouter" type veth peer name eth0 netns "$ns1" > /dev/null 2>&1; then

WARNING: line length of 97 exceeds 80 columns
#215: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:152:
+	# socat 1.8.0 has a bug that requires to specify the IP family to bind (fixed in 1.8.0.1)

WARNING: line length of 84 exceeds 80 columns
#245: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:182:
+	# traffic so the policy based routing rule redirects it and can be processed

WARNING: line length of 83 exceeds 80 columns
#253: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:190:
+		$nftables_subject tproxy $ip_proto to :12345 meta mark set 1 accept

WARNING: line length of 83 exceeds 80 columns
#267: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:204:
+		$nftables_subject tproxy $ip_proto to :12345 meta mark set 1 accept

WARNING: line length of 90 exceeds 80 columns
#279: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:216:
+	ip netns exec "$nsrouter" $ip_command route add local "${ns2_ip}" dev lo table 100

WARNING: line length of 139 exceeds 80 columns
#282: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:219:
+	timeout "$timeout" ip netns exec "$nsrouter" socat "$socat_ipproto" tcp-listen:12345,fork,ip-transparent SYSTEM:"cat" 2>/dev/null &

WARNING: line length of 128 exceeds 80 columns
#285: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:222:
+	timeout "$timeout" ip netns exec "$ns2" socat "$socat_ipproto" tcp-listen:8080,fork SYSTEM:"echo PONG_NS2" 2>/dev/null &

WARNING: line length of 128 exceeds 80 columns
#288: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:225:
+	timeout "$timeout" ip netns exec "$ns3" socat "$socat_ipproto" tcp-listen:8080,fork SYSTEM:"echo PONG_NS3" 2>/dev/null &

WARNING: line length of 93 exceeds 80 columns
#297: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:234:
+	result=$(echo I_M_PROXIED | ip netns exec "$ns1" socat -t 2 -T 2 STDIO "$ns2_target")

WARNING: line length of 95 exceeds 80 columns
#299: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:236:
+		echo "PASS: tproxy test $testname: ns1 got reply \"$result\" connecting to ns2"

WARNING: line length of 135 exceeds 80 columns
#301: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:238:
+		echo "ERROR: tproxy test $testname: ns1 got reply \"$result\" connecting to ns2, not \"${expect_ns1_ns2}\" as intended"

WARNING: line length of 93 exceeds 80 columns
#306: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:243:
+	result=$(echo I_M_PROXIED | ip netns exec "$ns1" socat -t 2 -T 2 STDIO "$ns3_target")

WARNING: line length of 95 exceeds 80 columns
#308: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:245:
+		echo "PASS: tproxy test $testname: ns1 got reply \"$result\" connecting to ns3"

WARNING: line length of 133 exceeds 80 columns
#310: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:247:
+		echo "ERROR: tproxy test $testname: ns1 got reply \"$result\" connecting to ns3, not \"$expect_ns1_ns3\" as intended"

WARNING: line length of 98 exceeds 80 columns
#315: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:252:
+	result=$(echo I_M_PROXIED | ip netns exec "$nsrouter" socat -t 2 -T 2 STDIO "$ns2_target")

WARNING: line length of 100 exceeds 80 columns
#317: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:254:
+		echo "PASS: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns2"

WARNING: line length of 143 exceeds 80 columns
#319: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:256:
+		echo "ERROR: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns2, not \"$expect_nsrouter_ns2\" as intended"

WARNING: line length of 98 exceeds 80 columns
#324: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:261:
+	result=$(echo I_M_PROXIED | ip netns exec "$nsrouter" socat -t 2 -T 2 STDIO "$ns3_target")

WARNING: line length of 100 exceeds 80 columns
#326: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:263:
+		echo "PASS: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns3"

WARNING: line length of 144 exceeds 80 columns
#328: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_tcp.sh:265:
+		echo "ERROR: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns3, not \"$expect_nsrouter_ns3\"  as intended"

WARNING: Missing or malformed SPDX-License-Identifier tag in line 2
#429: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:2:
+#

WARNING: line length of 101 exceeds 80 columns
#475: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:48:
+if ! ip link add veth0 netns "$nsrouter" type veth peer name eth0 netns "$ns1" > /dev/null 2>&1; then

WARNING: line length of 97 exceeds 80 columns
#579: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:152:
+	# socat 1.8.0 has a bug that requires to specify the IP family to bind (fixed in 1.8.0.1)

WARNING: line length of 88 exceeds 80 columns
#609: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:182:
+	ip netns exec "$nsrouter" $ip_command route add local "$ns2_ip" dev lo table 100

WARNING: line length of 104 exceeds 80 columns
#615: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:188:
+		$ip_proto daddr $ns2_ip udp dport 8080 tproxy $ip_proto to :12345 meta mark set 1 accept

WARNING: line length of 203 exceeds 80 columns
#620: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:193:
+	timeout "$timeout" ip netns exec "$nsrouter" socat -u "$socat_ipproto" udp-listen:12345,fork,ip-transparent,reuseport udp:"$ns1_ip_port",ip-transparent,reuseport,bind="$ns2_ip_port" 2>/dev/null &

WARNING: line length of 128 exceeds 80 columns
#623: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:196:
+	timeout "$timeout" ip netns exec "$ns2" socat "$socat_ipproto" udp-listen:8080,fork SYSTEM:"echo PONG_NS2" 2>/dev/null &

WARNING: line length of 128 exceeds 80 columns
#626: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:199:
+	timeout "$timeout" ip netns exec "$ns3" socat "$socat_ipproto" udp-listen:8080,fork SYSTEM:"echo PONG_NS3" 2>/dev/null &

WARNING: line length of 115 exceeds 80 columns
#635: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:208:
+	result=$(echo I_M_PROXIED | ip netns exec "$ns1" socat -t 2 -T 2 STDIO udp:"$ns2_ip_port",sourceport=18888)

WARNING: line length of 95 exceeds 80 columns
#637: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:210:
+		echo "PASS: tproxy test $testname: ns1 got reply \"$result\" connecting to ns2"

WARNING: line length of 135 exceeds 80 columns
#639: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:212:
+		echo "ERROR: tproxy test $testname: ns1 got reply \"$result\" connecting to ns2, not \"${expect_ns1_ns2}\" as intended"

WARNING: line length of 98 exceeds 80 columns
#644: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:217:
+	result=$(echo I_M_PROXIED | ip netns exec "$ns1" socat -t 2 -T 2 STDIO udp:"$ns3_ip_port")

WARNING: line length of 95 exceeds 80 columns
#646: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:219:
+		echo "PASS: tproxy test $testname: ns1 got reply \"$result\" connecting to ns3"

WARNING: line length of 133 exceeds 80 columns
#648: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:221:
+		echo "ERROR: tproxy test $testname: ns1 got reply \"$result\" connecting to ns3, not \"$expect_ns1_ns3\" as intended"

WARNING: line length of 103 exceeds 80 columns
#653: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:226:
+	result=$(echo I_M_PROXIED | ip netns exec "$nsrouter" socat -t 2 -T 2 STDIO udp:"$ns2_ip_port")

WARNING: line length of 100 exceeds 80 columns
#655: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:228:
+		echo "PASS: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns2"

WARNING: line length of 143 exceeds 80 columns
#657: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:230:
+		echo "ERROR: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns2, not \"$expect_nsrouter_ns2\" as intended"

WARNING: line length of 103 exceeds 80 columns
#662: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:235:
+	result=$(echo I_M_PROXIED | ip netns exec "$nsrouter" socat -t 2 -T 2 STDIO udp:"$ns3_ip_port")

WARNING: line length of 100 exceeds 80 columns
#664: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:237:
+		echo "PASS: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns3"

WARNING: line length of 144 exceeds 80 columns
#666: FILE: tools/testing/selftests/net/netfilter/nft_tproxy_udp.sh:239:
+		echo "ERROR: tproxy test $testname: nsrouter got reply \"$result\" connecting to ns3, not \"$expect_nsrouter_ns3\"  as intended"

total: 0 errors, 43 warnings, 0 checks, 635 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 20619664fd03 ("selftests: netfilter: nft_tproxy.sh: add tcp tests") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 43 warnings, 0 checks, 635 lines checked