WARNING: memory barrier without comment #90: FILE: include/linux/netfilter_bridge/ebtables.h:154: + smp_mb(); WARNING: memory barrier without comment #105: FILE: include/linux/netfilter_bridge/ebtables.h:169: + smp_wmb(); CHECK: Please don't use multiple blank lines #220: FILE: net/bridge/netfilter/ebtables.c:991: + CHECK: Blank lines aren't necessary after an open brace '{' #234: FILE: net/bridge/netfilter/ebtables.c:1005: + for_each_possible_cpu(cpu) { + CHECK: Please don't use multiple blank lines #256: FILE: net/bridge/netfilter/ebtables.c:1027: + + CHECK: Alignment should match open parenthesis #258: FILE: net/bridge/netfilter/ebtables.c:1029: +static void get_old_counters(const struct ebt_counter *oldcounters, + struct ebt_counter *counters, unsigned int nentries) WARNING: memory barrier without comment #292: FILE: net/bridge/netfilter/ebtables.c:1106: + smp_wmb(); WARNING: memory barrier without comment #295: FILE: net/bridge/netfilter/ebtables.c:1108: + smp_mb(); WARNING: suspect code indent for conditional statements (8, 12) #314: FILE: net/bridge/netfilter/ebtables.c:1127: + if (repl->num_counters) + get_old_counters(table->counters, counterstmp, table->nentries); WARNING: suspect code indent for conditional statements (8, 12) #380: FILE: net/bridge/netfilter/ebtables.c:2634: + for_each_possible_cpu(i) { + seqcount_init(&per_cpu(ebt_recseq, i)); total: 0 errors, 6 warnings, 4 checks, 313 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Commit 5cbc1ed68154 ("net/bridge: Optimizing read-write locks in ebtables.c") has style problems, please review. NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT BAD_REPORTED_BY_LINK CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. total: 0 errors, 6 warnings, 4 checks, 313 lines checked